Hero: no pause on hover, slow zoom on the first photo #22

Merged
Sluijsens merged 2 commits from feature/hero-full-slider into master 2026-11-17 11:17:48 +01:00
4 changed files with 59 additions and 19 deletions
Showing only changes of commit 8050072ce5 - Show all commits
@@ -3,7 +3,7 @@
Written while Bryan was away; he decides later. Each point: question, assumption, what changes with another answer, where in the code. Written while Bryan was away; he decides later. Each point: question, assumption, what changes with another answer, where in the code.
| # | Question | Assumption | If the answer differs | Where | | # | Question | Assumption | If the answer differs | Where |
| --- | -------------------------------------------------------------------------------------------------------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------- | ------------------------------------------------------------------------------ | | --- | -------------------------------------------------------------------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------- | ------------------------------------------------------------------------------ |
| 1 | Focus points of the 8 photos | Estimates from the seed (e.g. hero-8 0.50/0.55) | Change x/y in the seed (CMS) and in the baked values | `web/src/content/heroContent.ts`, `web/contract/host-injection/hero/seed.json` | | 1 | Focus points of the 8 photos | Estimates from the seed (e.g. hero-8 0.50/0.55) | Change x/y in the seed (CMS) and in the baked values | `web/src/content/heroContent.ts`, `web/contract/host-injection/hero/seed.json` |
| 2 | Is the baked hero cropped around the focus point too? | Yes: object-position from the estimates, so baked and live look the same | Pass `focus: null` for the baked slides to get plain centre crop | `heroContent.ts` | | 2 | Is the baked hero cropped around the focus point too? | Yes: object-position from the estimates, so baked and live look the same | Pass `focus: null` for the baked slides to get plain centre crop | `heroContent.ts` |
| 3 | Button target `#anchor` and https: plain link, `/path`: router link | As said | Make all plain links | `web/src/components/Hero/HeroButton.tsx` | | 3 | Button target `#anchor` and https: plain link, `/path`: router link | As said | Make all plain links | `web/src/components/Hero/HeroButton.tsx` |
@@ -18,6 +18,8 @@ Written while Bryan was away; he decides later. Each point: question, assumption
| 12 | Planning (from/to dates) and a hero-wide on/off switch | Deliberately not built: the hero is always there, a hero without usable slides keeps the baked one | Add in the CMS; the site already handles a 204 and an empty hero | CMS (module), `useHero.ts` | | 12 | Planning (from/to dates) and a hero-wide on/off switch | Deliberately not built: the hero is always there, a hero without usable slides keeps the baked one | Add in the CMS; the site already handles a 204 and an empty hero | CMS (module), `useHero.ts` |
| 13 | Content of the ASF test seed | The 8 existing photos with focus estimates (#1), texts like the baked ones | Edit in the CMS admin; update `heroContent.ts` if the baked fallback should match | `web/contract/host-injection/hero/seed.json` | | 13 | Content of the ASF test seed | The 8 existing photos with focus estimates (#1), texts like the baked ones | Edit in the CMS admin; update `heroContent.ts` if the baked fallback should match | `web/contract/host-injection/hero/seed.json` |
| 14 | Baked hero after a CMS change | The baked hero is only a fallback and is not rebuilt from the CMS any more (no nightly build) | Re-bake by hand in `heroContent.ts` when the real hero changes for good | `heroContent.ts` | | 14 | Baked hero after a CMS change | The baked hero is only a fallback and is not rebuilt from the CMS any more (no nightly build) | Re-bake by hand in `heroContent.ts` when the real hero changes for good | `heroContent.ts` |
| 15 | Pause on mouse hover | Removed on purpose (Bryan, 2026-11-17): a full-screen hero almost always has the pointer over it. Kept: the explicit pause button (WCAG 2.2.2), no autoplay with `prefers-reduced-motion`, pause when the tab is hidden, and pause while keyboard focus is on the controls (a deliberate action; a click on an arrow does not pause). Touch and swipe do not pause either: a swipe restarts the progress bar of the new slide | Add hover back: `onPointerEnter`/`onPointerLeave` in `useHeroSlider.ts` | `web/src/components/Hero/useHeroSlider.ts` |
| 16 | Slow zoom on the first photo (supersedes #11 in part; Bryan chose the full slider render, 2026-11-17) | The first photo zooms like the others, without replacing the plain HTML: the plain HTML is painted at scale 1.06 (CSS `.cms-hero-image`), the slider sets `data-zoom` after hydration and it zooms out to 1 over 9 s. Same first frame before and after hydration, so no CLS, and the LCP does not wait for hydration (replacing the nodes made the LCP 5.3 s in the first design). Reduced motion: no scale at all | Replace the nodes at hydration (one component); measure LCP first | `theme.ts`, `Hero.tsx` |
## What Bryan has to check later ## What Bryan has to check later
+18
View File
@@ -135,6 +135,24 @@ describe('Hero', () => {
}); });
}); });
it('laat de eerste foto inzoomen zolang hij de actieve is', async () => {
const { container } = await renderWithProviders(
<Hero content={heroContent} socials={siteContent.socials} />,
);
const picture = container.querySelector('.cms-hero-picture')!;
expect(picture).toHaveAttribute('data-zoom');
expect(picture).not.toHaveAttribute('aria-hidden');
await userEvent.click(
screen.getByRole('button', { name: 'Volgende foto' }),
);
expect(picture).not.toHaveAttribute('data-zoom');
expect(picture).toHaveAttribute('aria-hidden', 'true');
await userEvent.click(
screen.getByRole('button', { name: 'Vorige foto' }),
);
expect(picture).toHaveAttribute('data-zoom');
});
it('heeft pijlen met een toegankelijke naam', async () => { it('heeft pijlen met een toegankelijke naam', async () => {
await renderWithProviders( await renderWithProviders(
<Hero content={heroContent} socials={siteContent.socials} />, <Hero content={heroContent} socials={siteContent.socials} />,
+9 -3
View File
@@ -164,11 +164,17 @@ function HeroFrame({ content, socials, regionHtml, hydrated }: FrameProps) {
}, [firstPainted]); }, [firstPainted]);
// The first photo is hidden from screen readers while another one is on // The first photo is hidden from screen readers while another one is on
// top of it // top of it, and it zooms (data-zoom, see .cms-hero-image) while it is the
// active one
useEffect(() => { useEffect(() => {
const picture = section.current?.querySelector('.cms-hero-picture'); const picture = section.current?.querySelector('.cms-hero-picture');
if (active === 0) picture?.removeAttribute('aria-hidden'); if (active === 0) {
else picture?.setAttribute('aria-hidden', 'true'); picture?.removeAttribute('aria-hidden');
picture?.setAttribute('data-zoom', '');
} else {
picture?.setAttribute('aria-hidden', 'true');
picture?.removeAttribute('data-zoom');
}
}, [active]); }, [active]);
const loaded = firstPainted ? slidesToLoad(active, shown.length) : [active]; const loaded = firstPainted ? slidesToLoad(active, shown.length) : [active];
+14
View File
@@ -55,6 +55,20 @@ const config = defineConfig({
width: '100%', width: '100%',
height: '100%', height: '100%',
objectFit: 'cover', objectFit: 'cover',
// Same slow zoom as the other photos of the slider: the plain HTML
// is painted at 1.06 and the slider (after hydration) sets
// data-zoom on the picture, which zooms out to 1 over 9 s. The
// photo itself is never replaced, so the LCP does not wait for
// hydration; the first frame is the same before and after it.
transform: 'scale(1.06)',
transition: 'transform 9s linear',
'@media (prefers-reduced-motion: reduce)': {
transform: 'none',
transition: 'none',
},
},
'.cms-hero-picture[data-zoom] .cms-hero-image': {
transform: 'scale(1)',
}, },
'.cms-hero-title': { '.cms-hero-title': {
position: 'relative', position: 'relative',