Packages and banners from the CMS, host injection, translation files and the contact form #19

Merged
Sluijsens merged 44 commits from feature/asf-packages-cms into master 2026-11-16 14:17:14 +01:00
2 changed files with 11 additions and 4 deletions
Showing only changes of commit ed4a19d146 - Show all commits
+1 -1
View File
@@ -15,4 +15,4 @@
| Feature | cms-api-foundation | ✅ Complete (merged PR #17, 2026-11-10; follow-ups: ASF production, contact feature) | feature/cms-api-foundation (worktree ../AndreaSlopFotografie-cms-api-foundation) | Cross-repo: feature briefs for the SlpModularCms repo (new Api.AndreaSlopFotografie client, per-site theming, per-site module set); in this repo only docs, later web integration (CMS serves the site) | 2026-11-05 |
| Feature | contact-form-cms | 🔵 Inception | feature/contact-form-cms (worktree ../AndreaSlopFotografie-contact-form) | web/src/components/ContactForm, ContactFormGate, web/src/contact (submitContactForm), new web/src/cms-client (copied headless package), web/config/securityHeaders.ts, content/siteContent contactForm switch | 2026-11-10 |
| Feature | asf-packages-cms | 🔵 Construction | feature/asf-packages-cms (worktree ../AndreaSlopFotografie-packages, based on feature/contact-form-cms) | web/config (offerings, fetchOfferings), web/src/content (packages, snapshot, types), Pricing + PriceBanner + PriceTopBar (two banners, centred card rows), PackagesProvider (live refresh), CI build-test job and nightly test build, docs/ (CMS integration, deploy and CI, go-live checklist) | 2026-11-12 |
| Feature | asf-cms-host-injection | 📝 Plan proposal, awaiting Bryan ([plan.md](features/asf-cms-host-injection/plan.md)); starts after the current merges | (none yet) | web (PackagesProvider, build markers, neutral HTML), preview server stand-in injector, e2e/contract tests; host side in the SlpModularCms repo | 2026-11-15 |
| Feature | asf-cms-host-injection | 📝 Plan, approach agreed, waiting for the start signal ([plan.md](features/asf-cms-host-injection/plan.md)); no build or deploy until SLS-Main says so; starts after the current merges | (none yet) | web (PackagesProvider, build markers, neutral HTML), preview server stand-in injector, e2e/contract tests; host side in the SlpModularCms repo | 2026-11-15 |
@@ -1,6 +1,13 @@
# Plan (proposal, not approved): the CMS host injects CMS data into the prerendered ASF pages
# Plan (approach agreed, waiting for the start): the CMS host injects CMS data into the prerendered ASF pages
Status: PROPOSAL for Bryan. Nothing is built. It starts as a separate feature after the current merges (contact-form-cms, then asf-packages-cms), not through them. To be agreed with SLP Modular CMS - SMC - Main, who owns the host side.
Status: plan, agreed on the approach, waiting for the start signal (2026-11-15). Nothing is built, and nothing may be built or deployed for this until SLP Software - SLS - Main gives the signal: Bryan first wants to read this plan himself and to find out whether .NET 10 can run on the hosting package.
Decisions of Bryan (via SLS-Main, 2026-11-15):
- (a) A short change of look of the cards on first paint (neutral HTML first, then the styled cards after hydration) is ACCEPTED.
- (b) The host MAY write the list HTML (C# template; this repo delivers the spec and the golden files): YES.
It starts as a separate feature after the current merges (contact-form-cms, then asf-packages-cms), not through them. To be built together with SLP Modular CMS - SMC - Main, who owns the host side.
## Why
@@ -81,4 +88,4 @@ The host (CMS repo) finds all markers in one pass. A page with no marker and wit
## Open questions
- For SMC: the marker format SLP uses today; how the injector reads and edits JSON and `ld+json`; behaviour when data or a marker is missing (must fail open: serve the baked page); caching and ETag; whether `AuthoredBaseUrl` can also run on the prerendered-pages host.
- For Bryan: accept a brief look change of the cards on first paint (neutral HTML, then styled)? The alternative is one set of cards styled by plain CSS and owned by the host, with no React in those regions; that makes first paint exact but gives up the router links and the Reveal animation of the cards, and puts every design change in two places.
- For Bryan: (answered, see the decisions at the top) accept a brief look change of the cards on first paint, and let the host write the list HTML? Both yes. The alternative that was not chosen: one set of cards styled by plain CSS and owned by the host, with no React in those regions.