Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
ffba8c341c |
@@ -76,5 +76,3 @@ Removed: `PI_MAIN_*` (the SSH password login; the old secrets are deleted by Bry
|
||||
## FTPS to production
|
||||
|
||||
The production package offers FTP over TLS. `deploy/upload-production.sh` forces explicit FTPS (`AUTH TLS`): `ftp:ssl-force yes`, `ftp:ssl-protect-data yes` and `ftp:ssl-protect-list yes`, so login, listings and files are encrypted, and the session refuses to fall back to plain FTP. The certificate of the server is checked (`ssl:verify-certificate yes`); if the host turns out to have a non-public certificate, record what is needed (the CA file) and ask Bryan before relaxing anything. The mode is passive. Use a separate FTP account with rights only on the folder of the prerendered pages and a unique strong password that only exists as the secret `PROD_HOST_PASSWORD`. The script uploads in three rounds (everything except HTML, then all HTML, then cleaning up old files) into the prerendered-pages folder of the CMS host (`PROD_DEPLOY_PATH`, the exact folder is still open, see `aidlc-docs/features/asf-production-iis/plan.md`, A2). It does not put a `web.config` there and deletes nothing outside that folder; the host and its `web.config` come from the CMS pipeline. `PROD_HOST_PORT` is optional (default 21). The tests (`e2e/deployScripts.e2e.ts`) check the lftp settings with a fake lftp and the upload with a local `file:` target; the real FTPS connection is tested by Bryan with the `PROD_HOST_*` secrets.
|
||||
|
||||
**Known issue (2026-11-19): the certificate chain of the hoster has expired.** The FTPS login fails on the certificate check ("certificate chain uses expired certificate", seen in the CMS run 911). For the first rollout Bryan decided to upload once without certificate verification, on the release branch only (`release/asf-prod-2026-11-19`: `set ssl:verify-certificate no`, with the comment "EENMALIG"). TLS itself stays forced (`ssl-force`, `AUTH TLS`, protected data and listings), but the identity of the server is then not checked. On `master` the check stays on (`yes`). After the rollout: have the hoster renew the chain and put the check back on the release branch (or drop that branch); every later production upload runs with verification.
|
||||
|
||||
@@ -54,9 +54,12 @@ wants() { [ "$pass" = all ] || [ "$pass" = "$1" ]; }
|
||||
# Geen back-ups: lftp zet standaard een kopie met een tijdstempel
|
||||
# (web.config~20261101221045~) naast elk bestand dat het overschrijft. Op de
|
||||
# host zou elke deploy er een achterlaten, bereikbaar voor wie de naam raadt.
|
||||
# EENMALIG: certificaatketen hoster verlopen, terugdraaien (besluit Bryan,
|
||||
# 2026-11-19: voor de eerste uitrol zonder certificaatcontrole; ssl-force, AUTH
|
||||
# TLS en protect-data blijven aan). Terug naar 'set ssl:verify-certificate yes'.
|
||||
# TLS: explicit FTPS afdwingen (de sessie weigert inloggen zonder TLS, ook de
|
||||
# datakanalen en de lijsten zijn versleuteld) en het certificaat controleren.
|
||||
tls="set ftp:ssl-allow yes; set ftp:ssl-auth TLS; set ftp:ssl-force yes; set ftp:ssl-protect-data yes; set ftp:ssl-protect-list yes; set ssl:verify-certificate yes;"
|
||||
tls="set ftp:ssl-allow yes; set ftp:ssl-auth TLS; set ftp:ssl-force yes; set ftp:ssl-protect-data yes; set ftp:ssl-protect-list yes; set ssl:verify-certificate no;"
|
||||
settings="$tls set ftp:passive-mode on; set net:max-retries 3; set xfer:make-backup no;"
|
||||
|
||||
# Elke opdracht krijgt een eigen lftp-sessie, zodat het script bij een mislukte
|
||||
|
||||
@@ -699,10 +699,10 @@ printf '%s\\n' "$2" >> '${slash(log)}'
|
||||
expect(commands).toContain('set ftp:ssl-force yes;');
|
||||
expect(commands).toContain('set ftp:ssl-protect-data yes;');
|
||||
expect(commands).toContain('set ftp:ssl-protect-list yes;');
|
||||
expect(commands).toContain('set ssl:verify-certificate yes;');
|
||||
// EENMALIG op de release-branch: zonder certificaatcontrole (terugdraaien)
|
||||
expect(commands).toContain('set ssl:verify-certificate no;');
|
||||
expect(commands).toContain('set ftp:passive-mode on;');
|
||||
expect(commands).not.toContain('ssl-allow no');
|
||||
expect(commands).not.toContain('verify-certificate no');
|
||||
}
|
||||
});
|
||||
|
||||
|
||||
Reference in New Issue
Block a user