Adds the URL rules to the preview server, IIS config and deploy
The preview server and web.config now follow the same URLs as nginx, without the SPA fallback. Lighthouse exceptions need a recorded reason and the 404 page is audited through an opt-in route. The deploy checks the build first and the served result afterwards. The IIS rules stay unverified until a host exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -15,12 +15,22 @@ import {
|
||||
existsIn,
|
||||
pageName,
|
||||
} from '../src/test/requestArbitraries';
|
||||
import {
|
||||
hostilePath,
|
||||
knownPage,
|
||||
pageVariant,
|
||||
queryString,
|
||||
unknownPath,
|
||||
} from '../src/test/urlArbitraries';
|
||||
import { canonicalRedirect, pagePaths } from './canonicalUrls';
|
||||
import { pageFile } from './pageFiles';
|
||||
import { securityHeaders } from './securityHeaders';
|
||||
import {
|
||||
acceptsGzip,
|
||||
contentTypeOf,
|
||||
resolveRequest,
|
||||
startPreviewServer,
|
||||
type ResolvedRequest,
|
||||
} from './previewServer';
|
||||
|
||||
const NOT_FOUND = { file: '404.html', status: 404 };
|
||||
@@ -30,10 +40,30 @@ const FILES = new Set([
|
||||
'over-mij.html',
|
||||
'soorten-fotoshoots.html',
|
||||
'soorten-fotoshoots/newborn.html',
|
||||
'assets/a.js',
|
||||
'assets/app.js',
|
||||
'favicon.png',
|
||||
'robots.txt',
|
||||
'sitemap.xml',
|
||||
]);
|
||||
const resolveIn = (path: string) => resolveRequest(path, existsIn(FILES));
|
||||
const resolveIn = (path: string, options?: { auditRoute?: boolean }) =>
|
||||
resolveRequest(path, existsIn(FILES), options);
|
||||
const PAGE_FILES = new Set(pagePaths.map(pageFile));
|
||||
const redirectTo = (redirect: string): ResolvedRequest => ({
|
||||
redirect,
|
||||
status: 301,
|
||||
});
|
||||
|
||||
// Volgt redirects tot een bestand of een 404 en telt de stappen
|
||||
function follow(path: string, files: ReadonlySet<string> = FILES) {
|
||||
let current = path;
|
||||
for (let hops = 0; hops <= 5; hops++) {
|
||||
const result = resolveRequest(current, existsIn(files));
|
||||
if (!('redirect' in result)) return { result, hops };
|
||||
current = result.redirect;
|
||||
}
|
||||
throw new Error(`geen einde aan de redirects vanaf ${path}`);
|
||||
}
|
||||
|
||||
describe('resolveRequest', () => {
|
||||
it('geeft index.html voor /', () => {
|
||||
@@ -65,10 +95,7 @@ describe('resolveRequest', () => {
|
||||
file: 'favicon.png',
|
||||
status: 200,
|
||||
});
|
||||
expect(resolveIn('/over-mij.html')).toEqual({
|
||||
file: 'over-mij.html',
|
||||
status: 200,
|
||||
});
|
||||
expect(resolveIn('/over-mij.html')).toEqual(redirectTo('/over-mij'));
|
||||
expect(resolveIn('/assets/weg.js')).toEqual(NOT_FOUND);
|
||||
});
|
||||
|
||||
@@ -129,50 +156,156 @@ describe('resolveRequest', () => {
|
||||
it('weigert een pad zonder voorste slash en een Windows-stationsletter', () => {
|
||||
expect(resolveIn('')).toEqual(NOT_FOUND);
|
||||
expect(resolveIn('index.html')).toEqual(NOT_FOUND);
|
||||
const drive = resolveRequest('/c:/windows/x.ini', () => true);
|
||||
expect(win32.isAbsolute(drive.file)).toBe(false);
|
||||
expect(drive).toEqual(NOT_FOUND);
|
||||
expect(resolveRequest('/c:/windows/x.ini', () => true)).toEqual(
|
||||
NOT_FOUND,
|
||||
);
|
||||
});
|
||||
|
||||
it('geeft 404 voor een dubbele slash', () => {
|
||||
expect(resolveIn('//over-mij')).toEqual(NOT_FOUND);
|
||||
expect(resolveIn('/assets//app.js')).toEqual(NOT_FOUND);
|
||||
expect(resolveIn('/over-mij//x')).toEqual(NOT_FOUND);
|
||||
});
|
||||
|
||||
describe('tussenregels uit BR-SRV-07', () => {
|
||||
it('geeft 404 voor een slash aan het eind, zonder redirect', () => {
|
||||
expect(resolveIn('/over-mij/')).toEqual(NOT_FOUND);
|
||||
expect(resolveIn('/soorten-fotoshoots/')).toEqual(NOT_FOUND);
|
||||
expect(resolveIn('/assets/')).toEqual(NOT_FOUND);
|
||||
it('geeft 404 voor een doel dat met // of /\\ zou beginnen (BR-HST-06)', () => {
|
||||
for (const path of [
|
||||
'//evil.example/',
|
||||
'//evil.example//',
|
||||
'/%5Cevil.example/',
|
||||
'/\\evil.example/',
|
||||
'/a//b/',
|
||||
'/over-mij\r\nx/',
|
||||
]) {
|
||||
expect(resolveIn(path), path).toEqual(NOT_FOUND);
|
||||
}
|
||||
});
|
||||
|
||||
describe('regels uit BR-HST-03 tot 05', () => {
|
||||
it('stuurt een slash aan het eind met één 301 naar het pad zonder', () => {
|
||||
expect(resolveIn('/over-mij/')).toEqual(redirectTo('/over-mij'));
|
||||
expect(resolveIn('/over-mij///')).toEqual(redirectTo('/over-mij'));
|
||||
expect(resolveIn('/soorten-fotoshoots/')).toEqual(
|
||||
redirectTo('/soorten-fotoshoots'),
|
||||
);
|
||||
expect(resolveIn('/onbekend/')).toEqual(redirectTo('/onbekend'));
|
||||
expect(resolveIn('/assets/')).toEqual(redirectTo('/assets'));
|
||||
});
|
||||
|
||||
it('antwoordt op /404 met 404.html en status 404, niet 200', () => {
|
||||
it('codeert een doel dat niet uit de paginalijst komt opnieuw', () => {
|
||||
expect(resolveIn('/een%20pad/')).toEqual(redirectTo('/een%20pad'));
|
||||
expect(resolveIn('/a%3Fb/')).toEqual(redirectTo('/a%3Fb'));
|
||||
expect(resolveIn('/caf%C3%A9/')).toEqual(redirectTo('/caf%C3%A9'));
|
||||
});
|
||||
|
||||
it('geeft /404 en /404.html status 404, ook als 404.html bestaat', () => {
|
||||
expect(resolveIn('/404')).toEqual(NOT_FOUND);
|
||||
});
|
||||
|
||||
it('serveert /404.html als bestand met 200 (BR-SRV-04)', () => {
|
||||
// Lighthouse weigert een 404-status en valt hierop terug
|
||||
expect(resolveIn('/404.html')).toEqual({
|
||||
file: '404.html',
|
||||
status: 200,
|
||||
});
|
||||
expect(resolveIn('/404.html')).toEqual(NOT_FOUND);
|
||||
expect(resolveRequest('/404.html', () => false)).toEqual(NOT_FOUND);
|
||||
});
|
||||
|
||||
it('geeft /index en /index.html het bestand van /', () => {
|
||||
expect(resolveIn('/index')).toEqual({
|
||||
file: 'index.html',
|
||||
it('stuurt /index en /index.html met een 301 naar /', () => {
|
||||
expect(resolveIn('/index')).toEqual(redirectTo('/'));
|
||||
expect(resolveIn('/index.html')).toEqual(redirectTo('/'));
|
||||
expect(resolveIn('/index/')).toEqual(redirectTo('/'));
|
||||
});
|
||||
|
||||
it('stuurt hoofdletters en .html van een bekende pagina naar het kanonieke pad', () => {
|
||||
expect(resolveIn('/over-mij.html')).toEqual(
|
||||
redirectTo('/over-mij'),
|
||||
);
|
||||
expect(resolveIn('/Over-Mij')).toEqual(redirectTo('/over-mij'));
|
||||
expect(resolveIn('/OVER-MIJ.HTML')).toEqual(
|
||||
redirectTo('/over-mij'),
|
||||
);
|
||||
expect(resolveIn('/Over-Mij/')).toEqual(redirectTo('/over-mij'));
|
||||
expect(resolveIn('/soorten-fotoshoots/newborn.html')).toEqual(
|
||||
redirectTo('/soorten-fotoshoots/newborn'),
|
||||
);
|
||||
});
|
||||
|
||||
it('stuurt een onbekend pad niet door op hoofdletters', () => {
|
||||
expect(resolveIn('/Onbekend')).toEqual(NOT_FOUND);
|
||||
expect(resolveIn('/x.html')).toEqual(NOT_FOUND);
|
||||
});
|
||||
|
||||
it('laat / en de kanonieke paden zonder redirect', () => {
|
||||
for (const path of ['/', '/over-mij', '/soorten-fotoshoots']) {
|
||||
expect(resolveIn(path)).not.toHaveProperty('redirect');
|
||||
}
|
||||
});
|
||||
|
||||
it('stuurt een map naast een paginabestand nooit door of toont haar (BR-HST-07)', () => {
|
||||
// soorten-fotoshoots.html staat naast de map soorten-fotoshoots/
|
||||
expect(resolveIn('/soorten-fotoshoots')).toEqual({
|
||||
file: 'soorten-fotoshoots.html',
|
||||
status: 200,
|
||||
});
|
||||
expect(resolveIn('/index.html')).toEqual({
|
||||
file: 'index.html',
|
||||
expect(resolveIn('/assets')).toEqual(NOT_FOUND);
|
||||
});
|
||||
});
|
||||
|
||||
describe('tabel uit BR-HST (resultaten per verzoek)', () => {
|
||||
const ok = (file: string): ResolvedRequest => ({ file, status: 200 });
|
||||
const notFound = NOT_FOUND as ResolvedRequest;
|
||||
const rows: [string, ResolvedRequest][] = [
|
||||
['/', ok('index.html')],
|
||||
['/over-mij', ok('over-mij.html')],
|
||||
['/soorten-fotoshoots', ok('soorten-fotoshoots.html')],
|
||||
[
|
||||
'/soorten-fotoshoots/newborn',
|
||||
ok('soorten-fotoshoots/newborn.html'),
|
||||
],
|
||||
['/over-mij/', redirectTo('/over-mij')],
|
||||
['/over-mij///', redirectTo('/over-mij')],
|
||||
['/soorten-fotoshoots/', redirectTo('/soorten-fotoshoots')],
|
||||
['/over-mij.html', redirectTo('/over-mij')],
|
||||
[
|
||||
'/soorten-fotoshoots/newborn.html',
|
||||
redirectTo('/soorten-fotoshoots/newborn'),
|
||||
],
|
||||
['/index', redirectTo('/')],
|
||||
['/index.html', redirectTo('/')],
|
||||
['/index/', redirectTo('/')],
|
||||
['/Over-Mij', redirectTo('/over-mij')],
|
||||
['/OVER-MIJ.HTML', redirectTo('/over-mij')],
|
||||
['/Over-Mij/', redirectTo('/over-mij')],
|
||||
['/404', notFound],
|
||||
['/404.html', notFound],
|
||||
['/onbekend', notFound],
|
||||
['/Onbekend', notFound],
|
||||
['/x.html', notFound],
|
||||
['/assets/missing.js', notFound],
|
||||
['/onbekend/', redirectTo('/onbekend')],
|
||||
['/assets', notFound],
|
||||
['/assets/', redirectTo('/assets')],
|
||||
['/assets/a.js', ok('assets/a.js')],
|
||||
['/robots.txt', ok('robots.txt')],
|
||||
['/sitemap.xml', ok('sitemap.xml')],
|
||||
['/favicon.png', ok('favicon.png')],
|
||||
];
|
||||
|
||||
it.each(rows)('%s', (path, expected) => {
|
||||
expect(resolveIn(path)).toEqual(expected);
|
||||
});
|
||||
});
|
||||
|
||||
describe('opt-in route /__audit/404 (BR-HST-22)', () => {
|
||||
it('geeft zonder de optie 404 en met de optie 200 voor de 404-pagina', () => {
|
||||
expect(resolveIn('/__audit/404')).toEqual(NOT_FOUND);
|
||||
expect(resolveIn('/__audit/404', { auditRoute: false })).toEqual(
|
||||
NOT_FOUND,
|
||||
);
|
||||
expect(resolveIn('/__audit/404', { auditRoute: true })).toEqual({
|
||||
file: '404.html',
|
||||
status: 200,
|
||||
});
|
||||
});
|
||||
|
||||
it('geeft nooit een redirect terug', () => {
|
||||
for (const path of ['/over-mij/', '/404', '/index', '/']) {
|
||||
expect(resolveIn(path)).not.toHaveProperty('redirect');
|
||||
it('laat /404.html en /404 een echte 404 met de optie aan', () => {
|
||||
for (const path of ['/404', '/404.html']) {
|
||||
expect(resolveIn(path, { auditRoute: true }), path).toEqual(
|
||||
NOT_FOUND,
|
||||
);
|
||||
}
|
||||
});
|
||||
});
|
||||
@@ -193,10 +326,12 @@ describe('resolveRequest (eigenschappen)', () => {
|
||||
existingFiles,
|
||||
fc.boolean(),
|
||||
(path, files, everythingExists) => {
|
||||
const { file, status } = resolveRequest(
|
||||
const result = resolveRequest(
|
||||
path,
|
||||
everythingExists ? () => true : existsIn(files),
|
||||
);
|
||||
if ('redirect' in result) return;
|
||||
const { file, status } = result;
|
||||
expect(file.split('/')).not.toContain('..');
|
||||
expect(file.startsWith('/')).toBe(false);
|
||||
expect(posix.isAbsolute(file)).toBe(false);
|
||||
@@ -219,13 +354,18 @@ describe('resolveRequest (eigenschappen)', () => {
|
||||
dottedFileName,
|
||||
(files, name, dirs, dotted) => {
|
||||
const exists = existsIn(files);
|
||||
// Het model: wat bestaat is 200, de rest 404. Alleen het
|
||||
// pagina-pad /404 is 404 ook al bestaat 404.html; het
|
||||
// bestandsverzoek /404.html is 200.
|
||||
const expected = (file: string, isPage = false) =>
|
||||
files.has(file) && !(isPage && file === '404.html')
|
||||
// Het model: wat bestaat is 200, de rest 404. /404 en
|
||||
// /404.html zijn 404 ook al bestaat 404.html, en een
|
||||
// afwijkende vorm van een bekende pagina krijgt een 301.
|
||||
const expected = (path: string, file: string) => {
|
||||
const canonical = canonicalRedirect(path);
|
||||
if (canonical !== undefined) {
|
||||
return { redirect: canonical, status: 301 };
|
||||
}
|
||||
return files.has(file) && file !== '404.html'
|
||||
? { file, status: 200 }
|
||||
: NOT_FOUND;
|
||||
};
|
||||
|
||||
expect(resolveRequest('/', exists)).toEqual({
|
||||
file: 'index.html',
|
||||
@@ -234,24 +374,108 @@ describe('resolveRequest (eigenschappen)', () => {
|
||||
|
||||
const page = [...dirs, name].join('/');
|
||||
expect(resolveRequest(`/${page}`, exists)).toEqual(
|
||||
expected(`${page}.html`, true),
|
||||
expected(`/${page}`, `${page}.html`),
|
||||
);
|
||||
|
||||
const asset = [...dirs, dotted].join('/');
|
||||
expect(resolveRequest(`/${asset}`, exists)).toEqual(
|
||||
expected(asset),
|
||||
expected(`/${asset}`, asset),
|
||||
);
|
||||
// Een bestand dat echt bestaat wordt altijd gevonden
|
||||
// Een bestand dat echt bestaat wordt gevonden, behalve
|
||||
// 404.html en de paginabestanden die naar hun pad gaan
|
||||
for (const file of files) {
|
||||
expect(resolveRequest(`/${file}`, exists)).toEqual({
|
||||
file,
|
||||
status: 200,
|
||||
});
|
||||
expect(resolveRequest(`/${file}`, exists)).toEqual(
|
||||
expected(`/${file}`, file),
|
||||
);
|
||||
}
|
||||
},
|
||||
),
|
||||
);
|
||||
});
|
||||
|
||||
it('is totaal en veilig voor vijandige paden en paginavarianten (invariant, P-HST-01)', () => {
|
||||
fc.assert(
|
||||
fc.property(
|
||||
fc.oneof(hostilePath, pageVariant, unknownPath, anyRequestPath),
|
||||
fc.boolean(),
|
||||
fc.boolean(),
|
||||
(path, auditRoute, everythingExists) => {
|
||||
const result = resolveRequest(
|
||||
path,
|
||||
everythingExists ? () => true : existsIn(FILES),
|
||||
{ auditRoute },
|
||||
);
|
||||
expect([200, 301, 404]).toContain(result.status);
|
||||
if ('redirect' in result) {
|
||||
expect(result.redirect.startsWith('/')).toBe(true);
|
||||
expect(result.redirect.startsWith('//')).toBe(false);
|
||||
expect(result.redirect.startsWith('/\\')).toBe(false);
|
||||
expect(result.redirect).not.toMatch(
|
||||
// eslint-disable-next-line no-control-regex
|
||||
/[\u0000-\u001f\u007f\\]/,
|
||||
);
|
||||
} else {
|
||||
expect(result.file.split('/')).not.toContain('..');
|
||||
expect(result.file.startsWith('/')).toBe(false);
|
||||
expect(win32.isAbsolute(result.file)).toBe(false);
|
||||
expect(posix.isAbsolute(result.file)).toBe(false);
|
||||
}
|
||||
},
|
||||
),
|
||||
);
|
||||
});
|
||||
|
||||
it('is totaal en veilig voor een vijandig pad, bijvoorbeeld // en /\\ (voorbeeld, P-HST-01)', () => {
|
||||
for (const path of ['//evil.example/', '/%5Cevil.example/', '//']) {
|
||||
const result = resolveIn(path);
|
||||
if ('redirect' in result) {
|
||||
expect(result.redirect.startsWith('//')).toBe(false);
|
||||
}
|
||||
}
|
||||
expect(resolveIn('/%5Cevil.example/')).toEqual(NOT_FOUND);
|
||||
});
|
||||
|
||||
it('brengt elke variant van een bekende pagina in hoogstens 2 stappen bij de pagina (idempotent, P-HST-02, 03)', () => {
|
||||
fc.assert(
|
||||
fc.property(pageVariant, (path) => {
|
||||
const { result, hops } = follow(path, PAGE_FILES);
|
||||
expect(hops).toBeLessThanOrEqual(2);
|
||||
const canonical = canonicalRedirect(path);
|
||||
const target = canonical ?? path;
|
||||
const page = target === '/' ? 'index' : target.slice(1);
|
||||
expect(result).toEqual({ file: `${page}.html`, status: 200 });
|
||||
// Het kanonieke pad is een dekpunt: geen redirect meer
|
||||
expect(
|
||||
resolveRequest(target, existsIn(PAGE_FILES)),
|
||||
).not.toHaveProperty('redirect');
|
||||
}),
|
||||
);
|
||||
});
|
||||
|
||||
it('stuurt elke bekende pagina via een variant naar zichzelf (voorbeeld, P-HST-02)', () => {
|
||||
expect(follow('/Soorten-Fotoshoots/Newborn.html//')).toEqual({
|
||||
result: {
|
||||
file: 'soorten-fotoshoots/newborn.html',
|
||||
status: 200,
|
||||
},
|
||||
hops: 1,
|
||||
});
|
||||
});
|
||||
|
||||
it('geeft 404 voor onbekende paden, 404 voor /404 en /404.html, en nooit een redirect voor / (invariant, P-HST-06)', () => {
|
||||
fc.assert(
|
||||
fc.property(unknownPath, knownPage, (path, page) => {
|
||||
expect(resolveIn(path)).toEqual(NOT_FOUND);
|
||||
expect(resolveIn('/404')).toEqual(NOT_FOUND);
|
||||
expect(resolveIn('/404.html')).toEqual(NOT_FOUND);
|
||||
expect(resolveIn('/')).toEqual({
|
||||
file: 'index.html',
|
||||
status: 200,
|
||||
});
|
||||
expect(resolveIn(page)).not.toHaveProperty('redirect');
|
||||
}),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('contentTypeOf', () => {
|
||||
@@ -329,6 +553,12 @@ function siteDir(): string {
|
||||
writeFileSync(join(clientDir, 'index.html'), '<p>home</p>');
|
||||
writeFileSync(join(clientDir, 'over-mij.html'), '<p>over mij</p>');
|
||||
writeFileSync(join(clientDir, '404.html'), '<p>niet gevonden</p>');
|
||||
writeFileSync(join(clientDir, 'soorten-fotoshoots.html'), '<p>soorten</p>');
|
||||
mkdirSync(join(clientDir, 'soorten-fotoshoots'));
|
||||
writeFileSync(
|
||||
join(clientDir, 'soorten-fotoshoots', 'newborn.html'),
|
||||
'<p>newborn</p>',
|
||||
);
|
||||
writeFileSync(join(clientDir, 'assets', 'app.js'), 'boot()');
|
||||
writeFileSync(join(clientDir, 'assets', 'groot.js'), GROOT_SCRIPT);
|
||||
writeFileSync(join(clientDir, 'logo.png'), BINARY);
|
||||
@@ -338,8 +568,11 @@ function siteDir(): string {
|
||||
return clientDir;
|
||||
}
|
||||
|
||||
async function serve(clientDir: string): Promise<number> {
|
||||
const server = await startPreviewServer(clientDir, 0);
|
||||
async function serve(
|
||||
clientDir: string,
|
||||
options?: { auditRoute?: boolean },
|
||||
): Promise<number> {
|
||||
const server = await startPreviewServer(clientDir, 0, options);
|
||||
servers.push(server);
|
||||
const address = server.address();
|
||||
if (typeof address !== 'object' || !address) throw new Error('geen poort');
|
||||
@@ -388,12 +621,103 @@ describe('startPreviewServer', () => {
|
||||
expect(answer.headers['content-type']).toBe('text/html; charset=utf-8');
|
||||
});
|
||||
|
||||
it('antwoordt op /404 met status 404', async () => {
|
||||
it('antwoordt op /404 en /404.html met de 404-pagina en status 404', async () => {
|
||||
const port = await serve(siteDir());
|
||||
const expected = securityHeaders('production');
|
||||
for (const path of ['/404', '/404.html']) {
|
||||
const answer = await ask(port, path);
|
||||
expect(answer.status, path).toBe(404);
|
||||
expect(answer.body, path).toBe('<p>niet gevonden</p>');
|
||||
expect(answer.headers['content-type'], path).toBe(
|
||||
'text/html; charset=utf-8',
|
||||
);
|
||||
for (const [name, value] of Object.entries(expected)) {
|
||||
expect(answer.headers[name.toLowerCase()], path).toBe(value);
|
||||
}
|
||||
}
|
||||
expect((await ask(port, '/404.html', 'HEAD')).status).toBe(404);
|
||||
});
|
||||
|
||||
it('heeft /__audit/404 alleen met de optie (BR-HST-22)', async () => {
|
||||
const without = await serve(siteDir());
|
||||
expect((await ask(without, '/__audit/404')).status).toBe(404);
|
||||
|
||||
const port = await serve(siteDir(), { auditRoute: true });
|
||||
const audit = await ask(port, '/__audit/404');
|
||||
expect(audit.status).toBe(200);
|
||||
expect(audit.body).toBe('<p>niet gevonden</p>');
|
||||
expect(audit.headers['content-type']).toBe('text/html; charset=utf-8');
|
||||
expect((await ask(port, '/404.html')).status).toBe(404);
|
||||
expect((await ask(port, '/404')).status).toBe(404);
|
||||
const file = await ask(port, '/404.html');
|
||||
expect(file.status).toBe(200);
|
||||
expect(file.body).toBe('<p>niet gevonden</p>');
|
||||
expect((await ask(port, '/andere')).status).toBe(404);
|
||||
});
|
||||
|
||||
it('stuurt een 301 met een relatieve Location, de query en de securityheaders, zonder inhoud', async () => {
|
||||
const port = await serve(siteDir());
|
||||
const expected = securityHeaders('production');
|
||||
for (const method of ['GET', 'HEAD']) {
|
||||
const answer = await ask(port, '/Over-Mij/?x=1&y=%20', method);
|
||||
expect(answer.status, method).toBe(301);
|
||||
expect(answer.headers.location, method).toBe('/over-mij?x=1&y=%20');
|
||||
expect(answer.headers['content-length'], method).toBe('0');
|
||||
expect(answer.headers['cache-control'], method).toBeUndefined();
|
||||
expect(answer.raw.length, method).toBe(0);
|
||||
for (const [name, value] of Object.entries(expected)) {
|
||||
expect(answer.headers[name.toLowerCase()], name).toBe(value);
|
||||
}
|
||||
}
|
||||
const plain = await ask(port, '/onbekend/');
|
||||
expect(plain.status).toBe(301);
|
||||
expect(plain.headers.location).toBe('/onbekend');
|
||||
});
|
||||
|
||||
it('houdt de query byte voor byte in de Location (invariant, P-HST-05)', async () => {
|
||||
const port = await serve(siteDir());
|
||||
await fc.assert(
|
||||
fc.asyncProperty(pageVariant, queryString, async (path, query) => {
|
||||
const canonical = canonicalRedirect(path);
|
||||
fc.pre(canonical !== undefined);
|
||||
const answer = await ask(port, `${path}?${query}`);
|
||||
expect(answer.status).toBe(301);
|
||||
expect(answer.headers.location).toBe(`${canonical}?${query}`);
|
||||
}),
|
||||
{ numRuns: 50 },
|
||||
);
|
||||
});
|
||||
|
||||
it('houdt de query in de Location, voorbeeld (P-HST-05)', async () => {
|
||||
const port = await serve(siteDir());
|
||||
const answer = await ask(port, '/soorten-fotoshoots/?shoot=newborn');
|
||||
expect(answer.headers.location).toBe(
|
||||
'/soorten-fotoshoots?shoot=newborn',
|
||||
);
|
||||
// Zonder query geen vraagteken
|
||||
const bare = await ask(port, '/over-mij/');
|
||||
expect(bare.headers.location).toBe('/over-mij');
|
||||
});
|
||||
|
||||
it('serveert /soorten-fotoshoots als pagina naast zijn map, en /assets niet (V3)', async () => {
|
||||
const port = await serve(siteDir());
|
||||
const page = await ask(port, '/soorten-fotoshoots');
|
||||
expect(page.status).toBe(200);
|
||||
expect(page.body).toBe('<p>soorten</p>');
|
||||
expect((await ask(port, '/soorten-fotoshoots/newborn')).body).toBe(
|
||||
'<p>newborn</p>',
|
||||
);
|
||||
expect((await ask(port, '/assets')).status).toBe(404);
|
||||
const slash = await ask(port, '/assets/');
|
||||
expect(slash.status).toBe(301);
|
||||
expect(slash.headers.location).toBe('/assets');
|
||||
});
|
||||
|
||||
it('geeft /%5Cevil.example/ en //evil.example/ de 404-pagina, geen redirect', async () => {
|
||||
const port = await serve(siteDir());
|
||||
for (const path of ['/%5Cevil.example/', '//evil.example/']) {
|
||||
const answer = await ask(port, path);
|
||||
expect(answer.status, path).toBe(404);
|
||||
expect(answer.headers.location, path).toBeUndefined();
|
||||
expect(answer.body, path).toBe('<p>niet gevonden</p>');
|
||||
}
|
||||
});
|
||||
|
||||
it('geeft 405 op POST, PUT en DELETE, met securityheaders', async () => {
|
||||
@@ -518,17 +842,15 @@ describe('startPreviewServer met compressie (BR-SRV-08)', () => {
|
||||
'a.xml',
|
||||
'a.txt',
|
||||
'a.css',
|
||||
'over-mij.html',
|
||||
'over-mij',
|
||||
]) {
|
||||
const answer = await ask(port, `/${name}`, 'GET', GZIP);
|
||||
expect(answer.headers['content-encoding'], name).toBe('gzip');
|
||||
expect(answer.headers['content-type'], name).toBe(
|
||||
contentTypeOf(name),
|
||||
contentTypeOf(name === 'over-mij' ? 'over-mij.html' : name),
|
||||
);
|
||||
expect(gunzipSync(answer.raw).toString('utf8'), name).toBe(
|
||||
name === 'over-mij.html'
|
||||
? '<p>over mij</p>'
|
||||
: `inhoud van ${name}`,
|
||||
name === 'over-mij' ? '<p>over mij</p>' : `inhoud van ${name}`,
|
||||
);
|
||||
}
|
||||
});
|
||||
@@ -626,6 +948,26 @@ describe('previewServer als opdrachtregel', () => {
|
||||
expect(answer.status).toBe(200);
|
||||
});
|
||||
|
||||
it('opent /__audit/404 alleen met --audit-route', async () => {
|
||||
const clientDir = siteDir();
|
||||
const open = async (...extra: string[]) => {
|
||||
const run = start(
|
||||
'--port',
|
||||
'0',
|
||||
'--strictPort',
|
||||
'--dir',
|
||||
clientDir,
|
||||
...extra,
|
||||
);
|
||||
const line = await run.ready;
|
||||
return Number(/:(\d+)\//.exec(line)![1]);
|
||||
};
|
||||
expect((await ask(await open(), '/__audit/404')).status).toBe(404);
|
||||
const audit = await ask(await open('--audit-route'), '/__audit/404');
|
||||
expect(audit.status).toBe(200);
|
||||
expect(audit.body).toBe('<p>niet gevonden</p>');
|
||||
});
|
||||
|
||||
it('stopt met exitcode 1 op een bezette poort met --strictPort', async () => {
|
||||
const blocker = createServer();
|
||||
await new Promise<void>((done) =>
|
||||
|
||||
Reference in New Issue
Block a user