Opens the contact form through a build switch instead of the TEST ONLY commit; closes the AI-DLC records
Continuous Integration / check (pull_request) Successful in 2m25s
Continuous Integration / build-test (pull_request) Skipped
Continuous Integration / deploy-test (pull_request) Skipped
Continuous Integration / lighthouse (pull_request) Successful in 9m2s
Continuous Integration / deploy-production (pull_request) Skipped

The form is closed unless the build sets VITE_CONTACT_FORM_ENABLED=true (only
the test build does), so d449e76 no longer has to be undone before the merge.
Status files of contact-form-cms, asf-packages-cms, asf-cms-host-injection and
asf-translation-files are closed; Build and Test summary added.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-16 12:01:29 +01:00
co-authored by Claude Sonnet 5.5
parent e7bae5edd7
commit db86332c1f
19 changed files with 209 additions and 45 deletions
+7 -6
View File
@@ -49,11 +49,12 @@ Decision (Bryan, 2026-11-15): the hosting package has one entry per website. The
## Environment and variables
| Name | Where | Meaning |
| ------------------------ | ------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `OFFERINGS_URL` | build env | Site address that serves the API (for example `https://test.andreaslop.nl`). Unset gives the snapshot. |
| `ASF_OFFERINGS_URL_TEST` | Gitea repo variable | Value of `OFFERINGS_URL` for the test build. Set by SLS, not by feature sessions. |
| `API_PROXY_TARGET` | dev env | Forwards `/api` in `pnpm dev` to a CMS host. |
| `VITE_SITE_URL` | build env | Address the site presents itself under (canonical, og:*, JSON-LD, sitemap). Only the test build sets it (`https://test.andreaslop.nl`); unset gives `https://andreaslop.nl`. |
| Name | Where | Meaning |
| --------------------------- | ------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `OFFERINGS_URL` | build env | Site address that serves the API (for example `https://test.andreaslop.nl`). Unset gives the snapshot. |
| `ASF_OFFERINGS_URL_TEST` | Gitea repo variable | Value of `OFFERINGS_URL` for the test build. Set by SLS, not by feature sessions. |
| `API_PROXY_TARGET` | dev env | Forwards `/api` in `pnpm dev` to a CMS host. |
| `VITE_SITE_URL` | build env | Address the site presents itself under (canonical, og:*, JSON-LD, sitemap). Only the test build sets it (`https://test.andreaslop.nl`); unset gives `https://andreaslop.nl`. |
| `VITE_CONTACT_FORM_ENABLED` | build env | Opens the contact form when exactly `true`. Only the test build sets it; unset keeps the form closed (production). Opening it in production needs Bryan's explicit go, after the captcha decision ([go-live-checklist.md](go-live-checklist.md)). |
The production artifact is built without `OFFERINGS_URL` on purpose: production must never carry the prices of the test CMS.
+2 -2
View File
@@ -33,9 +33,9 @@ There is one Raspberry Pi runner plus a desktop runner, so jobs can wait in the
Committing, pushing and deploying a feature branch to test is allowed for the sessions that work on it. Merging, deploying to production and changing repo variables are not (Bryan decides). After a test deploy, check the page in a real browser against the real test CMS; `web/e2e/` holds the checks that run in CI.
## TEST ONLY commit (must go before the merge)
## Contact form switch (`VITE_CONTACT_FORM_ENABLED`)
`feature/contact-form-cms` carries commit **`d449e76` "TEST ONLY: enable the contact form for the ASF test deploy"**, which sets `contactForm.enabled: true` in `web/src/content/siteContent.ts` so the ASF test host shows the real form. It must not reach `master` (the form stays off in production until Bryan gives an explicit go). Before merging, revert it (`git revert d449e76`, or drop it from the branch) and confirm `enabled` is `false` again. The packages branch is based on the contact-form branch, so the merge order is `contact-form-cms` first, then `asf-packages-cms`. Both merges need Bryan's go.
The contact form is closed by default. Only the test build (`build-test`) sets `VITE_CONTACT_FORM_ENABLED=true`, so the ASF test host shows the real form; the production artifact (job `check`) is built without it and stays closed. Only the exact value `true` opens the form (`src/lib/contactFormFlag.ts`); anything else keeps it closed, so a typo cannot open it in production. This replaced the former TEST ONLY commit `d449e76` (which hard-coded `enabled: true`); it was reverted before the merge, so nothing has to be undone any more. Opening the form in production needs Bryan's explicit go after the captcha decision (see [go-live-checklist.md](go-live-checklist.md)). Locally: `VITE_CONTACT_FORM_ENABLED=true pnpm build`.
## The check after a deploy and the host injection
+4 -3
View File
@@ -4,8 +4,8 @@ What must be true before the CMS-driven parts of the site go to production. Brya
## Before merging to master
- [ ] Revert the TEST ONLY commit `d449e76` and check `contactForm.enabled` is `false` ([deploy-and-ci.md](deploy-and-ci.md)).
- [ ] Merge order: `feature/contact-form-cms`, then `feature/asf-packages-cms`.
- [x] The TEST ONLY commit `d449e76` is undone: the form is closed unless the build sets `VITE_CONTACT_FORM_ENABLED=true` (only the test build does; [deploy-and-ci.md](deploy-and-ci.md)).
- [ ] Merge: the CMS PR first, then `feature/asf-packages-cms` (which carries the contact-form commits).
- [ ] The nightly test build only starts after the packages feature is on `master` (schedules run from the default branch).
## Packages and banners
@@ -18,7 +18,8 @@ What must be true before the CMS-driven parts of the site go to production. Brya
- [ ] All conditions in the contact-form production readiness checklist (server module, recipient, sender, retention 1 year / 30 days spam, proxies, CSP `frame-src`, a real mail from the production host).
- [ ] Captcha decision: off at go-live until a paid Friendly Captcha plan exists; the EU endpoint changes the CSP and the privacy text.
- [ ] Then, in its own reviewed change, `siteContent.contactForm.enabled = true`.
- [ ] Then, with Bryan's explicit go (after the captcha decision), the production build gets `VITE_CONTACT_FORM_ENABLED=true`, in its own reviewed change. Until then the production artifact has the form closed.
- [ ] Operations for the form are part of this joint production checklist (no separate steps; the rebuild-trigger question lapses because the CMS host shows changes at once, NFR-10).
## Privacy statement (page `/privacyverklaring`)