Opens the contact form through a build switch instead of the TEST ONLY commit; closes the AI-DLC records
Continuous Integration / check (pull_request) Successful in 2m25s
Continuous Integration / build-test (pull_request) Skipped
Continuous Integration / deploy-test (pull_request) Skipped
Continuous Integration / lighthouse (pull_request) Successful in 9m2s
Continuous Integration / deploy-production (pull_request) Skipped

The form is closed unless the build sets VITE_CONTACT_FORM_ENABLED=true (only
the test build does), so d449e76 no longer has to be undone before the merge.
Status files of contact-form-cms, asf-packages-cms, asf-cms-host-injection and
asf-translation-files are closed; Build and Test summary added.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-16 12:01:29 +01:00
co-authored by Claude Sonnet 5.5
parent e7bae5edd7
commit db86332c1f
19 changed files with 209 additions and 45 deletions
@@ -0,0 +1,22 @@
# Build and test summary: asf-packages-cms
Closed 2026-11-16 on branch feature/asf-packages-cms. Unit: web only (host side lives in the SlpModularCms repo).
| Check | Result |
| --------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------- |
| `tsc`, `pnpm lint`, `pnpm format:check` | clean |
| `pnpm test` (Vitest, 100% thresholds on `src/lib/**`, `src/i18n/**`, `seo.ts`, `sitemap.ts`) | 145 files, 1643 tests; one run had a single timing-dependent failure that did not repeat on the next run (to watch, not a known defect) |
| `pnpm baseline:check` (page text byte-identical after the move to nl.json) | equal to the baseline, 12 pages |
| E2E (real Chrome, built site): hydration, contact form, host injection with the stand-in host | passing in CI |
| CI run 107 on the test deploy (check, build-test, deploy-test, lighthouse) | all green, deploy-production skipped |
| Deployment check on ASF-test (pages normalised for host injection, admin files, POST status) | passing |
## Findings and decisions
- Host injection: contract and golden files in `web/contract/host-injection/`; the host side is built by SMC; end-to-end confirmation on ASF-test is still to be reported by SMC.
- The test build sets `VITE_SITE_URL` and `VITE_CONTACT_FORM_ENABLED=true`; the production artifact sets neither (form closed, own address of production).
- Production keeps the committed snapshot until the CMS host is the one entry of the site (separate hosting feature).
## Open (not part of this feature)
- IIS pass-through and production CMS for ASF; Website__PublicBaseUrl on ASF-test; removal of the nightly content build and `OFFERINGS_URL` once host injection is confirmed end to end.