Opens the contact form through a build switch instead of the TEST ONLY commit; closes the AI-DLC records
Continuous Integration / check (pull_request) Successful in 2m25s
Continuous Integration / build-test (pull_request) Skipped
Continuous Integration / deploy-test (pull_request) Skipped
Continuous Integration / lighthouse (pull_request) Successful in 9m2s
Continuous Integration / deploy-production (pull_request) Skipped

The form is closed unless the build sets VITE_CONTACT_FORM_ENABLED=true (only
the test build does), so d449e76 no longer has to be undone before the merge.
Status files of contact-form-cms, asf-packages-cms, asf-cms-host-injection and
asf-translation-files are closed; Build and Test summary added.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-16 12:01:29 +01:00
co-authored by Claude Sonnet 5.5
parent e7bae5edd7
commit db86332c1f
19 changed files with 209 additions and 45 deletions
@@ -1,30 +1,42 @@
# AI-DLC State Tracking
## Project Information
- **Feature Name**: ASF packages and banner from the CMS (build-time)
- **Feature Name**: ASF packages and banners from the CMS (build step, live refresh, CMS-host injection, translation files, fonts)
- **Feature Slug**: asf-packages-cms
- **Project Type**: Brownfield
- **Start Date**: 2026-11-12
- **Current Stage**: CONSTRUCTION - code generated, awaiting CMS data on ASF-test for a test deploy
- **Branch**: feature/asf-packages-cms (from feature/contact-form-cms 7737104; merge order: contact-form-cms first)
- **Current Stage**: COMPLETE (closed 2026-11-16, Bryan's go via SLP Software - SLS - Main); PR feature/asf-packages-cms to master, waiting for the CMS PR to merge first. No production release.
- **Branch**: feature/asf-packages-cms (carries the contact-form-cms commits; the TEST ONLY commit d449e76 is undone by the `VITE_CONTACT_FORM_ENABLED` switch)
- **Worktree**: K:\Development\SlpSoftware\Projects\AndreaSlopFotografie-packages
## Language Configuration
- **Documentation Language**: English
- **Conversation Language**: User Language (Dutch)
- **Source**: aidlc-docs/language-preference.md
## Extension Configuration
- Security Baseline: Yes (inherited from contact-form-cms)
- Property-Based Testing: Partial (inherited)
## Operations Configuration
- **Include Operations Phase**: No for now (deployment is the existing CI; rebuild trigger is a pending decision by Bryan)
- **Include Operations Phase**: Yes, as part of the joint production checklist ([docs/go-live-checklist.md](../../../docs/go-live-checklist.md)); no separate steps. The rebuild-trigger question lapses: the CMS host injects current data into the pages, so a CMS change is visible at once (NFR-10).
## Scope as delivered
- Packages and both banners (top bar, band under the cards) from the CMS offerings API, snapshot fallback, centred card rows, featured package style.
- CMS-host injection of the data into the prerendered pages (own feature record: [asf-cms-host-injection](../asf-cms-host-injection/aidlc-state.md)).
- Translation files: all static Dutch text in `web/src/i18n/nl.json` ([asf-translation-files](../asf-translation-files/aidlc-state.md)).
- Fonts (Cormorant Garamond, Mulish), green outline buttons, theme twigs removed with the assets and licence document, own test address (`VITE_SITE_URL`), contact form switch (`VITE_CONTACT_FORM_ENABLED`), documentation set (README, docs/*).
## Stage Progress
- [x] INCEPTION - Workspace Detection, Requirements (approved by SLP Software - SLS - Main for Bryan, 2026-11-12)
- [x] INCEPTION - Workflow Planning (single unit: build step + site wiring)
- [x] CONSTRUCTION - Functional Design (see requirements.md, design recorded there; approved: snapshot fallback, one source, banner as own block)
- [x] CONSTRUCTION - Code Generation (build step, mapping, snapshot, banner, tests)
- [ ] CONSTRUCTION - Build and Test on ASF-test with real CMS data (blocked: Offerings module + 3 packages in the ASF-test CMS, asked of the CMS session)
- [ ] OPERATIONS - rebuild trigger (webhook or nightly) decided by Bryan
- [x] INCEPTION - Workflow Planning (single unit)
- [x] CONSTRUCTION - Functional Design (requirements.md)
- [x] CONSTRUCTION - Code Generation
- [x] CONSTRUCTION - Build and Test: closed 2026-11-16, see [build-and-test-summary.md](construction/build-and-test/build-and-test-summary.md); the former blocker (CMS data on ASF-test) no longer applies: the data reaches the pages through the CMS host
- [x] OPERATIONS - included in the joint production checklist (no separate steps)
@@ -0,0 +1,22 @@
# Build and test summary: asf-packages-cms
Closed 2026-11-16 on branch feature/asf-packages-cms. Unit: web only (host side lives in the SlpModularCms repo).
| Check | Result |
| --------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------- |
| `tsc`, `pnpm lint`, `pnpm format:check` | clean |
| `pnpm test` (Vitest, 100% thresholds on `src/lib/**`, `src/i18n/**`, `seo.ts`, `sitemap.ts`) | 145 files, 1643 tests; one run had a single timing-dependent failure that did not repeat on the next run (to watch, not a known defect) |
| `pnpm baseline:check` (page text byte-identical after the move to nl.json) | equal to the baseline, 12 pages |
| E2E (real Chrome, built site): hydration, contact form, host injection with the stand-in host | passing in CI |
| CI run 107 on the test deploy (check, build-test, deploy-test, lighthouse) | all green, deploy-production skipped |
| Deployment check on ASF-test (pages normalised for host injection, admin files, POST status) | passing |
## Findings and decisions
- Host injection: contract and golden files in `web/contract/host-injection/`; the host side is built by SMC; end-to-end confirmation on ASF-test is still to be reported by SMC.
- The test build sets `VITE_SITE_URL` and `VITE_CONTACT_FORM_ENABLED=true`; the production artifact sets neither (form closed, own address of production).
- Production keeps the committed snapshot until the CMS host is the one entry of the site (separate hosting feature).
## Open (not part of this feature)
- IIS pass-through and production CMS for ASF; Website__PublicBaseUrl on ASF-test; removal of the nightly content build and `OFFERINGS_URL` once host injection is confirmed end to end.
@@ -3,6 +3,7 @@
Decided by Bryan via SLP Software - SLS - Main, 2026-11-12. Source of truth: the CMS API `GET /api/v1/offerings` (fields: id, slug, title, description, price as free text, priceNote, features[], ctaLabel, featured, displayOrder, categoryId, category, layout `card|banner`; at most one banner per site).
## Requirements
- FR-PK-01 The build asks the CMS for the offerings and bakes them into the pages (prices in the HTML and in the structured data). The browser never calls the offerings API.
- FR-PK-02 Fallback: with no address, an unreachable CMS or an answer without a valid package the committed snapshot (`src/content/offerings.snapshot.json`, the three packages) is used. The build never fails because of the CMS and never shows an empty or wrong price. The log names the source.
- FR-PK-03 One source: the price cards, the "welke shoot" choices of the contact form and the `?pakket=` check use the same list (`content/packages.ts`).
@@ -14,6 +15,7 @@ Decided by Bryan via SLP Software - SLS - Main, 2026-11-12. Source of truth: the
- NFR-PK-01 Tests use the snapshot only (no dependence on a build or network).
## Design
- `web/config/offerings.ts` pure mapping and validation (unit and property tests).
- `web/config/fetchOfferings.ts` build step (`pnpm build` runs it first): `OFFERINGS_URL` (the site's own address serving the API), 10 s timeout, 2 attempts, writes the gitignored `src/content/offerings.generated.json`.
- `web/src/content/packages.ts` picks generated data (build) or the snapshot (tests, missing file).
@@ -21,6 +23,7 @@ Decided by Bryan via SLP Software - SLS - Main, 2026-11-12. Source of truth: the
- `PriceBanner` component inside `Pricing`.
## Open
- Offerings module on the ASF-test host and the three packages in the ASF-test CMS (asked of the CMS session; 2026-11-12 the endpoint answered 404 on test.andreaslop.nl).
- Repo variable `ASF_OFFERINGS_URL` (who sets it: Bryan or SLS).
- Rebuild trigger.