diff --git a/aidlc-docs/_shared/reverse-engineering/api-documentation.md b/aidlc-docs/_shared/reverse-engineering/api-documentation.md index 58f76cb..b8c78c6 100644 --- a/aidlc-docs/_shared/reverse-engineering/api-documentation.md +++ b/aidlc-docs/_shared/reverse-engineering/api-documentation.md @@ -15,7 +15,7 @@ None. There is no back-end yet (`api/` is empty). The static design README antic | `/over-mij` | `routes/over-mij.tsx` | `pageHead('/over-mij')` + `AboutPage` JSON-LD | `PageIntro`, `AboutIntro`, `StorySection` ×2, `PhotoDuo`, `LinkButton` | yes | | `/portfolio` | `routes/portfolio.tsx` | `pageHead('/portfolio')` + `ImageGallery` JSON-LD; search `?shoot=` (`ShootTypeId`) | `PageIntro`, `PortfolioGallery`, `InstagramGrid` | yes | | `/soorten-fotoshoots` | `routes/soorten-fotoshoots/index.tsx` | `pageHead('/soorten-fotoshoots')` + `WebPage` JSON-LD via `StructuredData` (`webPage()` + `shootServices()`; Service `@id` `…/soorten-fotoshoots/#service` per D2) | `PageIntro`, `shoots/ShootList` (5× `ShootBlock`), `CallToAction`, `RichParagraph`, `LinkButton` | yes | -| `/soorten-fotoshoots/` (newborn, zwangerschap, gezin, loveshoot, portret) | `routes/soorten-fotoshoots/.tsx` | `pageHead('/soorten-fotoshoots/')`; JSON-LD via `StructuredData` (`shootPageGraph`: `WebPage` with the shoot's Service, `FAQPage` when there are questions) | `shoots/ShootPage` (`PageIntro` only in unit 1), `NotFound` when `shootPageView` returns `undefined` | yes | +| `/soorten-fotoshoots/` (newborn, zwangerschap, gezin, loveshoot, portret) | `routes/soorten-fotoshoots/.tsx` | `pageHead('/soorten-fotoshoots/')` with its own `ogImage` (`/og-.jpg`, 1200 × 630, unit 2); JSON-LD via `StructuredData` (`shootPageGraph`: `WebPage` with the shoot's Service, `FAQPage` when there are questions) | `shoots/ShootPage` (intro, story blocks, process timeline, photo mosaic when there are at least two photos, FAQ when there are questions, package block, closing call to action), `NotFound` when `shootPageView` returns `undefined` | yes | | `/contact` | `routes/contact.tsx` | `pageHead(...)` | `PageIntro` placeholder | no | | `/privacyverklaring` | `routes/privacyverklaring.tsx` | `pageHead(...)` | `PageIntro` placeholder | no | | (not found) | — | — | `NotFound` | — | @@ -68,6 +68,7 @@ None. There is no back-end yet (`api/` is empty). The static design README antic - Portfolio (`lib/portfolioFilters.ts`): `isShootTypeId`, `shootTypesWithPhotos(shootTypes, photos)`, `shootFromSearch(value, available)`, `filterPhotos(photos, shoot)`, `filterOptions(shootTypes, allLabel)`, `toGalleryItems(photos, shootTypes)`, `photoCountLabel(n)`; `seo.ts`: `galleryImages(photos)` - Gallery (portfolio-page): `wrapIndex(index, count)`, `swipeDirection(start, end, threshold = 50)`, `masonryRowSpan({ width, height }, K = 40, gapRows = 2)`, `neighbourIndexes(index, count, radius = 2)`, `lightboxReducer(state, event)` (+ `LightboxState`, `LightboxEvent`) - Shoot pages (unit 1): `shootPagePath(id)`, `shootIdFromSlug(slug)`, `shootIdFromPath(pathname)` (`lib/shootPages.ts`); `shootPackage(shoot, packages)` (`lib/shootPackage.ts`); `fillPlaceholders(text, values)`, `fillRichText(rich, values)` (`lib/fillPlaceholders.ts`); `richTextToPlain(text)` (`lib/richTextToPlain.ts`); `shootPageView(id, page, sources)` (`lib/shootPageView.ts`) +- Shoot pages (unit 2): `headingId(prefix, id)` (`lib/headingId.ts`), `readMoreLabel(shoot)` (`lib/readMoreLabel.ts`), `mosaicLayout(count): MosaicTile[]` (`lib/mosaicLayout.ts`), `storyLayout(stories): StoryLayout[]` (`lib/storyLayout.ts`), `shootPageBands(view): SectionBand[]` (`lib/shootPageBands.ts`; the section order of `ShootPage`), `isShootSectionPath(pathname)` (`lib/isShootSectionPath.ts`, FR-ST-14, used by `NotFound`) - Navigation (unit 3): `shootNavItems(shoots): NavItem[]` (`lib/shootNavItems.ts`); `isItemCurrent(item, pathname)`, `isSectionCurrent(item, pathname)` (`lib/navCurrent.ts`); `navMenuReducer(state, event)` with `NavMenuState`, `NavMenuEvent`, `initialNavMenuState`, `FocusRequest` (`lib/navMenuState.ts`) ### Monitoring diff --git a/aidlc-docs/_shared/reverse-engineering/architecture.md b/aidlc-docs/_shared/reverse-engineering/architecture.md index 2c3f585..8a2e7eb 100644 --- a/aidlc-docs/_shared/reverse-engineering/architecture.md +++ b/aidlc-docs/_shared/reverse-engineering/architecture.md @@ -41,7 +41,7 @@ graph TD class Content,NavData,Seo,Theme,Blocks support; ``` -Text alternative: main.tsx starts Sentry and mounts the router; the root route renders AppShell (skip link, NavigationBar, the page via Outlet, Footer, BackToTop, Umami); the home route renders the Hero and six sections built from shared blocks (one of them lazily loads the contact form); the about route renders the Over mij page; the other routes render placeholder PageIntros; content, navigation, SEO and theme modules support all of it. +Text alternative: main.tsx starts Sentry and mounts the router; the root route renders AppShell (skip link, NavigationBar, the page via Outlet, Footer, BackToTop, Umami); the home route renders the Hero and six sections built from shared blocks (one of them lazily loads the contact form); the about route renders the Over mij page; the other routes render placeholder PageIntros; the shoot pages render `shoots/ShootPage`, whose sections follow `shootPageBands(view)` (`lib/shootPageBands.ts`): intro, stories, process, photos, FAQ, package, closing; content, navigation, SEO and theme modules support all of it. ## Component Descriptions ### main.tsx diff --git a/aidlc-docs/_shared/reverse-engineering/code-structure.md b/aidlc-docs/_shared/reverse-engineering/code-structure.md index b7d9ee3..ca449e3 100644 --- a/aidlc-docs/_shared/reverse-engineering/code-structure.md +++ b/aidlc-docs/_shared/reverse-engineering/code-structure.md @@ -60,19 +60,24 @@ Candidates for modification are marked with ★ for the over-mij-page feature. - `web/src/routes/index.tsx` — home (`/`): Hero + six sections, `?pakket=` search param - `web/src/routes/over-mij.tsx` — the about page (indexed; `AboutPage` JSON-LD) - `web/src/components/about/*` — `AboutIntro`, `StorySection` -- `web/src/components/shoots/*` — `ShootList`, `ShootBlock` (soorten-fotoshoots page) -- `web/src/components/shoots/ShootPage/ShootPage.tsx` — shoot page shell, `ShootPageView` in (unit 1: intro only; unit 2 adds the sections) +- `web/src/components/shoots/*` — `ShootList`, `ShootBlock` (soorten-fotoshoots page; unit 2: "Lees meer over de …" link first in the row, to the shoot page) +- `web/src/components/shoots/ShootPage/ShootPage.tsx` — shoot page, `ShootPageView` in: intro, then the sections in `shootPageBands` order (unit 2: stories, process, photos, FAQ, package, closing; wrapper `data-testid="shoot-page"`) +- `web/src/components/shoots/{StoryBlocks,ProcessIcons}/` — shoot page parts (unit 2): one `PageSection` per story (`StoryBlocks`); the six process icons as inline SVG (`ProcessIcons`) +- `web/src/components/{Breadcrumb,ProcessTimeline,PhotoMosaic,FaqList,PackageBlock}/` — shoot page parts (unit 2), each with a test - `web/src/components/StructuredData/StructuredData.tsx` — JSON-LD script via `jsonLdScript`; the only `dangerouslySetInnerHTML` of the shoot pages -- `web/src/components/{CallToAction,RichParagraph}/` — shared closing block; paragraph with inline links +- `web/src/components/{CallToAction,RichParagraph}/` — shared closing block (unit 2 adds `tone`); paragraph with inline links - `web/src/content/{shootTypes,shootTypesPageContent}.ts` — shoot types (also used by the portfolio filters) and page texts; `web/src/assets/shoots/` — 4:5 shoot photos - `web/src/lib/shootLinks.ts` — contact and portfolio link targets per shoot type - `web/src/lib/{shootPages,shootPackage,fillPlaceholders,richTextToPlain,shootPageView}.ts` — shoot page helpers (ids and paths, package, placeholders, plain text, view), each with a test +- `web/src/lib/{headingId,readMoreLabel,mosaicLayout,storyLayout,shootPageBands}.ts` — shoot page helpers (unit 2): safe heading ids, "Lees meer" label, photo-mosaic and story layout, section bands; each with a test at 100 % coverage +- `web/src/lib/isShootSectionPath.ts` — whether a pathname is under `/soorten-fotoshoots/` (FR-ST-14, used by `StatusPage/NotFound`), with a property-based test - `web/src/lib/{shootNavItems,navCurrent,navMenuState}.ts` — navigation helpers (unit 3), each with a test: submenu items from the shoot types (`shootNavItems`), current-page and section-current matching (`isItemCurrent`, `isSectionCurrent`), menu state reducer (`navMenuReducer`, `NavMenuState`, `NavMenuEvent`; `navMenuState.ts` at 100 % coverage) - `web/src/components/PhotoDuo/PhotoDuo.tsx` — two photos side by side - `web/src/content/aboutContent.ts` — about page content; `web/src/assets/about/*` — portrait and duo photos; `web/public/og-over-mij.jpg` — preview image - `web/src/routes/soorten-fotoshoots/index.tsx` — the shoot types page (moved from `routes/soorten-fotoshoots.tsx`); `newborn.tsx`, `zwangerschap.tsx`, `gezin.tsx`, `loveshoot.tsx`, `portret.tsx` — one route per shoot page (`/soorten-fotoshoots/`); `-shootPageSources.ts` — the sources the shoot routes share - `web/src/content/shootPageShared.ts` — shared shoot page content (breadcrumb, process, deposit, shared FAQ items, offer texts); `web/src/content/shootPages/*.ts` — one content module per shoot page, plus `shootPages.test.ts` (content consistency) - `web/src/test/renderApp.tsx` — `renderApp(path)` and `expectShell()` for the route tests +- `web/src/shootPages.test.tsx` — route tests for the five shoot pages (unit 2): outline, sections, breadcrumb, `aria-current` (main and menus), package variants, OG registry, axe; the overview's "Lees meer" links - `web/src/routes/portfolio.tsx` — the portfolio (indexed; `?shoot=` filter; `ImageGallery` JSON-LD); `web/src/components/portfolio/PortfolioGallery/`, `web/src/content/portfolioContent.ts`, `web/src/lib/portfolioFilters.ts`, `web/src/assets/portfolio/*` (10 photos × 2 sizes), `web/public/og-portfolio.jpg` - `web/src/routes/{contact,privacyverklaring}.tsx` — placeholders with `PageIntro` - `web/src/components/AppShell.tsx` — shell @@ -82,14 +87,14 @@ Candidates for modification are marked with ★ for the over-mij-page feature. - `web/src/components/home/*` — five homepage sections (AboutBlock is the closest relative of the Over mij page's first block) - `web/src/components/InstagramGrid/InstagramGrid.tsx` — Instagram block, shared by the homepage and the portfolio (moved from `home/` in portfolio-page) - ★ `web/src/components/PageSection/PageSection.tsx` — section frame for any page (was `HomeSection`) -- ★ `web/src/components/MediaText/MediaText.tsx`, `Eyebrow/Eyebrow.tsx` — framed photo next to text; accent label +- ★ `web/src/components/MediaText/MediaText.tsx`, `Eyebrow/Eyebrow.tsx` — framed photo next to text; accent label (unit 2 adds `mediaSize` `'medium'`) - ★ `web/src/components/SectionHeading/SectionHeading.tsx` — eyebrow + h2 + lead - ★ `web/src/components/FramedImage/FramedImage.tsx`, `DeferredImage/DeferredImage.tsx`, `Reveal/Reveal.tsx` — photo blocks and fade-in - `web/src/components/ContactForm/*` — contact form and gate - `web/src/components/BackToTop/BackToTop.tsx` — back-to-top button - `web/src/components/Analytics/UmamiAnalytics.tsx` — Umami script injection -- ★ `web/src/components/PageIntro/PageIntro.tsx` — page head block (eyebrow, h1, intro) -- `web/src/components/StatusPage/*` — StatusPage layout, NotFound, ErrorPage +- ★ `web/src/components/PageIntro/PageIntro.tsx` — page head block (eyebrow, h1, intro; unit 2 adds optional `titleId` and `breadcrumb`) +- `web/src/components/StatusPage/*` — StatusPage layout, NotFound (unit 2, FR-ST-14: under `/soorten-fotoshoots/` buttons back to the overview and to home, decided by `lib/isShootSectionPath.ts`), ErrorPage - ★ `web/src/components/LinkButton.tsx`, `RouterLink.tsx` — router links (button style / Chakra-wrapped) - ★ `web/src/content/types.ts` — content interfaces (API shape) - ★ `web/src/content/*.ts` — static content (`siteContent`, `heroContent`, `homeContent` (exports `introPhotos`), `instagramContent`, `packages`, `testimonials`, `socialPlatforms`) @@ -109,7 +114,7 @@ Candidates for modification are marked with ★ for the over-mij-page feature. - `web/config/securityHeaders.ts` — CSP - `web/config/serverConfig.ts`, `writeServerConfig.ts`, `sitemapPlugin.ts`, `testSeed.ts` - `web/deploy/iis/web.config`, `web/deploy/nginx/*.conf` — generated server configs -- `web/public/*` — favicon, logo, og-image, robots.txt, icons.svg +- `web/public/*` — favicon, logo, og-image, robots.txt, icons.svg; `og-{newborn,zwangerschap,gezin,loveshoot,portret}.jpg` (unit 2: 1200 × 630, the shoot pages' `ogImage`) ## Design Patterns ### API-shaped static content diff --git a/aidlc-docs/features/shoot-type-pages/aidlc-state.md b/aidlc-docs/features/shoot-type-pages/aidlc-state.md index 3926560..08888ff 100644 --- a/aidlc-docs/features/shoot-type-pages/aidlc-state.md +++ b/aidlc-docs/features/shoot-type-pages/aidlc-state.md @@ -5,7 +5,7 @@ - **Feature Slug**: shoot-type-pages - **Project Type**: Brownfield - **Start Date**: 2026-10-29T17:19:19Z -- **Current Stage**: CONSTRUCTION - Code Generation Part 2 (unit 2 Shoot page UI ∥ unit 3 Navigation submenu) +- **Current Stage**: CONSTRUCTION - Code Generation complete, awaiting approval to continue to Build and Test - **Branch**: feature/shoot-type-pages (from master 18e81d0) - **Worktree**: K:\Development\SlpSoftware\Projects\AndreaSlopFotografie-shoot-type-pages @@ -57,7 +57,7 @@ - [ ] NFR Requirements - SKIP - [ ] NFR Design - SKIP - [ ] Infrastructure Design - SKIP -- [~] Code Generation - EXECUTE (per unit): 1 Content and SEO foundation ✅ (uncommitted; Step 24 red only on pre-existing master issues) → 2 Shoot page UI ∥ 3 Navigation submenu +- [x] Code Generation - EXECUTE (per unit): 1 Content and SEO foundation ✅ (e5f4348) → 2 Shoot page UI ✅ ∥ 3 Navigation submenu ✅ (7af2069; plus FR-ST-14); open: unit 2 Step 23 mobile Lighthouse gezin/loveshoot < 0.85 (owner keeps fade-in) - [ ] Build and Test - EXECUTE ### 🟡 OPERATIONS PHASE diff --git a/aidlc-docs/features/shoot-type-pages/audit.md b/aidlc-docs/features/shoot-type-pages/audit.md index 58926db..d677e3e 100644 --- a/aidlc-docs/features/shoot-type-pages/audit.md +++ b/aidlc-docs/features/shoot-type-pages/audit.md @@ -379,3 +379,18 @@ **Context**: CONSTRUCTION - Code Generation Part 2 --- + +## Code Generation (unit 2) — Lighthouse mitigation declined for now +**Timestamp**: 2026-10-30T14:15:20Z +**User Input**: "laat de fade-in nog maar even staan" +**AI Response**: Reveal fade-in on story 0 stays. Unit 2 Step 23 stays open as a known item: mobile gezin 0.84–0.85 and loveshoot 0.83 below the 0.85 budget; to be revisited (Build and Test / follow-up). CI run 586 (7af2069): check and deploy-test succeeded. Unit 2 Steps 24–25 (docs) delegated to Haiku. +**Context**: CONSTRUCTION - Code Generation Part 2 + +--- + +## Code Generation (units 2 and 3) — Complete, approval prompt +**Timestamp**: 2026-10-30T14:21:07Z +**AI Response**: Unit 2 Steps 24–25 (code summary, RE lines) done by Haiku and reviewed; Step 27 hand-back done by orchestrator. Code Generation complete for all three units. Presented completion message with "Request Changes" / "Continue to Next Stage" (Build and Test). Docs committed and pushed (no deploy, per the user's instruction). +**Context**: CONSTRUCTION - Code Generation + +--- diff --git a/aidlc-docs/features/shoot-type-pages/construction/plans/shoot-page-ui-code-generation-plan.md b/aidlc-docs/features/shoot-type-pages/construction/plans/shoot-page-ui-code-generation-plan.md index d1b2077..0ac93c7 100644 --- a/aidlc-docs/features/shoot-type-pages/construction/plans/shoot-page-ui-code-generation-plan.md +++ b/aidlc-docs/features/shoot-type-pages/construction/plans/shoot-page-ui-code-generation-plan.md @@ -201,17 +201,19 @@ This plan is the **single source of truth** for code generation of unit 2. Steps - If any item fails: diagnose the root cause, fix it (or hand a [sonnet] fix step to the orchestrator), re-run. Do not weaken a test or threshold. - [ ] **Step 23 — Lighthouse (mobile and desktop)** [haiku] — *NFR-ST-01, NFR-ST-03, FR-ST-12, SEO-ST-04* - - **Result (2026-10-30), NOT green (left unchecked): mobile performance budgets fail on four pages; everything else passes.** Build = Step 22 build with units 1+2+3; `pnpm lighthouse` equivalent (`lhci autorun`, then `lhci autorun --config=lighthouserc.desktop.cjs`, 1 run per URL; the mobile command exits 1 on the assertions, desktop exits 0). Accessibility, best practices 1.0 on all 12 URLs mobile and desktop; SEO 1.0 on all indexed pages (0.58 `/bestaat-niet`, 0.69 `/privacyverklaring` are the expected noindex values). Mobile performance (unit-1 Step 24 in brackets): `/` 0.75 (0.76) FAIL budget 0.8; `/contact` 0.87 (0.85) FAIL budget 0.9; `/over-mij` 0.87; `/portfolio` 0.91; `/soorten-fotoshoots` 0.85; newborn 0.86 (0.90); zwangerschap 0.85 (0.90); gezin 0.84 (0.90) FAIL budget 0.85; loveshoot 0.83 (0.90) FAIL budget 0.85; portret 0.85 (0.90); `/privacyverklaring` 0.90; `/bestaat-niet` 0.92. Re-measure of the two failing shoot pages, 3 runs each: gezin 0.85, 0.85, 0.85 (passes, borderline), loveshoot 0.83, 0.83, 0.83 (fails consistently). Desktop performance 0.99-1.00 on every page (shoot pages 0.99; budget 0.9). `/` and `/contact` fail on master too (0.78 / 0.87). Diagnosis (loveshoot, gezin): the first story photo is not the bottleneck (153 / 117 KB, load time 15-24 ms); LCP is 3.8 / 3.7 s with a render delay of ~2.9-3.0 s, FCP is 2.6 s on every page, i.e. the image is only painted after the main bundle (536 kB, +1.9 kB gzip from unit 3) has run, which matches the `photoPagePaths` comment in `lighthouserc.cjs`; the shoot pages dropped 0.05-0.07 from the shell-only unit-1 numbers because the page now renders the first story through `MediaText`/`Reveal` inside the lazy route chunk. Mitigations for the orchestrator, in the plan's order, none applied: (1) first story without the fade-in (`Reveal` removed for story 0), (2) fewer pixels for the first photo by capping its column, (3) report and keep the known limit. Preview port 4173 released (the lhci server stopped itself; free). + - **Result (2026-10-30), NOT green (left unchecked): open — owner keeps fade-in (2026-10-30). Mobile performance budgets fail on four pages; everything else passes.** Build = Step 22 build with units 1+2+3; `pnpm lighthouse` equivalent (`lhci autorun`, then `lhci autorun --config=lighthouserc.desktop.cjs`, 1 run per URL; the mobile command exits 1 on the assertions, desktop exits 0). Accessibility, best practices 1.0 on all 12 URLs mobile and desktop; SEO 1.0 on all indexed pages (0.58 `/bestaat-niet`, 0.69 `/privacyverklaring` are the expected noindex values). Mobile performance (unit-1 Step 24 in brackets): `/` 0.75 (0.76) FAIL budget 0.8; `/contact` 0.87 (0.85) FAIL budget 0.9; `/over-mij` 0.87; `/portfolio` 0.91; `/soorten-fotoshoots` 0.85; newborn 0.86 (0.90); zwangerschap 0.85 (0.90); gezin 0.84 (0.90) FAIL budget 0.85; loveshoot 0.83 (0.90) FAIL budget 0.85; portret 0.85 (0.90); `/privacyverklaring` 0.90; `/bestaat-niet` 0.92. Re-measure of the two failing shoot pages, 3 runs each: gezin 0.85, 0.85, 0.85 (passes, borderline), loveshoot 0.83, 0.83, 0.83 (fails consistently). Desktop performance 0.99-1.00 on every page (shoot pages 0.99; budget 0.9). `/` and `/contact` fail on master too (0.78 / 0.87). Diagnosis (loveshoot, gezin): the first story photo is not the bottleneck (153 / 117 KB, load time 15-24 ms); LCP is 3.8 / 3.7 s with a render delay of ~2.9-3.0 s, FCP is 2.6 s on every page, i.e. the image is only painted after the main bundle (536 kB, +1.9 kB gzip from unit 3) has run, which matches the `photoPagePaths` comment in `lighthouserc.cjs`; the shoot pages dropped 0.05-0.07 from the shell-only unit-1 numbers because the page now renders the first story through `MediaText`/`Reveal` inside the lazy route chunk. Mitigations for the orchestrator, in the plan's order, none applied: (1) first story without the fade-in (`Reveal` removed for story 0), (2) fewer pixels for the first photo by capping its column, (3) report and keep the known limit. Preview port 4173 released (the lhci server stopped itself; free). - Depends on: Step 22 green. **Needs the orchestrator's claim of port 4173** (`pnpm preview --port 4173 --strictPort`; `--strictPort` fails fast when taken: then wait, never change the port) and a quiet machine (performance is blocking locally). Do not start without the orchestrator's go. - In `web/`: `pnpm lighthouse` (runs `lhci autorun` for mobile and then `lhci autorun --config=lighthouserc.desktop.cjs`; indexed pages incl. the five shoot pages). Run it **after Step 19** so the OG images and final markup are measured (if the crops are still unapproved, run now and re-run later). - Expected: accessibility, best practices and SEO **1.0** on every page, mobile and desktop; the five shoot pages performance ≥ **0.85 mobile** (goal 0.9) and ≥ **0.9 desktop**. Unit 1 left the shoot pages at 0.90 mobile / 100 desktop with the shell only and the baseline failures `/` 0.76 (budget 0.8) and `/contact` 0.85 (budget 0.9) that also fail on master; report current numbers for all pages next to those. - A performance failure is **reported with the numbers, not worked around**. Mitigation order if the largest paint of a shoot page regressed (frontend-components.md § 7), each as a separate suggested fix for the orchestrator: (1) first story without the fade-in (`Reveal` removed for story 0), (2) fewer pixels for the first photo by capping its column, (3) report and keep the known limit. Record scores in the code summary; release the port claim when done. -- [ ] **Step 24 — Code summary** [haiku] — *traceability, CON-ST-03* +- [x] **Step 24 — Code summary** [haiku] — *traceability, CON-ST-03* + - **Result**: `shoot-page-ui/code/code-summary.md` written, modelled on unit 3's summary. Units 2 and 3 are in commit `7af2069` (see the summary's Commits section); the summary and the Step 25 lines are not committed. Lighthouse is recorded as open. - Depends on: Steps 22, 23. - New `aidlc-docs/features/shoot-type-pages/construction/shoot-page-ui/code/code-summary.md` (same sections as unit 1's summary): status of each step; files created / changed (one line each, grouped as in "Files" above); requirement and business-rule coverage table (FR-ST-02..09, FR-ST-13, SEO-ST-04/05, NFR-ST-01/02/03/05/06, BR-SP-01..90 → files and tests); test count and seed (Step 22); bundle check numbers (Step 22); Lighthouse scores per page, mobile and desktop (Step 23); the OG images (sources, crops, sizes, approval date and who approved); deviations from this plan with reasons (the `app.test.tsx` assertion, the Gezin OG source, anything else); comparison notes against design E (Step 17); interfaces left for the orchestrator; open items (case-sensitive routing and the seroval advisory remain unit-1 decisions; whole-page `aria-current` integration facet, Step 26); the final Security and PBT compliance table below with evidence. State plainly that nothing is committed. -- [ ] **Step 25 — Reverse-engineering lines (unit 2's own)** [haiku] — *NFR-ST-07* +- [x] **Step 25 — Reverse-engineering lines (unit 2's own)** [haiku] — *NFR-ST-07* + - **Result**: unit 2's lines added by targeted edits in `code-structure.md`, `api-documentation.md` and `architecture.md` (the StatusPage/NotFound and `isShootSectionPath` lines included); unit 1 and unit 3 lines untouched apart from the `ShootPage` line that unit 2 changes. No timestamp refresh. - Only this unit's lines in `aidlc-docs/_shared/reverse-engineering/`, added with targeted edits next to unit 1's lines (never rewrite or re-flow a file: unit 3's lines go into the same files, so re-read the file immediately before editing and edit by unique anchor text; if it changed unexpectedly in the last minutes, tell the orchestrator instead of guessing): - `code-structure.md`: `components/{Breadcrumb,ProcessTimeline,PhotoMosaic,FaqList,PackageBlock}/`, `components/shoots/{StoryBlocks,ProcessIcons}/`, the changed `ShootPage` line (sections instead of the shell), the `ShootBlock` link, the additive `PageIntro`/`MediaText`/`CallToAction` props, `lib/{headingId,readMoreLabel,mosaicLayout,storyLayout,shootPageBands}.ts`, `src/shootPages.test.tsx`, `public/og-.jpg` ×5. - `api-documentation.md`: lib section bullets for the five new helpers; the five shoot route rows now mention the sections and the `ogImage` per page (one short phrase each). @@ -223,7 +225,8 @@ This plan is the **single source of truth** for code generation of unit 2. Steps - **Run only when unit 3 is built in the same worktree.** Currently the header link "Soorten fotoshoots" and the footer link receive TanStack's fuzzy `aria-current="page"` on a shoot page (unit 3 fixes both, application-design D4), so a **whole-page** "exactly one `aria-current="page"`" assertion cannot pass in unit 2 alone; Step 18 therefore checks `main` only. - Add to `src/shootPages.test.tsx` (unit 2's file) one test per shoot: in the whole document exactly one element has `aria-current="page"` **and** it is the breadcrumb's last item or the nav's exact-page child (decide with unit 3's final markup; the intended rule is "only the exact page", D4), then re-run the unit's tests. If both header submenu child and breadcrumb mark the same page, the rule is "at most one in `main` and at most one in `header`", not one overall; record the decision in the code summary. -- [ ] **Step 27 — Hand back** [haiku] +- [x] **Step 27 — Hand back** [haiku] + - Result (2026-10-30): done by the orchestrator. The user authorised commit, push and test deploy during this stage: units 2 and 3 with FR-ST-14 are commit 7af2069, deployed to test by CI run 586. Step 23 stays open (owner keeps the fade-in). - Report to the orchestrator: steps done and still blocked (Step 2 waits for the user's approval of the crops; Steps 19, 20 follow; Step 23 waits for the port claim; Step 26 waits for unit 3), check results, deviations from this plan, the changed shared components list, and the list of files outside unit 2's ownership that were touched (`src/app.test.tsx` one assertion). **No commit or push**; the orchestrator asks the user. A commit for the unit ("a commit per unit") is made only when the user asks. ## Requirement / business-rule traceability diff --git a/aidlc-docs/features/shoot-type-pages/construction/shoot-page-ui/code/code-summary.md b/aidlc-docs/features/shoot-type-pages/construction/shoot-page-ui/code/code-summary.md new file mode 100644 index 0000000..26d938f --- /dev/null +++ b/aidlc-docs/features/shoot-type-pages/construction/shoot-page-ui/code/code-summary.md @@ -0,0 +1,229 @@ +# Code Summary — Unit 2: Shoot page UI + +Plan: [shoot-page-ui-code-generation-plan.md](../../plans/shoot-page-ui-code-generation-plan.md). Branch `feature/shoot-type-pages`, worktree `AndreaSlopFotografie-shoot-type-pages`. Unit 1 is the content and SEO foundation (commit `e5f4348`). Unit 3 (navigation submenu) is built in the same worktree and is described in [navigation-submenu/code/code-summary.md](../../navigation-submenu/code/code-summary.md); its files are not described here. + +## Status +- Steps 1–22 and 26 done (checked in the plan), except Step 23, which is open. Step 1 made no edits. The owner approved the five OG crops on 2026-10-30 (audit log, 12:49 UTC); Steps 19 and 20 followed that approval. +- Step 23 (Lighthouse): **open**, a known item, see [Lighthouse](#lighthouse-step-23--open). Desktop passes everywhere; mobile performance misses the budget on the loveshoot page (0.83) and the gezin page (0.84, then 0.85 on three re-runs). The owner decided on 2026-10-30 to keep the first-story fade-in for now (`open — owner keeps fade-in (2026-10-30)`). +- Step 24 (this summary) and Step 25 (reverse-engineering lines) done. Step 27 (hand-back) is the orchestrator's. +- Gates (Step 22): lint, format:check, `tsc` and `pnpm build` clean; `audit:deps` clean (`seroval@1.7.3`); `audit:dev` exit 0 (22 dev advisories, non-blocking under NFR-SEC-05, as on master). `pnpm test`: 113 files, 883 tests, seed 1191455385, coverage thresholds pass (100 % for `src/lib/**`). +- After Step 26 (the `aria-current` facet): 113 files, 888 tests, seed 1757660570, lint and format:check clean. + +## Commits +- Units 2 and 3 with FR-ST-14 are in commit `7af2069` ("Adds the shoot page layout and the shoot-type submenu") on `feature/shoot-type-pages`, after unit 1's `e5f4348`. The audit log records the push and the test deploy (CI run 586: check and deploy-test green). +- This summary and the reverse-engineering edits of Step 25 are **not committed**. A further commit is made only when the user asks. + +## Files + +### Created (unit 2) +- Components (each with a `.test.tsx`): + - `web/src/components/Breadcrumb/Breadcrumb.tsx`: "Kruimelpad" nav with the current page as `aria-current="page"` + - `web/src/components/ProcessTimeline/ProcessTimeline.tsx`: "Zo werkt het" ordered list, alternating text above and below the line from `lg` + - `web/src/components/PhotoMosaic/PhotoMosaic.tsx`: photo grid, up to four tiles, not interactive + - `web/src/components/FaqList/FaqList.tsx`: native `details`/`summary` list, all items closed at load + - `web/src/components/PackageBlock/PackageBlock.tsx`: package block (price and features) or the on-request variant + - `web/src/components/shoots/StoryBlocks/StoryBlocks.tsx`: one `PageSection` per story + - `web/src/components/shoots/ProcessIcons/ProcessIcons.tsx`: the six process icons as inline SVG +- Lib (each with a `.test.ts`, 100 % coverage): + - `web/src/lib/headingId.ts`: safe id from prefix and id (BR-SP-72) + - `web/src/lib/readMoreLabel.ts`: "Lees meer over de …" label per shoot + - `web/src/lib/mosaicLayout.ts`: tile positions for 0–4 photos (`MOSAIC_MAX_PHOTOS = 4`) + - `web/src/lib/storyLayout.ts`: tone, spacing, side and media ratio per story (1.2 threshold) + - `web/src/lib/shootPageBands.ts`: the section order of the page (`SectionBand`) + - `web/src/lib/isShootSectionPath.ts`: pathname under `/soorten-fotoshoots/` (FR-ST-14); its test is property-based +- Route test: `web/src/shootPages.test.tsx` (34 tests): outline, sections, breadcrumb, `aria-current`, package variants, priority photo, overview links, OG registry, axe on the five pages +- Assets: `web/public/og-newborn.jpg`, `og-zwangerschap.jpg`, `og-gezin.jpg`, `og-loveshoot.jpg`, `og-portret.jpg` (see [OG images](#og-images)) + +### Modified (unit 2) +- `web/src/components/PageIntro/PageIntro.tsx` (+ test): optional `titleId` (the section's `aria-labelledby`) and `breadcrumb`; callers without them render unchanged +- `web/src/components/MediaText/MediaText.tsx` (+ test): `mediaSize` accepts `'medium'` (photo column up to 30rem) +- `web/src/components/CallToAction/CallToAction.tsx` (+ test): optional `tone` (default `alt`, so the overview is unchanged) +- `web/src/components/shoots/ShootPage/ShootPage.tsx` (+ test): the sections in `shootPageBands` order; wrapper `data-testid="shoot-page"`; no content imports, no state +- `web/src/components/shoots/ShootBlock/ShootBlock.tsx` (+ test) and `ShootList.test.tsx`: "Lees meer over de …" link first in the row, to `/soorten-fotoshoots/` +- `web/src/components/StatusPage/NotFound.tsx` (+ `StatusPage.test.tsx`): under `/soorten-fotoshoots/` two buttons, "Terug naar Soorten fotoshoots" and "Terug naar home" (FR-ST-14, decided by `isShootSectionPath`) +- `web/src/sitePages.ts`: an `ogImage` on each of the five shoot entries (`path`, 1200 × 630, Dutch `alt`) +- `web/src/app.test.tsx`: one assertion now reads `sitePages[path].ogImage!.path` for the shoot page `og:image` (file outside unit 2's table, approved in the plan) +- `web/src/test/arbitraries.ts`: appended only: one import line (`shootPageView`) and four generators (`imageWithOrientation`, `mosaicCount`, `timelineSteps`, `shootPageViewArb`) +- `LAYOUT.md`: section "Shoot page" after "Types of shoots" (Step 21, FR-ST-13) +- `.ai/layout-conventions.md`: template colours for blocks H, I, J; "ten letters (A–J)" + +### Not touched by unit 2 +Content modules (`web/src/content/*`), route files (`routes/soorten-fotoshoots/*`), `routeTree.gen.ts` (no diff after the build), `config/securityHeaders.ts`, `package.json`, `pnpm-lock.yaml`, `theme.ts`, and unit 3's files (`navigation.ts`, `NavigationBar/*`, `Footer/*`, `hooks/*`, `lib/navMenuState.ts`, `lib/shootNavItems.ts`, `lib/navCurrent.ts`, `navSubmenu.test.tsx`). + +## Interfaces +- `shootPageBands(view: ShootPageView): SectionBand[]` (`lib/shootPageBands.ts`): `SectionBand { id, tone, position }`; ids `story-`, `process`, `photos`, `faq`, `offer`, `closing` +- `storyLayout(stories): StoryLayout[]` (`tone`, `spacing`, `reverse`, `priority`, `media?`) +- `mosaicLayout(count): MosaicTile[]` (`column`, `row`, `wide`, `phoneRatio`); `MOSAIC_MAX_PHOTOS = 4` +- `headingId(prefix, id): string`; `readMoreLabel(shoot): string`; `isShootSectionPath(pathname): boolean` +- Component props: + - `Breadcrumb({ label, items, data-testid? })` + - `ProcessTimeline({ steps: { id, title, text, icon? }[], tone?, data-testid? })` + - `PhotoMosaic({ images, data-testid? })` + - `FaqList({ items, data-testid? })` + - `PackageBlock({ titleId, eyebrow, title, image, frameColor?, pkg?, onRequest: { price, text }, note?, children, data-testid? })` + - `StoryBlocks({ stories, frameColor, idPrefix })` + - `ProcessIcons`: `processIcons: Record JSX.Element>` + - `PageIntro` (+ `titleId?`, `breadcrumb?`), `MediaText` (`mediaSize: 'medium'`), `CallToAction` (+ `tone?`) + - `ShootPage({ view })`: unchanged +- Registry: `sitePages[shootPagePath(id)].ogImage = { path: '/og-.jpg', width: 1200, height: 630, alt }` +- Test ids for the orchestrator and the browser checks: `shoot-page`, `shoot-breadcrumb`, `story-`, `process-timeline`, `photo-mosaic`, `faq-list`, `package-block`, `shoot-closing`, `shoot--readmore` (overview), `status-page-section-link` and `status-page-home-link` (NotFound) + +## Requirement and business-rule coverage +| Requirement / rule | Where | Tests | +|---|---|---| +| FR-ST-02 Intro with breadcrumb | `PageIntro` (`titleId`, `breadcrumb`), `Breadcrumb.tsx`, `ShootPage.tsx` | `Breadcrumb.test.tsx` (PBT), `PageIntro.test.tsx`, `ShootPage.test.tsx`, `shootPages.test.tsx` | +| FR-ST-03 Story blocks | `StoryBlocks.tsx`, `storyLayout.ts`, `MediaText` (`medium`) | `StoryBlocks.test.tsx`, `storyLayout.test.ts` (PBT), `MediaText.test.tsx`, `shootPages.test.tsx` | +| FR-ST-04 Process timeline | `ProcessTimeline.tsx`, `ProcessIcons.tsx` | `ProcessTimeline.test.tsx` (PBT), `ProcessIcons.test.tsx`, `shootPages.test.tsx` | +| FR-ST-05 Photo mosaic | `PhotoMosaic.tsx`, `mosaicLayout.ts` | `PhotoMosaic.test.tsx` (PBT), `mosaicLayout.test.ts` (PBT), `shootPages.test.tsx` (3 tiles on Newborn, none elsewhere) | +| FR-ST-06 FAQ | `FaqList.tsx` | `FaqList.test.tsx` (PBT, keyboard via click), `shootPages.test.tsx` | +| FR-ST-07 Package block | `PackageBlock.tsx`, `ShootPage.tsx` (variant by `view.offer.pkg`) | `PackageBlock.test.tsx`, `shootPages.test.tsx` (price and on-request variants) | +| FR-ST-08 Closing call to action | `CallToAction.tsx` (`tone`), `ShootPage.tsx` | `CallToAction.test.tsx`, `shootPages.test.tsx` (tone differs from the package band) | +| FR-ST-09 Overview "Lees meer" | `ShootBlock.tsx`, `readMoreLabel.ts` | `readMoreLabel.test.ts` (PBT), `ShootBlock.test.tsx`, `ShootList.test.tsx`, `shootPages.test.tsx` (one link per shoot) | +| FR-ST-13 LAYOUT.md | `LAYOUT.md`, `.ai/layout-conventions.md` | documentation only, no automated test | +| FR-ST-14 404 under the section (added in the build, not in the plan) | `StatusPage/NotFound.tsx`, `lib/isShootSectionPath.ts` | `isShootSectionPath.test.ts` (PBT), `StatusPage.test.tsx` | +| SEO-ST-04 Semantic structure | `headingId.ts`, `ShootPage.tsx` (one h1, one h2 per section, h3 per step, `aria-labelledby`) | `headingId.test.ts` (PBT), `ShootPage.test.tsx`, `shootPages.test.tsx` (outline) | +| SEO-ST-05 Preview image | `sitePages.ts` (`ogImage`), `web/public/og-.jpg` | `shootPages.test.tsx` (OG registry, `og:image` per shoot), `app.test.tsx` | +| NFR-ST-01 Accessibility | disclosure and nav patterns, 44 px targets, visible focus, reduced motion (`Reveal`), exact `aria-current` | axe in every component test and on the five pages (`shootPages.test.tsx`); keyboard tests in `FaqList` and `Breadcrumb`; Lighthouse accessibility 1.0 on all pages | +| NFR-ST-02 Reuse and responsive | shared blocks (`PageSection`, `MediaText`, `CallToAction`, `RichParagraph`, `Eyebrow`, `SectionHeading`, `FramedImage`, `DeferredImage`, `Reveal`, `LinkButton`) | component tests at phone and `lg` props | +| NFR-ST-03 Performance | `StoryBlocks` (only story 0 is priority), `PhotoMosaic` and the other photos via `DeferredImage`, code splitting by route | `shootPages.test.tsx` (priority photo not lazy, others not eager); Step 22 bundle check; Lighthouse (open, see below) | +| NFR-ST-05 Security | `headingId` (BR-SP-72), typed router links, no `dangerouslySetInnerHTML` | `headingId.test.ts` (hostile strings), grep checks in Step 22 | +| NFR-ST-06 Testing (PBT + examples) | PBT list in [business-rules.md § 3](../../shoot-page-ui/functional-design/business-rules.md); generators in `test/arbitraries.ts` | see Test results | +| NFR-ST-07 Coordination | ownership table, no edits outside unit 2 except `app.test.tsx` (one assertion) | Step 22 `git status` and diff checks | +| BR-SP-01, 02, 04 Breadcrumb items, separators, empty and one-item cases | `Breadcrumb.tsx` | `Breadcrumb.test.tsx` (PBT: 1–5 items) | +| BR-SP-03 Exact matching, 44 px, underline | `Breadcrumb.tsx` (`activeOptions={{ exact: true }}`) | `Breadcrumb.test.tsx`, `shootPages.test.tsx` (aria-current facet) | +| BR-SP-05 `PageIntro` props | `PageIntro.tsx` | `PageIntro.test.tsx` (existing markup unchanged) | +| BR-SP-10, 13 Story sections, text-only stories | `StoryBlocks.tsx` (Q4 = A: no frame, column of at most 36rem) | `StoryBlocks.test.tsx` (Newborn and Loveshoot) | +| BR-SP-11, 12, 14 Tone, side, ratio, priority | `storyLayout.ts`, `shootPageBands.ts`, `MediaText.tsx` | `storyLayout.test.ts` (PBT, boundaries 1.19 and 1.2), `shootPageBands.test.ts` (PBT) | +| BR-SP-20–26 Timeline structure, layout, line, markers, motion, any count | `ProcessTimeline.tsx` | `ProcessTimeline.test.tsx` (PBT: 1–8 steps; zero steps; last marker filled) | +| BR-SP-30a Minimum two photos | `shootPageView` (unit 1), `ShootPage.tsx` | `shootPages.test.tsx` (Zwangerschap, Gezin, Loveshoot, Portret have no mosaic) | +| BR-SP-30b, 31, 35 Maximum four photos, layouts, phone ratios | `PhotoMosaic.tsx`, `mosaicLayout.ts` | `mosaicLayout.test.ts` (PBT: disjoint cells, full 4 × 2 grid for 2–4), `PhotoMosaic.test.tsx` (PBT) | +| BR-SP-32, 33 Object fit, no interaction | `PhotoMosaic.tsx` | `PhotoMosaic.test.tsx` (no `a` or `button`) | +| BR-SP-34 Section head and portfolio link | `ShootPage.tsx` | `ShootPage.test.tsx`, `shootPages.test.tsx` | +| BR-SP-40, 41 Priority photo and deferred others | `StoryBlocks.tsx`, `PhotoMosaic.tsx` (`DeferredImage`) | `StoryBlocks.test.tsx`, `shootPages.test.tsx` | +| BR-SP-42 Bundled photos only | content imports, `public/` OG files | Step 22 grep (no remote image) | +| BR-SP-50–53 FAQ closed at load, summary, answers in the DOM | `FaqList.tsx` (no `open`, no state) | `FaqList.test.tsx` (PBT: 0–6 items, no `open`), keyboard test | +| BR-SP-60–62 Package variant, deposit note, image | `PackageBlock.tsx`, `ShootPage.tsx` | `PackageBlock.test.tsx`, `shootPages.test.tsx` | +| BR-SP-63 Closing band tone | `CallToAction.tsx`, `ShootPage.tsx` | `CallToAction.test.tsx`, `shootPages.test.tsx` | +| BR-SP-64 Overview link | `ShootBlock.tsx`, `readMoreLabel.ts` | `ShootBlock.test.tsx`, `ShootList.test.tsx`, `shootPages.test.tsx` | +| BR-SP-70 Page order and alternating tones | `shootPageBands.ts`, `ShootPage.tsx` | `shootPageBands.test.ts` (PBT), `ShootPage.test.tsx` (no equal adjacent tones) | +| BR-SP-71, 73 Heading outline, section anchors | `ShootPage.tsx`, `PageSection` (`id`) | `ShootPage.test.tsx`, `shootPages.test.tsx` (anchors `zo-werkt-het`, `impressie`, `vragen`, `pakket`) | +| BR-SP-72 Safe ids | `headingId.ts` | `headingId.test.ts` (PBT, hostile strings) | +| BR-SP-74 Props only, no content imports, fail-safe | every component | each component test (empty input omits the part) | +| BR-SP-80, 81 OG images and alt | `sitePages.ts`, `web/public/og-.jpg` | `shootPages.test.tsx` (path, size, file, SOF marker, at most 150 KB, unique paths), `app.test.tsx` | +| BR-SP-90 LAYOUT.md section | `LAYOUT.md`, `.ai/layout-conventions.md` | documentation (Step 21), no test | + +## Test results +- Step 22 (before the Step 26 facet): `pnpm test` 113 files, 883 tests, all pass; seed 1191455385; coverage thresholds pass. +- Step 26 (after the `aria-current` facet): 113 files, 888 tests, all pass; seed 1757660570. Lint and format:check clean. +- `src/shootPages.test.tsx`: 34 tests at the end of the unit (23 at Step 18, plus the OG registry tests of Step 20 and the five `aria-current` tests of Step 26). +- Fast-check seed from `config/testSeed.ts`, logged each run; shrinking untouched. +- No new test helper beyond the generators appended to `test/arbitraries.ts`. + +## Bundle check (Step 22, NFR-ST-03) +- Main chunk `index-C65n6UdK.js`: 536.65 kB raw / 152.56 kB gzip. Unit 1 baseline: 528.98 kB / 150.69 kB. Delta: +7.67 kB raw, **+1.87 kB gzip** (unit 3's `shootTypes` data is in this delta, see its summary; unit 2's shared-component changes are small). +- The strings "Kruimelpad", "Zo werkt het", `process-title`, `faq-title` and `offer-title` are in the route chunk `-shootPageSources-*.js` only, not in the main chunk. "Uit eerdere newbornshoots" is in `newborn-*.js` only. +- The five OG JPEGs are in `dist/` (copied from `public/`), 88.9–97.6 KB each as listed in the worktree. +- `routeTree.gen.ts`: no diff. No route file added. `package.json`, the lockfile and `securityHeaders.ts`: no diff. +- `DRAFT(CON-ST-03)` count: 98, unchanged from unit 1 (unit 2 adds no drafts). +- Security greps (Step 22): `dangerouslySetInnerHTML` only in `components/StructuredData/` (pre-existing); the one `console.error` is in the pre-existing `ErrorPage.tsx`; no new e-mail address or `mailto:`; no design placeholders; no hard-coded hex or `rgb(` in the new components. + +## Lighthouse (Step 23) — open +Build of Step 22 (units 1, 2 and 3), `lhci autorun` for mobile (exits 1 on the assertions) and `lhci autorun --config=lighthouserc.desktop.cjs` for desktop, one run per URL; shoot pages re-measured with three runs. Port 4173 released afterwards. Owner decision (2026-10-30, audit log): **keep the fade-in on the first story for now**. + +| Page | Mobile performance (unit 1 in brackets) | Budget | Status | +|---|---|---|---| +| `/` | 0.75 (0.76) | 0.8 | below budget (master 0.78) | +| `/contact` | 0.87 (0.85) | 0.9 | below budget (master 0.87) | +| `/over-mij` | 0.87 | — | no failure recorded | +| `/portfolio` | 0.91 | — | no failure recorded | +| `/soorten-fotoshoots` | 0.85 | — | no failure recorded | +| `/soorten-fotoshoots/newborn` | 0.86 (0.90) | 0.85 | pass | +| `/soorten-fotoshoots/zwangerschap` | 0.85 (0.90) | 0.85 | pass | +| `/soorten-fotoshoots/gezin` | 0.84, then 0.85 × 3 (0.90) | 0.85 | borderline | +| `/soorten-fotoshoots/loveshoot` | 0.83 × 3 (0.90) | 0.85 | **below budget** | +| `/soorten-fotoshoots/portret` | 0.85 (0.90) | 0.85 | pass | +| `/privacyverklaring` | 0.90 | — | no failure recorded | +| `/bestaat-niet` | 0.92 | — | no failure recorded | + +- Desktop performance 0.99–1.00 on every page (shoot pages 0.99; budget 0.9). Accessibility and best practices 1.0 on all 12 URLs, mobile and desktop. SEO 1.0 on the indexed pages (0.58 for `/bestaat-niet` and 0.69 for `/privacyverklaring` are the expected noindex values). +- Diagnosis: the first story photo is not the bottleneck (153 KB on loveshoot and 117 KB on gezin, loaded in 15–24 ms). LCP is 3.7–3.8 s with a render delay of about 2.9–3.0 s; FCP is 2.6 s on every page. The photo is painted only after the main bundle has run, which matches the `photoPagePaths` comment in `lighthouserc.cjs`. The shoot pages dropped 0.05–0.07 from unit 1's shell-only numbers, because the first story now renders through `MediaText` and `Reveal` inside the lazy route chunk. +- Mitigations the plan lists, none applied: (1) first story without the `Reveal` fade-in, (2) fewer pixels for the first photo by capping its column, (3) report and keep the known limit. The owner chose to keep the fade-in; the item stays open and is to be revisited in Build and Test or a follow-up. + +## OG images +- Five JPEGs, 1200 × 630, sRGB, no EXIF or ICC profile, re-encoded from a fresh bitmap by a throw-away `System.Drawing` script kept outside the repository (no image tool or dependency in `web/`). +- Sources and crops (plan Step 2; the Gezin source is corrected from the design table): + +| Shoot | Source | Crop | Note | +|---|---|---|---| +| Newborn | `web/src/assets/portfolio/f41a4650-groot.jpg` (baby fist) | 1600 × 840 from 1600 × 1067, scaled down | | +| Zwangerschap | `web/src/assets/portfolio/f41a8206-groot.jpg` (belly in black dress) | 1600 × 840, scaled down | | +| Gezin | `web/src/assets/portfolio/f41a7138-groot.jpg` (parents with sleeping baby) | 1067 × 560 from 1067 × 1600, scaled up about 1.12× | not `f41a1579`, which is the photo of `og-portfolio.jpg` | +| Loveshoot | `web/src/assets/shoots/loveshoot.jpg` | 848 × 445 from 848 × 1060, scaled up about 1.42× | upscaled, soft; no landscape photo exists yet | +| Portret | `web/src/assets/shoots/portret.jpg` | 848 × 445 from 848 × 1060, scaled up about 1.42× | upscaled | + +- Vertical offsets were chosen by looking at each photo (faces and hands inside the crop); the offsets are not recorded in the plan. +- Approved as produced by the owner on 2026-10-30 (audit log, 12:49 UTC), together with the contact sheet in the scratchpad. +- Alt texts are the alt texts of the source photos (Dutch), as in `sitePages.ts`. + +## Deviations from the plan +- **`mosaicLayout` first tile**: for counts 2 to 4 the first tile is `1 / 3` × `1 / 3` (the table gives count 1, which is never shown, `1 / 5`). +- **`ProcessTimeline` subgrid**: `gridTemplateRows: subgrid` from `lg` without an `@supports` fallback, because a nested `@supports` rule cannot be expressed with Chakra style props. All current browsers support subgrid. +- **`FaqList` keyboard test**: jsdom and user-event do not turn Enter or Space on a `summary` into the click that toggles `details`, so the test checks focusability, `summary` as the first child, and the toggle on activation (click). +- **Package and closing buttons**: `Box asChild` with the `linkButton` recipe around the router's own `Link`, as `PriceCard` does, because `LinkButton` loses the typed `search` of the router link. +- **`ShootPage` wrapper testid**: `data-testid="shoot-page"` sits on the outer `Box` of the page. +- **Intro and first story**: both `paper` on purpose (the first story is `flushTop`); from the first story on the bands alternate. +- **`test/arbitraries.ts`**: one import line added (`shootPageView`); the rest is append only. +- **Gezin OG source**: `f41a7138-groot` instead of the design table's `f41a1579` (see OG images). +- **`app.test.tsx`**: one assertion changed (Step 19), the only edit outside unit 2's ownership table. +- **FR-ST-14** (404 under `/soorten-fotoshoots/`): added after the plan was written. `NotFound` offers "Terug naar Soorten fotoshoots" and "Terug naar home" under that path; `isShootSectionPath` is case-insensitive like the router. +- **Breadcrumb links** keep `{ exact: true }` (Step 9). Unit 3 added `includeSearch: false` to the nav and footer links only. +- **`aria-current` rule** (Step 26): see below. +- **Lighthouse mitigation**: not applied (owner decision). + +## Design E comparison (Step 17, by reading the design) +- Section order (intro, four stories, process, photos, FAQ, offer, closing), eyebrows and the side alternation of the photos match design E. The check was done by reading, not in a browser. +- Differences on purpose: the FAQ items all start closed (Q5 = C; design E has two open); the intro and the first story are both `paper`. +- The bracketed placeholders of design E are not copied into the visible text. + +## Interfaces left for the orchestrator +- Unit 3 imports nothing from unit 2; unit 2 imports nothing from unit 3. +- `shootPageBands` is the single source of the section order; `ShootPage` renders it. +- `PageIntro` `titleId` and `breadcrumb` are optional; existing callers are unchanged. +- `NotFound` depends on `lib/isShootSectionPath.ts`; the FR-ST-14 pair is not part of the plan's ownership table. +- The OG images are not yet listed in the plan's requirement-to-file table (they are in this summary). + +## Open items +- **Lighthouse (Step 23)**: open, see above; owner keeps the fade-in (2026-10-30). +- **Case-variant URL**: `/soorten-fotoshoots/Newborn` renders the page (the router matches case-insensitively), but no link carries `aria-current` (exact matching). The parent keeps its section marker through `isSectionCurrent`. Accepted for now; the case-sensitive routing decision stays with the orchestrator (unit 1). +- **seroval advisory**: resolved on master by PR #12 (`seroval@1.7.3`); `audit:deps` passes. +- **`audit:dev`**: 22 dev advisories, non-blocking under NFR-SEC-05, as on master. + +## aria-current decision (Step 26) +Unit 3's final markup gives each shoot page exactly three `aria-current="page"` elements: +1. the breadcrumb's last item (in `main`); +2. the header submenu link to the shoot page; +3. the mobile-menu sub-link to the shoot page (`#mobile-nav` is a sibling of the header; only one of the two menus is visible at a time). + +The parent "Soorten fotoshoots" links (header and mobile menu) and the footer link are never current. The rule is therefore: exactly one in `main`, exactly one in each menu, none in the footer, and none on the parents. Recorded in `shootPages.test.tsx` (one test per shoot). + +## Security and PBT compliance (final) +| Rule | Status | Evidence | +|---|---|---| +| SECURITY-04 HTTP headers | Compliant | `config/securityHeaders.ts` unchanged; no inline script or handler; no new external resource (Step 22 diff) | +| SECURITY-05 Input validation | Compliant | No input or search parameter added; ids in markup go through `headingId`; link targets are typed routes or derived by `shootContactLink` and `shootPagePath`; `isShootSectionPath` only compares | +| SECURITY-09 Hardening | Compliant | No debug output, no placeholders, no sample content (Step 22 greps); OG crops are the site's own photos | +| SECURITY-10 Supply chain | Compliant | No dependency added; lockfile and `package.json` unchanged; cropping done by a script outside the repository; `audit:deps` passes (`seroval@1.7.3`) | +| SECURITY-11 Secure design | Compliant | Content is text and typed router links (`RichParagraph`); no `dangerouslySetInnerHTML` in unit 2 files; no e-mail address or `mailto:` in new files | +| SECURITY-13 Integrity | Compliant | Only bundled photos and `public/` OG images; no CDN or embed; SVG icons inline | +| SECURITY-15 Fail-safe | Compliant | Every component omits itself or its part on empty input; `headingId` safe for any string; fewer photos than the minimum means no mosaic; `NotFound` shows the section buttons only under the section path | +| SECURITY-01, -02, -03, -06, -07, -08, -12, -14 | N/A | No data store, intermediary, server code, IAM, network, auth or alerting | +| PBT-01 Identification | Compliant | Properties per helper and component as in business-rules.md § 3 (Steps 3–13) and `isShootSectionPath` | +| PBT-02 Round trip | N/A | No parse/serialise or encode/decode pair (`headingId` is not reversed) | +| PBT-03 Invariants | Compliant | `headingId`, `readMoreLabel`, `mosaicLayout`, `storyLayout`, `shootPageBands`, `isShootSectionPath`, and the component properties (Breadcrumb, ProcessTimeline, PhotoMosaic, FaqList, StoryBlocks) | +| PBT-04 Idempotency | N/A | No operation with an idempotency contract (FAQ and timeline are stateless) | +| PBT-05 Oracle | N/A | No reference implementation | +| PBT-06 Stateful | N/A | No application state: FAQ state belongs to the browser | +| PBT-07 Generators | Compliant | Four generators appended to `test/arbitraries.ts`; unit 1's generators reused | +| PBT-08 Shrinking and reproducibility | Compliant | Seed from `config/testSeed.ts`, logged; seeds 1191455385 (Step 22) and 1757660570 (Step 26); shrinking untouched | +| PBT-09 Framework | Compliant | fast-check already a dependency | +| PBT-10 Complementary | Compliant | Example tests next to every property (keyboard, focus, boundaries, empty input, axe); PBT tests carry "(invariant)" in the name |