Records the review changes of the Soorten fotoshoots page
Continuous Integration / deploy-test (pull_request) Canceled after 0s
Continuous Integration / lighthouse (pull_request) Canceled after 0s
Continuous Integration / deploy-production (pull_request) Canceled after 0s
Continuous Integration / check (pull_request) Canceled after 7m35s
Continuous Integration / deploy-test (pull_request) Canceled after 0s
Continuous Integration / lighthouse (pull_request) Canceled after 0s
Continuous Integration / deploy-production (pull_request) Canceled after 0s
Continuous Integration / check (pull_request) Canceled after 7m35s
Texts approved, photos smaller with detail photos and alternating bands, the final verification, and the audit trail of the review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
+15
-3
@@ -23,9 +23,21 @@ Plan: [soorten-fotoshoots-page-code-generation-plan.md](../../plans/soorten-foto
|
||||
- **Lighthouse mobile threshold for photo pages** (user's choice): `/over-mij` and `/soorten-fotoshoots` get mobile performance 0.85 (desktop stays 0.9), documented in `lighthouserc.cjs`. Measured: both pages land on LCP 3.22 s and a score of ~0.897 in Lighthouse's simulated mobile load (FCP 0.72, LCP 0.72, TBT 0.99, CLS 1); fewer image bytes did not change the LCP; the cause is the main bundle plus the page chunk before the image is requested (NFR-P-01). Tried and reverted: no fade-in for the priority photo (no measurable effect).
|
||||
- **Homepage mobile** sits at 0.77–0.80 against its 0.8 threshold (already 0.80 in unit 1); a run at 0.69 was taken while the machine ran at half speed (Lighthouse benchmarkIndex 1909 instead of ~4200).
|
||||
|
||||
## Open for Andrea (merge waits for this, BR-SF-17)
|
||||
- The Gezin text (draft) and the five alt texts (see unit 1's code summary), reviewed on the test environment.
|
||||
## Review changes (after the first deploy to test)
|
||||
- **Texts approved** by the owner (Gezin text and alt texts), so BR-SF-17 is met.
|
||||
- **Smaller photos and a collage** at the owner's request ("te groot", "saai"): `MediaText` gets `mediaSize: 'half' | 'small'` (default `half`, so the homepage and Over mij are unchanged) and an optional `detailImage`. The shoot blocks use `small`: a 28rem photo column with the main photo (72%) and a square detail photo overlapping its lower right corner; the text (max 36rem, ~70 characters a line) is centred between the photos and the edge from `lg`.
|
||||
- **Bands**: every shoot sits in its own full-width band alternating `paper` / `paper.alt` (replaces the hairlines).
|
||||
- **Detail photos** (480×480, `web/src/assets/shoots/{id}-detail.jpg`), approved by the owner:
|
||||
- Newborn: `2026/04/F41A7284_websize.jpg`, "Babyvoetjes die onder een gestreept gebreid pakje uitsteken"
|
||||
- Zwangerschap: `2019/11/F41A9474_websize.jpg`, "Een zwangere vrouw in een lichte jurk houdt haar buik vast op een zandvlakte in de avondzon"
|
||||
- Gezin: `2019/11/F41A1579_websize-1.jpg`, "Een jongetje geeft de pasgeboren baby een kus op het bed"
|
||||
- Loveshoot: `2025/09/IMG_2497-5.jpg`, "Een man schuift een ring om de vinger van zijn partner, met paarse heide op de achtergrond"
|
||||
- Portretten: `web/src/assets/hero-4.jpg` (owner's choice), "Een vrouw met lang blond haar in een jurk met bloemenprint houdt een takje heide vast op de heide"
|
||||
- `ShootType` gets an optional `detailImage` (additive; announced to portfolio-page).
|
||||
- The route test now expects the five portfolio links when `/portfolio` is indexed and none otherwise, so it stays green when the portfolio page goes live.
|
||||
- No second deploy to test (owner's decision).
|
||||
|
||||
## Verification
|
||||
- **`pnpm check`**: lint, Prettier, 65 test files / 322 tests (coverage thresholds met), build, `audit:deps` clean (`audit:dev` 17 findings in dev tooling, non-blocking per NFR-SEC-05). Lighthouse (after a PC restart interrupted the first full run, rerun on the same build): all assertions passed. Mobile performance: `/` 0.80, `/over-mij` 0.90, `/soorten-fotoshoots` 0.89, others 0.94; desktop 1.0 everywhere; accessibility and best practices 1.0 on every page; SEO 1.0 on the indexed pages.
|
||||
- **After the review changes** (final): `pnpm check` passed: 65 test files / 325 tests, build, audits, Lighthouse mobile (`/` 0.80, `/over-mij` 0.91, `/soorten-fotoshoots` 0.89, others 0.94–0.95) and desktop (0.99–1.0), accessibility and best practices 1.0 everywhere. Screenshots of each layout step sent to the owner.
|
||||
- **First version**: `pnpm check`: lint, Prettier, 65 test files / 322 tests (coverage thresholds met), build, `audit:deps` clean (`audit:dev` 17 findings in dev tooling, non-blocking per NFR-SEC-05). Lighthouse (after a PC restart interrupted the first full run, rerun on the same build): all assertions passed. Mobile performance: `/` 0.80, `/over-mij` 0.90, `/soorten-fotoshoots` 0.89, others 0.94; desktop 1.0 everywhere; accessibility and best practices 1.0 on every page; SEO 1.0 on the indexed pages.
|
||||
- **Visual check** (production build via `vite preview` on port 4180, headless Chrome with `puppeteer-core`, reduced motion): `/soorten-fotoshoots` at 1440, 820 and 390 px against `design/andreaslop-static/soorten-fotoshoots.html` at 1440 px. Structure, order, alternation, dividers, closing block and footer match. Known differences, both deliberate: the content column is the site-wide width (same as the homepage and Over mij), and section headings are 30 px instead of the design's 2.5rem (theme `sectionTitle`, owner's earlier request). On phones the photo sits above the text and the coloured block is hidden. `#zwangerschap` lands exactly below the fixed header (article top 68 px = header bottom 68 px). Screenshots sent to the user.
|
||||
|
||||
Reference in New Issue
Block a user