Adds the Lieve woorden section to the homepage
Shows client reviews one at a time with the framed photo, a large quotation mark, the shoot type and the names. Uses Chakra's carousel for paging, looping and swiping with our own controls, so visitors who prefer reduced motion get instant changes, and loads the carousel only when the section comes near the screen so the hero does not wait for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,44 @@
|
||||
# Code Summary — Unit 4: Lieve woorden
|
||||
|
||||
Plan: [lieve-woorden-code-generation-plan.md](../../plans/lieve-woorden-code-generation-plan.md). Functional design: [../functional-design/](../functional-design/). Branch: `feature/homepage-sections`.
|
||||
|
||||
## Files
|
||||
|
||||
### Created
|
||||
| File | Purpose |
|
||||
|---|---|
|
||||
| `web/src/assets/home/review-trouwshoot.jpg`, `review-newbornshoot.jpg` | Live photos, centre-cropped to 4:5, 880×1100, ±100 KB |
|
||||
| `web/src/content/testimonials.ts` | The two live reviews |
|
||||
| `web/src/lib/visibleTestimonials.ts` + test | Invariants filter, first-wins de-duplication (BR-REV-01) |
|
||||
| `web/src/lib/slideLabel.ts` + test | "Review n van m" (BR-REV-08/09) |
|
||||
| `web/src/recipes/carouselControl.ts` | Arrow and dot buttons under a carousel |
|
||||
| `web/src/components/home/Testimonials/Testimonials.tsx` + test | The section; heading always rendered; carousel loaded when near the screen |
|
||||
| `web/src/components/home/Testimonials/TestimonialCarousel.tsx` | Chakra `Carousel` (Zag) with our own controls and live region; separate chunk |
|
||||
| `web/src/components/home/Testimonials/TestimonialSlide.tsx` + test | One review: framed photo, quotation mark, shoot, quote, names |
|
||||
|
||||
### Modified
|
||||
| File | Change |
|
||||
|---|---|
|
||||
| `web/src/content/types.ts`, `homeContent.ts` | `Testimonial`; `HomeContent.testimonials` |
|
||||
| `web/src/theme.ts` | Registers `carouselControl` |
|
||||
| `web/src/test/arbitraries.ts` | `testimonial`, `uniqueTestimonials`, `anyTestimonial` |
|
||||
| `web/src/test/setup.ts` | No-op `ResizeObserver` (jsdom lacks it; the carousel needs it) |
|
||||
| `web/src/routes/index.tsx` | Renders `Testimonials` after `Pricing` |
|
||||
| `web/src/app.test.tsx` | "Lieve woorden" in the page order; stubs `IntersectionObserver` and `Element.scrollTo` for the carousel |
|
||||
|
||||
## Decisions and fixes during generation
|
||||
- **Own controls for reduced motion** (plan finding 1): Zag's built-in triggers, dots and keys scroll smoothly from JavaScript; ours pass `instant` when the visitor prefers reduced motion. Verified in real Chrome: normally the slide moves over ±330 ms, with reduced motion it is in place in the first frame.
|
||||
- **One announcement** (finding 2): the item group's `aria-live` is off; our polite region says "Review n van m" on each change, nothing on load.
|
||||
- **Slides clipped each other's frame**: the sand block sticks out 1.5 rem left and below the photo, and the item group clips everything outside a slide, so the next slide's block showed over the quote. Fixed with 4 rem `spacing` between slides and 1.5 rem padding left/bottom in each slide (from `sm`).
|
||||
- **Carousel cost on page load**: the carousel in the route chunk lowered home mobile Lighthouse from a median **0.83** (unit 3, 5 runs) to **0.81**; `React.lazy` alone did not help (the chunk still loaded at once). Now the section and heading render immediately, and the carousel chunk loads only when the section comes within 200 px of the screen (same rule as the deferred photos), with a placeholder of the measured height. Median back to **0.83** (LCP 3.84 s).
|
||||
- **Testing approach**: jsdom has no layout, so Zag cannot page there. Unit tests check our wiring (calls to `scrollNext/scrollPrev/scrollTo` with the right `instant`, announcements, labels, loop option, deferred loading); paging, looping, dots and the hidden off-screen slide were checked in real Chrome via the DevTools protocol (next → "Review 2 van 2", next again → back to review 1, dot 2 → review 2).
|
||||
|
||||
## Verification (`pnpm check`)
|
||||
- Lint ✅, Prettier ✅, build ✅ — carousel in its own chunk (`TestimonialCarousel-*.js`, 43 KB raw)
|
||||
- Tests: 42 files, **190 passed**; 100% coverage on the new `lib/` files
|
||||
- Lighthouse home: mobile **0.83** (LCP 3.8 s), desktop **1.0** (LCP 0.8 s); accessibility, best practices, SEO **1.0**
|
||||
- Visual check: 1440 and 390, both reviews
|
||||
|
||||
## Extension compliance
|
||||
- **Security Baseline**: content rendered as text; no new dependencies (Chakra Carousel and Ant Design icons already installed); no external resources. Other rules N/A.
|
||||
- **PBT**: PBT-02 (`slideLabel` round-trip), PBT-03 (invariants), PBT-04 (idempotency), PBT-05 (oracle), PBT-07 (generators), PBT-08/09 (existing), PBT-10 (example tests). PBT-06 N/A — the stateful part is Zag's.
|
||||
+45
@@ -0,0 +1,45 @@
|
||||
# Business Logic Model — Unit 4: Lieve woorden
|
||||
|
||||
## Navigation flow
|
||||
|
||||
```mermaid
|
||||
sequenceDiagram
|
||||
box rgba(246,224,94,0.4) Visitor
|
||||
participant V as Visitor
|
||||
end
|
||||
box rgba(99,179,237,0.4) Testimonials
|
||||
participant C as Carousel
|
||||
participant L as LiveRegion
|
||||
end
|
||||
V->>C: Next button, dot, arrow key or swipe
|
||||
C->>C: Compute target page, looping at the ends
|
||||
C->>C: Scroll to the target slide, instantly under reduced motion
|
||||
C->>L: Page changed to n
|
||||
L-->>V: Announces Review n van m
|
||||
```
|
||||
|
||||
Text alternative: a navigation action makes the carousel compute the target page (looping), scroll to it (instantly under reduced motion) and report the new page to a polite live region, which announces "Review n van m".
|
||||
|
||||
The carousel state (current page, scrolling, dragging, looping) is Chakra's `Carousel` (Ark UI); this unit does not reimplement it. Our own logic is limited to the pure functions below and wiring `onPageChange` to the live region.
|
||||
|
||||
## Pure functions (`web/src/lib/`)
|
||||
|
||||
| Function | Input → output | Rules |
|
||||
|---|---|---|
|
||||
| `visibleTestimonials(items: Testimonial[]): Testimonial[]` | raw list → shown list | BR-REV-01 |
|
||||
| `slideLabel(index: number, count: number): string` | `(1, 2)` → `'Review 2 van 2'` (index is zero-based) | BR-REV-08/09 |
|
||||
|
||||
## Testable properties (PBT-01)
|
||||
|
||||
| Function | Category | Property |
|
||||
|---|---|---|
|
||||
| `visibleTestimonials` | Invariant | Every result meets the invariants; ids unique |
|
||||
| `visibleTestimonials` | Invariant | Result is a subsequence of the input |
|
||||
| `visibleTestimonials` | Idempotency | Applying it twice equals applying it once |
|
||||
| `visibleTestimonials` | Oracle | Valid, unique input comes back unchanged |
|
||||
| `slideLabel` | Round-trip | The two numbers parsed back from the label are `index + 1` and `count` |
|
||||
| `slideLabel` | Invariant | For `0 ≤ index < count` the label has the form `Review n van m` with `1 ≤ n ≤ m` |
|
||||
|
||||
The looping and paging itself is Chakra's (tested upstream); our component tests cover the behaviour at our boundary: loop from last to first, announcement text, controls hidden for one review, nothing rendered for none. PBT-06 (stateful) is N/A because the state machine is not ours.
|
||||
|
||||
Generators (PBT-07) in `src/test/arbitraries.ts`: `testimonial` (valid; slug ids, non-blank texts, image with positive size), `uniqueTestimonials`, `anyTestimonial` (incl. blank quote/author/shoot, empty src, zero size, duplicate ids).
|
||||
+64
@@ -0,0 +1,64 @@
|
||||
# Business Rules — Unit 4: Lieve woorden
|
||||
|
||||
## Rules
|
||||
|
||||
| ID | Rule | Source |
|
||||
|---|---|---|
|
||||
| BR-REV-01 | Only testimonials that meet the invariants are shown; duplicates by id keep the first; order is kept. | domain-entities.md |
|
||||
| BR-REV-02 | No valid testimonial → the section is not rendered. One → it is shown without arrows, dots or carousel semantics. Two or more → carousel. | FR-HP-05 |
|
||||
| BR-REV-03 | One review is visible at a time; there is no autoplay. | FR-HP-05, design Q2 |
|
||||
| BR-REV-04 | Navigation: previous/next buttons, one dot per review, arrow keys when focus is in the carousel, and swiping (and mouse dragging) on the slides. | FR-HP-05 |
|
||||
| BR-REV-05 | At the ends the carousel loops: "next" on the last review goes to the first, "previous" on the first to the last. The buttons are never disabled. | Q1 = A |
|
||||
| BR-REV-06 | A change slides horizontally (the slides lie side by side; a swipe follows the finger). Under `prefers-reduced-motion` the change is immediate, without animation. | Q2 = A |
|
||||
| BR-REV-07 | Every slide has the height of the tallest one, so the page below does not move when the review changes. | Q3 = A |
|
||||
| BR-REV-08 | Every manual change is announced once, politely, as "Review n van m". Nothing is announced on page load. | NFR-HP-01 |
|
||||
| BR-REV-09 | Each slide is labelled "Review n van m"; the buttons are "Vorige review" / "Volgende review"; each dot is "Review n", and the current dot is marked as current. | NFR-HP-01 |
|
||||
| BR-REV-10 | Off-screen slides are hidden from assistive technology and not focusable. | NFR-HP-01 |
|
||||
| BR-REV-11 | The quote is shown as a blockquote with the author as its caption; the large quotation mark is decorative and hidden from assistive technology. | design |
|
||||
|
||||
## Decision flow: what is rendered (BR-REV-01/02)
|
||||
|
||||
```mermaid
|
||||
graph TD
|
||||
In["Testimonials from content"] --> Filter["Keep valid, first of each id"]
|
||||
Filter --> Count{"How many remain?"}
|
||||
Count -->|"none"| Nothing["Section not rendered"]
|
||||
Count -->|"one"| Single["Single review, no controls"]
|
||||
Count -->|"two or more"| Carousel["Carousel with arrows, dots, keyboard and swipe, looping"]
|
||||
|
||||
classDef input fill:#f6e05e,stroke:#c05621,stroke-width:1px,color:#000;
|
||||
classDef decision fill:#63b3ed,stroke:#2b6cb0,stroke-width:1px,color:#000;
|
||||
classDef outcome fill:#9ae6b4,stroke:#2f855a,stroke-width:1px,color:#000;
|
||||
class In,Filter input;
|
||||
class Count decision;
|
||||
class Nothing,Single,Carousel outcome;
|
||||
```
|
||||
|
||||
Text alternative: after filtering, no testimonials means no section, one means a single review without controls, two or more means a looping carousel with arrows, dots, keyboard and swipe.
|
||||
|
||||
## Decision flow: navigation (BR-REV-05/06/08)
|
||||
|
||||
```mermaid
|
||||
graph TD
|
||||
Act["Visitor uses arrow, dot, key or swipe"] --> Target{"Past the last or before the first?"}
|
||||
Target -->|"yes"| Wrap["Wrap around to the other end"]
|
||||
Target -->|"no"| Go["Go to the chosen review"]
|
||||
Wrap --> Motion{"Prefers reduced motion?"}
|
||||
Go --> Motion
|
||||
Motion -->|"yes"| Jump["Switch immediately"]
|
||||
Motion -->|"no"| Slide["Slide horizontally"]
|
||||
Jump --> Say["Announce Review n van m once"]
|
||||
Slide --> Say
|
||||
|
||||
classDef input fill:#f6e05e,stroke:#c05621,stroke-width:1px,color:#000;
|
||||
classDef decision fill:#63b3ed,stroke:#2b6cb0,stroke-width:1px,color:#000;
|
||||
classDef outcome fill:#9ae6b4,stroke:#2f855a,stroke-width:1px,color:#000;
|
||||
class Act input;
|
||||
class Target,Motion decision;
|
||||
class Wrap,Go,Jump,Slide,Say outcome;
|
||||
```
|
||||
|
||||
Text alternative: any navigation action wraps around at the ends, then either switches immediately (reduced motion) or slides, and is announced once as "Review n van m".
|
||||
|
||||
## Misuse considerations (SECURITY-11)
|
||||
Testimonials are static content (later from the CMS) and rendered as text by React; no HTML from content is interpreted.
|
||||
+57
@@ -0,0 +1,57 @@
|
||||
# Domain Entities — Unit 4: Lieve woorden
|
||||
|
||||
## Relationships
|
||||
|
||||
```mermaid
|
||||
graph TD
|
||||
List["Testimonial list"]
|
||||
Item["Testimonial"]
|
||||
Image["ContentImage"]
|
||||
Slide["Carousel slide"]
|
||||
|
||||
List -->|"contains, in display order"| Item
|
||||
Item -->|"has one photo"| Image
|
||||
Item -->|"shown as"| Slide
|
||||
|
||||
classDef entity fill:#2196F3,stroke:#0d47a1,stroke-width:1px,color:#000;
|
||||
classDef value fill:#FF9800,stroke:#e65100,stroke-width:1px,color:#000;
|
||||
classDef ui fill:#9ae6b4,stroke:#2f855a,stroke-width:1px,color:#000;
|
||||
class List,Item entity;
|
||||
class Image value;
|
||||
class Slide ui;
|
||||
```
|
||||
|
||||
Text alternative: the testimonial list holds testimonials in display order; each has one photo and is shown as one carousel slide (blue = data, orange = value, green = UI).
|
||||
|
||||
## Testimonial
|
||||
|
||||
| Field | Type | Required | Description |
|
||||
|---|---|---|---|
|
||||
| `id` | string | yes | Stable, unique key (e.g. `majella-mark`) |
|
||||
| `shoot` | string | yes | Shoot type as a label (e.g. "Trouwshoot") |
|
||||
| `quote` | string | yes | The review text, without quotation marks (the design adds a decorative one) |
|
||||
| `author` | string | yes | Names as they should appear (e.g. "Majella & Mark") |
|
||||
| `image` | ContentImage | yes | Photo for the review, with alt text and size |
|
||||
|
||||
### Invariants
|
||||
- `id` unique within the list.
|
||||
- `shoot`, `quote` and `author` non-empty after trimming.
|
||||
- `image.src` non-empty; `image.width` and `image.height` positive.
|
||||
- List order is the display order.
|
||||
|
||||
Testimonials that break an invariant are skipped; of two with the same id the first is kept (same approach as packages and socials).
|
||||
|
||||
## Initial data (live site, 2026-10-19)
|
||||
|
||||
| id | shoot | author | quote (start) | photo |
|
||||
|---|---|---|---|---|
|
||||
| `majella-mark` | Trouwshoot | Majella & Mark | "Super mooie foto's door Andrea gemaakt op onze trouwdag en pré-wedding shoot. …" | live `IMG_2497-5.jpg` (rings), alt "Bruidegom schuift de trouwring om de vinger van de bruid" |
|
||||
| `demi-kevin` | Newbornshoot | Demi & Kevin | "Heel tevreden met de newbornshoot. …" | live `5-F41A4650-scaled.jpg` (baby's fist), alt "Vuistje van een pasgeboren baby tussen gebreide dekens" |
|
||||
|
||||
Full texts: requirements FR-HP-05.
|
||||
|
||||
## Section content (`HomeContent.testimonials`)
|
||||
|
||||
| Field | Value |
|
||||
|---|---|
|
||||
| `title` | "Lieve woorden" |
|
||||
+49
@@ -0,0 +1,49 @@
|
||||
# Frontend Components — Unit 4: Lieve woorden
|
||||
|
||||
## Hierarchy
|
||||
|
||||
```mermaid
|
||||
graph TD
|
||||
Route["routes/index.tsx"] --> T["home/Testimonials"]
|
||||
T --> Section["HomeSection tone alt"]
|
||||
T --> Heading["SectionHeading"]
|
||||
T --> Root["Carousel.Root loop"]
|
||||
Root --> Group["Carousel.ItemGroup"]
|
||||
Group --> Item["Carousel.Item x n"]
|
||||
Item --> Slide["home/Testimonials/TestimonialSlide"]
|
||||
Slide --> Framed["FramedImage 4 by 5"]
|
||||
Root --> Control["Carousel.Control: Prev, Indicators, Next"]
|
||||
T --> Live["Live region"]
|
||||
Lib["lib: visibleTestimonials, slideLabel"] -.-> T
|
||||
|
||||
classDef root fill:#4CAF50,stroke:#2e7d32,stroke-width:1px,color:#000;
|
||||
classDef ui fill:#2196F3,stroke:#0d47a1,stroke-width:1px,color:#000;
|
||||
classDef logic fill:#9C27B0,stroke:#4a148c,stroke-width:1px,color:#000;
|
||||
class Route root;
|
||||
class T,Section,Heading,Root,Group,Item,Slide,Framed,Control,Live ui;
|
||||
class Lib logic;
|
||||
```
|
||||
|
||||
Text alternative: the home route renders Testimonials, which uses HomeSection, SectionHeading, a looping Chakra Carousel with one item per review (each a TestimonialSlide with a FramedImage) and a control bar with previous, dots and next, plus a live region; pure helpers supply the shown reviews and labels.
|
||||
|
||||
## Testimonials
|
||||
- **Props**: `{ content: HomeContent['testimonials']; testimonials: Testimonial[] }`
|
||||
- **Behaviour**: `visibleTestimonials`; none → `null`; one → the `TestimonialSlide` directly (no carousel); two or more → `Carousel.Root` with `slideCount`, `loop`, `allowMouseDrag`, one slide per page.
|
||||
- **Layout**: `HomeSection` with `tone="alt"`, `data-testid="testimonials"`, centred `SectionHeading`. Controls centred below the slides, margin `clamp(2.5rem, 5vw, 4rem)`.
|
||||
- **Equal height** (BR-REV-07): items stretch in the item group's row, so all slides take the tallest height; content vertically centred within.
|
||||
- **Reduced motion** (BR-REV-06): the item group's scrolling is instant (`scroll-behavior: auto`).
|
||||
- **Announcements** (BR-REV-08): a `VisuallyHidden` polite live region, empty on load, set to `slideLabel(page, count)` in `onPageChange`. Any live region Chakra adds itself is checked so only one announcement is made.
|
||||
- **Controls**: `Carousel.PrevTrigger` / `NextTrigger` with Dutch `aria-label`s and arrow icons from the offline icon set (as the hero), 48 px square, `line` border, `ink` border on hover/focus; `Carousel.Indicator` per page, 44 px hit area around an 8 px dot (`accent.deep` outline, filled when current).
|
||||
- **Test ids**: `testimonials`, `testimonials-prev`, `testimonials-next`, `testimonials-dot-{n}`, `testimonial-{id}`.
|
||||
|
||||
## TestimonialSlide
|
||||
- **Props**: `{ testimonial: Testimonial }`
|
||||
- **Layout**: grid `5fr 7fr` from `lg` with gap `clamp(2rem, 6vw, 5.5rem)`, centred vertically; stacked below `lg` with the photo max 420 px wide.
|
||||
- **Photo**: `FramedImage` with aspect `4 / 5` (the source photos are cropped to 4:5 when prepared).
|
||||
- **Text**: decorative quotation mark (Marcellus, `clamp(5rem, 9vw, 7.5rem)`, `accent`, `aria-hidden`); shoot as eyebrow (`accent.deep`); `figure` > `Blockquote` (Marcellus, `clamp(1.35rem, 2.2vw, 1.75rem)`, line-height 1.5, `ink`) > `figcaption` with "— " + author in small caps (`ink.soft`).
|
||||
|
||||
## Accessibility (NFR-HP-01)
|
||||
- Region named by the h2 "Lieve woorden"; the carousel has `aria-roledescription` "carrousel" and a label "Reviews"; slides "Review n van m" (BR-REV-09).
|
||||
- Hidden slides are inert to keyboard and screen readers (BR-REV-10).
|
||||
- Focus ring from the theme on all controls; targets ≥ 44 px.
|
||||
- Axe clean; Lighthouse accessibility stays 1.0.
|
||||
+64
@@ -0,0 +1,64 @@
|
||||
# Code Generation Plan — Unit 4: Lieve woorden
|
||||
|
||||
**This plan is the single source of truth for Code Generation of unit 4.**
|
||||
|
||||
## Unit context
|
||||
- **Requirements**: FR-HP-05, FR-HP-11, FR-HP-12, NFR-HP-01/02/03/05/06
|
||||
- **Functional design**: [lieve-woorden/functional-design/](../lieve-woorden/functional-design/) — BR-REV-01…11
|
||||
- **Depends on**: unit 1 (`HomeSection`, `SectionHeading`, `Reveal`, `DeferredImage`), unit 2 (`FramedImage`)
|
||||
- **PBT**: full — `visibleTestimonials`, `slideLabel`; PBT-06 N/A (carousel state machine is Chakra's/Zag's).
|
||||
- Conventions as in units 1–3.
|
||||
|
||||
## Findings that shape the plan (from the installed `@zag-js/carousel` 1.43.3)
|
||||
1. **Reduced motion**: the built-in triggers, indicators and arrow keys call `scrollTo({ behavior: 'smooth' })` from JavaScript; CSS `scroll-behavior` cannot override that. The API does accept an `instant` flag (`scrollPrev(instant)`, `scrollNext(instant)`, `scrollTo(page, instant)`). → We keep Chakra's carousel for state, snapping, looping, swiping, slide semantics and hidden off-screen slides, but render **our own** previous/next buttons and dots (and arrow-key handling on the controls) that pass `instant = prefersReducedMotion` (BR-REV-06).
|
||||
2. **Double announcement**: the item group already carries `aria-live="polite"`. → We set it to `off` and keep one own polite live region with "Review n van m" (BR-REV-08).
|
||||
3. **Labels**: Zag's default translations are English. → `translations.item = slideLabel` so slides are "Review n van m" (BR-REV-09).
|
||||
|
||||
## Steps
|
||||
|
||||
### Images and content
|
||||
- [x] **Step 1** — Extend the one-off resize script with a centre crop to a target aspect ratio. Prepare the two live photos, cropped to **4:5** from the centre and resized to **880×1100**, quality 80: `IMG_2497-5.jpg` → `web/src/assets/home/review-trouwshoot.jpg`, `5-F41A4650-scaled.jpg` → `web/src/assets/home/review-newbornshoot.jpg`. Record the script change in the summary.
|
||||
- [x] **Step 2** — `content/types.ts`: `Testimonial { id; shoot; quote; author; image: ContentImage }`; `HomeContent.testimonials { title }`.
|
||||
- [x] **Step 3** — `content/testimonials.ts` with the two live reviews (full texts from FR-HP-05, alt texts from domain-entities.md); `homeContent.testimonials.title = 'Lieve woorden'`.
|
||||
|
||||
### Pure helpers
|
||||
- [x] **Step 4** — `lib/visibleTestimonials.ts` (+ test): invariants filter, first-wins de-duplication. Properties: valid + unique; subsequence; idempotent; oracle.
|
||||
- [x] **Step 5** — `lib/slideLabel.ts` (+ test): `slideLabel(index, count)` → `Review ${index + 1} van ${count}`. Properties: numbers round-trip; form and range invariant.
|
||||
- [x] **Step 6** — `test/arbitraries.ts`: `testimonial`, `uniqueTestimonials`, `anyTestimonial`.
|
||||
|
||||
### Components
|
||||
- [x] **Step 7** — `components/home/Testimonials/TestimonialSlide.tsx`: grid `5fr 7fr` from `lg` (stacked below, photo max 420 px), `FramedImage` 4/5, decorative quotation mark (`aria-hidden`), shoot as eyebrow (`accent.deep`), `figure` > `Blockquote` > `figcaption` "— author"; `data-testid="testimonial-<id>"`.
|
||||
- [x] **Step 8** — `components/home/Testimonials/Testimonials.tsx`: `visibleTestimonials`; none → `null`; one → `TestimonialSlide` without carousel; two or more → `useCarousel({ slideCount, loop: true, allowMouseDrag: true, translations })` + `Carousel.RootProvider` (`aria-label="Reviews"`, `aria-roledescription="carrousel"`), `Carousel.ItemGroup` with `aria-live="off"` and stretched items (equal height, BR-REV-07), one `Carousel.Item` per review; own controls: "Vorige review" / "Volgende review" buttons (Ant Design left/right outlined icons, offline), one dot per review (`aria-label="Review n"`, `aria-current` on the current one, 44 px hit area), arrow keys on the control bar; every control calls the API with `instant = reducedMotion`; `onPageChange` sets the polite `VisuallyHidden` live region to `slideLabel`. `HomeSection tone="alt"`, centred heading.
|
||||
- [x] **Step 9** — Tests: `TestimonialSlide.test.tsx` (photo alt, shoot, quote in a blockquote, author caption, quotation mark hidden, axe) and `Testimonials.test.tsx` (region "Lieve woorden"; two slides labelled "Review 1 van 2" / "Review 2 van 2"; buttons and dots named in Dutch; next from the last review goes to the first (loop) and is announced; a dot jumps to its review and marks itself current; arrow keys move; with reduced motion the API is called with `instant`; one review → no controls; none → no section; invalid reviews skipped; live region empty on load; axe clean).
|
||||
|
||||
### Route
|
||||
- [x] **Step 10** — `routes/index.tsx`: render `Testimonials` after `Pricing` with `homeContent.testimonials` and `testimonials`.
|
||||
- [x] **Step 11** — `app.test.tsx`: "Lieve woorden" in the page-order check.
|
||||
|
||||
### Verification and wrap-up
|
||||
- [x] **Step 12** — `pnpm check` (incl. Lighthouse); visual check at 1440, 390 (CDP), including a swipe/next to the second review.
|
||||
- [x] **Step 13** — `construction/lieve-woorden/code/code-summary.md`.
|
||||
- [x] **Step 14** — Commit (including the pending audit/state updates) — "Adds the Lieve woorden section to the homepage" + attribution. Not pushed.
|
||||
|
||||
### Fixes during Step 12
|
||||
- [x] **Step 12a** — Real-browser check showed the next slide's sand block over the quote and the own block clipped: 4 rem `spacing` between slides, 1.5 rem padding left/bottom per slide (from `sm`).
|
||||
- [x] **Step 12b** — Home mobile Lighthouse median 0.83 → 0.81 with the carousel in the route chunk. `React.lazy` alone did not help; the carousel moved to `TestimonialCarousel.tsx` and loads only when the section is within 200 px of the screen (heading always rendered, placeholder of the measured height). Median back to 0.83.
|
||||
|
||||
## Requirement / rule traceability
|
||||
| Item | Steps |
|
||||
|---|---|
|
||||
| FR-HP-05 | 2, 3, 7–11 |
|
||||
| BR-REV-01 | 4, 8, 9 |
|
||||
| BR-REV-02 | 8, 9 |
|
||||
| BR-REV-03/04/05 | 8, 9 |
|
||||
| BR-REV-06 | 8, 9 (finding 1) |
|
||||
| BR-REV-07 | 8, 12 |
|
||||
| BR-REV-08 | 5, 8, 9 (finding 2) |
|
||||
| BR-REV-09 | 5, 8, 9 (finding 3) |
|
||||
| BR-REV-10 | 8 (Zag sets `aria-hidden` on off-screen slides), 9 |
|
||||
| BR-REV-11 | 7, 9 |
|
||||
| NFR-HP-05 | 1, 7 (deferred image), 12 |
|
||||
|
||||
## Extension compliance (planned)
|
||||
- **Security**: content rendered as text; no new dependencies (Chakra Carousel and Ant Design icons already installed); no external resources.
|
||||
- **PBT**: PBT-02 (slideLabel round-trip), PBT-03 (invariants), PBT-04 (idempotency), PBT-05 (oracle), PBT-07 (generators), PBT-08/09 (existing), PBT-10 (example tests); PBT-06 N/A.
|
||||
+31
@@ -0,0 +1,31 @@
|
||||
# Functional Design Questions — Unit 4: Lieve woorden
|
||||
|
||||
Vul per vraag de letter in na `[Answer]:` (of geef ze in de chat, bijv. "1A, 2A, 3A"). Past geen enkele optie, kies dan de laatste (Anders) en licht toe. Waar ik een voorkeur heb staat **(aanbevolen)**.
|
||||
|
||||
## Vraag 1: Aan het einde van de reeks
|
||||
Een bezoeker staat op de laatste review en klikt op "volgende".
|
||||
|
||||
- A) Hij gaat rond naar de eerste review. Met maar een paar reviews voelt dat natuurlijk, en de knoppen werken altijd. (aanbevolen)
|
||||
- B) Het stopt: op de laatste review is "volgende" uitgeschakeld, op de eerste "vorige"
|
||||
- X) Anders (beschrijf hieronder na de [Answer]:-tag)
|
||||
|
||||
[Answer]: A
|
||||
|
||||
## Vraag 2: Hoe wisselt een review?
|
||||
|
||||
- A) **Schuiven**: de reviews liggen naast elkaar en schuiven opzij; bij vegen op een telefoon volgt de review je vinger. Zo werkt Chakra's Carousel uit zichzelf, en het sluit aan bij het vegen in de galerij. (aanbevolen)
|
||||
- B) **Overvloeien**: de oude review vervaagt en de nieuwe verschijnt, zoals in het statische ontwerp. Vegen werkt dan als "volgende/vorige", zonder dat de review je vinger volgt.
|
||||
- X) Anders (beschrijf hieronder na de [Answer]:-tag)
|
||||
|
||||
Bij "minder beweging" (systeeminstelling) wisselt de review in beide gevallen direct, zonder animatie.
|
||||
|
||||
[Answer]: A
|
||||
|
||||
## Vraag 3: Verschillende lengtes
|
||||
De trouwshoot-review is ongeveer twee keer zo lang als de newbornshoot-review.
|
||||
|
||||
- A) Alle reviews krijgen de hoogte van de langste. Bij het wisselen springt de rest van de pagina (Contact eronder) dan niet op en neer. (aanbevolen)
|
||||
- B) De hoogte past zich per review aan; minder witruimte bij korte reviews, maar de pagina eronder verschuift bij elke wissel
|
||||
- X) Anders (beschrijf hieronder na de [Answer]:-tag)
|
||||
|
||||
[Answer]: A
|
||||
+10
@@ -0,0 +1,10 @@
|
||||
# Functional Design Plan — Unit 4: Lieve woorden
|
||||
|
||||
Scope: FR-HP-05 — one review at a time with photo, quotation mark, shoot label, quote and names; previous/next and dots; no autoplay; announcements; Chakra `Carousel`. Questions: [lieve-woorden-fd-questions.md](lieve-woorden-fd-questions.md).
|
||||
|
||||
- [x] 1. Collect and analyze answers (follow-up questions if needed)
|
||||
- [x] 2. `domain-entities.md` — `Testimonial`, its invariants, initial data, relation to `ContentImage`
|
||||
- [x] 3. `business-rules.md` — which reviews are shown, 0 / 1 / many reviews, navigation at the ends, transitions and reduced motion, height of the slides, announcements, accessible names; decision flowchart
|
||||
- [x] 4. `business-logic-model.md` — navigation flow (buttons, dots, keyboard, swipe), pure functions (`visibleTestimonials`, `slideLabel`), PBT-01 properties
|
||||
- [x] 5. `frontend-components.md` — `Testimonials` (Chakra Carousel parts), `TestimonialSlide`; props, states, responsive layout, accessibility
|
||||
- [x] 6. Validate against FR-HP-05, NFR-HP-01/02/03/05/06 and the Security/PBT extensions
|
||||
Reference in New Issue
Block a user