From 9bb341dae740d59cc149648599d89c048b18f026 Mon Sep 17 00:00:00 2001 From: Sluijsens Date: Sun, 25 Oct 2026 18:26:48 +0100 Subject: [PATCH] Records that Lighthouse is a required check on master The deployment plan still said branch protection only required check. The owner made lighthouse a required check on 2026-10-19. Co-Authored-By: Claude Opus 5.5 --- .../frontend-shell/operations/deployment/deployment-plan.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aidlc-docs/features/frontend-shell/operations/deployment/deployment-plan.md b/aidlc-docs/features/frontend-shell/operations/deployment/deployment-plan.md index 00cccdb..fb17e4b 100644 --- a/aidlc-docs/features/frontend-shell/operations/deployment/deployment-plan.md +++ b/aidlc-docs/features/frontend-shell/operations/deployment/deployment-plan.md @@ -34,7 +34,7 @@ Text alternative: feature branches go through a pull request with CI into master | D3 | **Environments**: test and production. | Q5 = B | | D4 | **Test deploy**: automatically on every push to `master` (incl. a merged PR), and manually from any branch with "Deploy to Test", for example to try a branch before merging. | Q6 = B, CQ1 | | D5 | **Production deploy**: manual only ("Deploy to Production"), and only from a `release/*` branch; the workflow refuses other branches. | Q6 = B, CQ1 | -| D6 | **Quality gate**: every run does lint, format, tests, build and audit (`check`) before any deploy. **Test deploys right after `check`**, and Lighthouse (mobile + desktop) runs alongside as information. **Production waits for both `check` and Lighthouse.** Branch protection on `master` requires only `check`; Lighthouse is deliberately not a merge requirement. In CI, Lighthouse **Performance is report-only** (the Pi runner gives scores 30-40 points too low); accessibility, best practices and SEO block. Performance blocks in `pnpm check` on a PC. HTML reports are attached to every run as the `lighthouse-reports` artifact. | Q7 = A; Lighthouse CI question A | +| D6 | **Quality gate**: every run does lint, format, tests, build and audit (`check`) before any deploy. **Test deploys right after `check`**, and Lighthouse (mobile + desktop) runs alongside as information. **Production waits for both `check` and Lighthouse.** Branch protection on `master` requires both `check` and `lighthouse` (the owner added `lighthouse` as a required check on 2026-10-19; it was first deliberately left out). In CI, Lighthouse **Performance is report-only** (the Pi runner gives scores 30-40 points too low); accessibility, best practices and SEO block. Performance blocks in `pnpm check` on a PC. HTML reports are attached to every run as the `lighthouse-reports` artifact. | Q7 = A; Lighthouse CI question A; owner 2026-10-19 | | D7 | **Chrome for Lighthouse**: Playwright's Chromium (supports linux-arm64), installed in the job with a pinned Playwright version. Not the browser on the host: jobs run in containers and cannot see it. | CQ5 | | D8 | **Test target**: Raspberry Pi with nginx behind the reverse-proxy Pi, **next to the current WordPress site**. Deploy over SSH (`sshpass` + `scp`, same secrets as your other projects). Simple: empty the test folder, then copy the new build in; no old versions are kept. The step refuses an empty path, `/`, or a folder containing WordPress (`wp-config.php` / `wp-content`). The nginx block has its own `server_name` and never `default_server`. | CQ4 = B; owner: simpler than other apps, must not conflict with WordPress | | D9 | **Test is never indexed**: `X-Robots-Tag: noindex, nofollow` and a `robots.txt` that disallows everything. | Derived |