From 783d47bac2e66c9f007e1f6856dde31324ace917 Mon Sep 17 00:00:00 2001 From: Sluijsens Date: Tue, 13 Oct 2026 23:12:50 +0200 Subject: [PATCH] Adds mobile hamburger menu and sticky behavior to the navigation bar Gives the bar a fixed height from the header size token so it lines up with the hero, a paper background with a line border, and a shadow once scrolled. On desktop it shrinks to 68px and the logo from 46px to 38px after scrolling; on mobile it stays 66px and is always solid. Below lg the links move into a full-screen MobileNav that unfolds from the bar (clip-path), opened by the existing animated hamburger button. It closes on link click and Escape, locks page scroll while open, and counts as closed when the viewport grows to desktop. Fixes the button's misspelled aria-label attribute. Menu items live in navItems.ts, shared by desktop and mobile. Co-Authored-By: Claude Opus 5.5 --- .../components/NavigationBar/MobileNav.tsx | 76 +++++ .../NavigationBar/NavigationBar.tsx | 262 +++++++++++------- web/src/components/NavigationBar/navItems.ts | 7 + 3 files changed, 247 insertions(+), 98 deletions(-) create mode 100644 web/src/components/NavigationBar/MobileNav.tsx create mode 100644 web/src/components/NavigationBar/navItems.ts diff --git a/web/src/components/NavigationBar/MobileNav.tsx b/web/src/components/NavigationBar/MobileNav.tsx new file mode 100644 index 0000000..5bfe0d9 --- /dev/null +++ b/web/src/components/NavigationBar/MobileNav.tsx @@ -0,0 +1,76 @@ +import { useEffect } from 'react'; +import { Box, chakra, Stack } from '@chakra-ui/react'; +import { Link } from '@tanstack/react-router'; +import navItems from './navItems'; + +const ChakraLink = chakra(Link); + +type MobileNavProps = { + id: string; + open: boolean; + onClose: () => void; +}; + +// Menu onder de navigatiebalk op mobiel, vult de rest van het scherm +export default function MobileNav({ id, open, onClose }: MobileNavProps) { + // Pagina eronder niet laten scrollen, en sluiten met Escape + useEffect(() => { + if (!open) return; + + const onKeyDown = (event: KeyboardEvent) => { + if (event.key === 'Escape') onClose(); + }; + document.body.style.overflow = 'hidden'; + document.addEventListener('keydown', onKeyDown); + + return () => { + document.body.style.overflow = ''; + document.removeEventListener('keydown', onKeyDown); + }; + }, [open, onClose]); + + return ( + + + + ); +} diff --git a/web/src/components/NavigationBar/NavigationBar.tsx b/web/src/components/NavigationBar/NavigationBar.tsx index 2b2d1f2..58a6863 100644 --- a/web/src/components/NavigationBar/NavigationBar.tsx +++ b/web/src/components/NavigationBar/NavigationBar.tsx @@ -1,7 +1,17 @@ -import { Flex, HStack, chakra, Image, Box, Container } from '@chakra-ui/react'; +import { + Flex, + HStack, + chakra, + Image, + Box, + Container, + useBreakpointValue, +} from '@chakra-ui/react'; import NavLink from './NavLink'; +import MobileNav from './MobileNav'; +import navItems from './navItems'; import useScrolledPast from '@/hooks/useScrolledPast'; -import { useState } from 'react'; +import { useCallback, useState } from 'react'; import { useRouterState } from '@tanstack/react-router'; // Images @@ -10,6 +20,15 @@ import logoDark from '../../assets/logo-dark.png'; export default function NavigationBar() { let [open, setOpen] = useState(false); + const closeMenu = useCallback(() => setOpen(false), []); + + // Het mobiele menu bestaat alleen onder lg; wordt het scherm breder, dan + // telt het als dicht. + const isDesktop = useBreakpointValue( + { base: false, lg: true }, + { ssr: false }, + ); + const menuOpen = open && !isDesktop; const pastHero = useScrolledPast(() => 150); const isHome = useRouterState({ @@ -17,103 +36,150 @@ export default function NavigationBar() { }); const isSolid = pastHero || !isHome; - return ( - - - - - - - - - Home - - - Over mij - - - - { - setOpen(!open); - console.log('Clicked menu button, open:', open); - }} - auria-label="{open ? 'Sluit menu' : 'Open menu'}" - aria-expanded={open} - data-open={open || undefined} - position="relative" - w="32px" - h="32px" - cursor="pointer" - zIndex="modal" - css={{ - '& > span': { - position: 'absolute', - left: '4px', - width: '24px', - height: '2px', - bg: 'currentColor', - borderRadius: '1px', - transition: - 'transform 0.3s ease, opacity 0.2s ease, top 0.3s ease', - }, - '& > span:nth-of-type(1)': { top: '9px' }, - '& > span:nth-of-type(2)': { top: '15px' }, - '& > span:nth-of-type(3)': { top: '21px' }, + // Doorzichtig over de hero, maar alleen op desktop. Op mobiel staat de + // balk altijd op papier, zoals in het design. + const overlay = (solid: T, transparent: T) => + isSolid ? solid : { base: solid, lg: transparent }; - // open kruisje - '&[data-open] > span:nth-of-type(1)': { - top: '15px', - transform: 'rotate(45deg)', - }, - '&[data-open] > span:nth-of-type(2)': { - opacity: 0, - top: '15px', - transform: 'rotate(45deg)', - }, - '&[data-open] > span:nth-of-type(3)': { - top: '15px', - transform: 'rotate(-45deg)', - }, - }} + return ( + <> + + + + - - - - - - - - + {/* Twee logo's, zodat de kleur per schermbreedte kan wisselen */} + Andrea Slop Fotografie + Andrea Slop Fotografie + + + + {navItems.map((item) => ( + + + {item.label} + + + ))} + + + + setOpen(!menuOpen)} + aria-label={ + menuOpen ? 'Menu sluiten' : 'Menu openen' + } + aria-expanded={menuOpen} + aria-controls="mobile-nav" + data-open={menuOpen || undefined} + // Op desktop opent deze knop straks het info-menu (side area) + display={{ base: 'block', lg: 'none' }} + position="relative" + w="32px" + h="32px" + cursor="pointer" + zIndex="modal" + css={{ + '& > span': { + position: 'absolute', + left: '4px', + width: '24px', + height: '2px', + bg: 'currentColor', + borderRadius: '1px', + transition: + 'transform 0.3s ease, opacity 0.2s ease, top 0.3s ease', + }, + '& > span:nth-of-type(1)': { top: '9px' }, + '& > span:nth-of-type(2)': { top: '15px' }, + '& > span:nth-of-type(3)': { top: '21px' }, + + // open kruisje + '&[data-open] > span:nth-of-type(1)': { + top: '15px', + transform: 'rotate(45deg)', + }, + '&[data-open] > span:nth-of-type(2)': { + opacity: 0, + top: '15px', + transform: 'rotate(45deg)', + }, + '&[data-open] > span:nth-of-type(3)': { + top: '15px', + transform: 'rotate(-45deg)', + }, + }} + > + + + + + + + + + + ); } diff --git a/web/src/components/NavigationBar/navItems.ts b/web/src/components/NavigationBar/navItems.ts new file mode 100644 index 0000000..5832f25 --- /dev/null +++ b/web/src/components/NavigationBar/navItems.ts @@ -0,0 +1,7 @@ +// Menu-items, gedeeld door de desktopnavigatie en het mobiele menu +const navItems = [ + { to: '/', label: 'Home' }, + { to: '/over-mij', label: 'Over mij' }, +] as const; + +export default navItems;