From 5ffaa1ad56fa99fcd1be2a06b8cdab021881f3ec Mon Sep 17 00:00:00 2001 From: Sluijsens Date: Mon, 19 Oct 2026 20:51:09 +0200 Subject: [PATCH] Closes out the hero carousel bug fix Co-Authored-By: Claude Opus 5.5 --- aidlc-docs/active-features.md | 2 +- .../bugs/hero-carousel-announce-and-pause/bug-fix.md | 9 +++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/aidlc-docs/active-features.md b/aidlc-docs/active-features.md index f8c349f..490ca3d 100644 --- a/aidlc-docs/active-features.md +++ b/aidlc-docs/active-features.md @@ -2,5 +2,5 @@ | Type | Name | Status | Branch | Affected Components | Session Start | |------|------|--------|--------|---------------------|---------------| -| Bug | [hero-carousel-announce-and-pause](bugs/hero-carousel-announce-and-pause/bug-fix.md) | 🟢 Fixing | fix/hero-carousel-announce-and-pause | web/src/components/Hero (Hero, HeroArrows, useHeroSlider) | 2026-10-19 | +| Bug | [hero-carousel-announce-and-pause](bugs/hero-carousel-announce-and-pause/bug-fix.md) | ✅ Complete | fix/hero-carousel-announce-and-pause | web/src/components/Hero (Hero, HeroArrows, useHeroSlider) | 2026-10-19 | | Feature | frontend-shell | ✅ Complete | feature/frontend-shell | web/src (AppShell, NavigationBar, Footer, Hero socials, new BackToTop/SkipLink/404/error pages, routes, theme.ts, main.tsx), web/vite.config.js, web/package.json | 2026-10-14 | diff --git a/aidlc-docs/bugs/hero-carousel-announce-and-pause/bug-fix.md b/aidlc-docs/bugs/hero-carousel-announce-and-pause/bug-fix.md index 765d11a..81d4e1f 100644 --- a/aidlc-docs/bugs/hero-carousel-announce-and-pause/bug-fix.md +++ b/aidlc-docs/bugs/hero-carousel-announce-and-pause/bug-fix.md @@ -1,7 +1,7 @@ # Bug Fix: Hero carousel gives no feedback on manual slide change and has no pause control - **Slug**: hero-carousel-announce-and-pause -- **Status**: Fixing +- **Status**: Complete - **Issue**: None (raised by the owner after the frontend-shell feature) - **Branch**: fix/hero-carousel-announce-and-pause - **Started**: 2026-10-19 @@ -93,10 +93,11 @@ The pause button's place and look were proposed in the diagnosis and accepted wi 6. resumed: moves on to slide 4, button reads "Diavoorstelling pauzeren" again - On test after the deploy (run 545, `46fb2f6`; check on the Pi, deploy on the Pi, Lighthouse on the PC, all green; PR run 544 green): the same six results as locally, see [repro-after-test.txt](repro-after-test.txt). - Placement: [hero-desktop.png](hero-desktop.png) (1440×900) and [hero-mobile.png](hero-mobile.png) (390×844): the button sits bottom right, level with the socials and below the right arrow. -- Owner's own screen reader check on test: (pending) +- Re-test on test after the pause announcements (run 547, `b332f1a`, all green): [repro-after-test.txt](repro-after-test.txt) adds "Diavoorstelling gepauzeerd" after pausing and "Diavoorstelling speelt weer af" after resuming. +- Owner's own screen reader check on test, 2026-10-19: the arrow announcement worked; the pause button gave no feedback on the first version (fixed in `b332f1a`); after that: "De knop doet nu wat ik verwacht en je hebt akkoord om te mergen en weer op te ruimen als er niks meer te doen is". ## Result - **PR(s)**: #5 (https://gitea.slpsoftware.nl/SLP_Software/AndreaSlopFotografie/pulls/5) -- **Commit(s)**: 46fb2f6 (fix) -- **Completed**: — +- **Commit(s)**: 46fb2f6 (fix), b332f1a (pause announcements), e308aad and 45428e4 and this one (evidence) +- **Completed**: 2026-10-19