Completes the front-end shell with footer, status pages and SEO
Adds the footer, back-to-top button, skip link, placeholder routes, 404 and error pages inside the shell, plus per-page SEO from a single page registry (canonical URLs, Open Graph image, JSON-LD, generated sitemap.xml and robots.txt). Theme tokens and recipes replace repeated styling, the hero loads only the active and neighbouring slides, and the e-mail address is joined in the browser to keep it out of the HTML and bundle. Adds Vitest with property-based (fast-check) and axe tests, ESLint, security headers for dev and preview, Lighthouse CI and a `pnpm check` script that runs all quality gates. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,55 @@
|
||||
import { useEffect } from 'react';
|
||||
import { chakra, useRecipe } from '@chakra-ui/react';
|
||||
import { useRouter, type ErrorComponentProps } from '@tanstack/react-router';
|
||||
import LinkButton from '../LinkButton';
|
||||
import StatusPage from './StatusPage';
|
||||
|
||||
// Algemene foutpagina (FR-10). Toont nooit de foutmelding zelf; die gaat
|
||||
// alleen naar de console (BR-ERR-02/03).
|
||||
export default function ErrorPage({ error, reset }: ErrorComponentProps) {
|
||||
const router = useRouter();
|
||||
const buttonRecipe = useRecipe({ key: 'linkButton' });
|
||||
|
||||
useEffect(() => {
|
||||
console.error(error);
|
||||
}, [error]);
|
||||
|
||||
// Foutgrens resetten en de route opnieuw laden (BR-ERR-04)
|
||||
const retry = () => {
|
||||
reset();
|
||||
router.invalidate();
|
||||
};
|
||||
|
||||
return (
|
||||
<>
|
||||
<title>Er ging iets mis | Andrea Slop Fotografie</title>
|
||||
<meta name="robots" content="noindex" />
|
||||
<StatusPage
|
||||
title="Er ging iets mis"
|
||||
actions={
|
||||
<>
|
||||
<chakra.button
|
||||
type="button"
|
||||
onClick={retry}
|
||||
css={buttonRecipe({ variant: 'accent' })}
|
||||
cursor="pointer"
|
||||
data-testid="error-page-retry-button"
|
||||
>
|
||||
Opnieuw proberen
|
||||
</chakra.button>
|
||||
<LinkButton
|
||||
to="/"
|
||||
variant="outline"
|
||||
data-testid="error-page-home-link"
|
||||
>
|
||||
Terug naar home
|
||||
</LinkButton>
|
||||
</>
|
||||
}
|
||||
>
|
||||
Door een fout kan deze pagina nu niet worden getoond. Probeer
|
||||
het opnieuw of ga terug naar de homepage.
|
||||
</StatusPage>
|
||||
</>
|
||||
);
|
||||
}
|
||||
@@ -0,0 +1,17 @@
|
||||
import StatusPage from './StatusPage';
|
||||
|
||||
// Pagina voor een onbekende URL, binnen de shell (FR-09). Een globale
|
||||
// not-found heeft geen eigen route-head; React 19 zet <title> en <meta>
|
||||
// daarom zelf in <head> en haalt ze weer weg bij het verlaten (BR-404-02).
|
||||
export default function NotFound() {
|
||||
return (
|
||||
<>
|
||||
<title>Pagina niet gevonden | Andrea Slop Fotografie</title>
|
||||
<meta name="robots" content="noindex" />
|
||||
<StatusPage title="Pagina niet gevonden">
|
||||
Deze pagina bestaat niet (meer). Misschien is de link verouderd
|
||||
of zit er een typfout in het adres.
|
||||
</StatusPage>
|
||||
</>
|
||||
);
|
||||
}
|
||||
@@ -0,0 +1,86 @@
|
||||
import { screen } from '@testing-library/react';
|
||||
import userEvent from '@testing-library/user-event';
|
||||
import { describe, expect, it, vi } from 'vitest';
|
||||
import { axeResults } from '@/test/axe';
|
||||
import { renderWithProviders } from '@/test/renderWithProviders';
|
||||
import ErrorPage from './ErrorPage';
|
||||
import NotFound from './NotFound';
|
||||
|
||||
describe('NotFound', () => {
|
||||
it('toont de 404-tekst met een link naar home', async () => {
|
||||
const { container } = await renderWithProviders(<NotFound />, {
|
||||
path: '/bestaat-niet',
|
||||
});
|
||||
expect(screen.getByRole('heading', { level: 1 })).toHaveTextContent(
|
||||
'Pagina niet gevonden',
|
||||
);
|
||||
expect(
|
||||
screen.getByRole('link', { name: 'Terug naar home' }),
|
||||
).toHaveAttribute('href', '/');
|
||||
expect(await axeResults(container)).toHaveNoViolations();
|
||||
});
|
||||
|
||||
it('zet een eigen titel en noindex in de head', async () => {
|
||||
await renderWithProviders(<NotFound />, { path: '/bestaat-niet' });
|
||||
expect(document.title).toBe(
|
||||
'Pagina niet gevonden | Andrea Slop Fotografie',
|
||||
);
|
||||
expect(
|
||||
document.head.querySelector('meta[name="robots"]'),
|
||||
).toHaveAttribute('content', 'noindex');
|
||||
});
|
||||
});
|
||||
|
||||
describe('ErrorPage', () => {
|
||||
const error = new Error('Geheime interne fout in de database');
|
||||
|
||||
const renderError = async () => {
|
||||
const reset = vi.fn();
|
||||
const consoleError = vi
|
||||
.spyOn(console, 'error')
|
||||
.mockImplementation(() => {});
|
||||
const result = await renderWithProviders(
|
||||
<ErrorPage error={error} reset={reset} />,
|
||||
);
|
||||
return { ...result, reset, consoleError };
|
||||
};
|
||||
|
||||
it('toont een algemene melding zonder foutdetails', async () => {
|
||||
const { container } = await renderError();
|
||||
expect(screen.getByRole('heading', { level: 1 })).toHaveTextContent(
|
||||
'Er ging iets mis',
|
||||
);
|
||||
expect(container).not.toHaveTextContent('Geheime interne fout');
|
||||
expect(container.innerHTML).not.toContain('database');
|
||||
expect(await axeResults(container)).toHaveNoViolations();
|
||||
});
|
||||
|
||||
it('logt de fout precies een keer', async () => {
|
||||
const { consoleError } = await renderError();
|
||||
expect(consoleError).toHaveBeenCalledTimes(1);
|
||||
expect(consoleError).toHaveBeenCalledWith(error);
|
||||
});
|
||||
|
||||
it('opnieuw proberen reset de foutgrens en laadt de route opnieuw', async () => {
|
||||
const { reset, router } = await renderError();
|
||||
const invalidate = vi.spyOn(router, 'invalidate');
|
||||
await userEvent.click(
|
||||
screen.getByRole('button', { name: 'Opnieuw proberen' }),
|
||||
);
|
||||
expect(reset).toHaveBeenCalledTimes(1);
|
||||
expect(invalidate).toHaveBeenCalledTimes(1);
|
||||
});
|
||||
|
||||
it('biedt een link naar home en zet noindex', async () => {
|
||||
await renderError();
|
||||
expect(
|
||||
screen.getByRole('link', { name: 'Terug naar home' }),
|
||||
).toHaveAttribute('href', '/');
|
||||
expect(document.title).toBe(
|
||||
'Er ging iets mis | Andrea Slop Fotografie',
|
||||
);
|
||||
expect(
|
||||
document.head.querySelector('meta[name="robots"]'),
|
||||
).toHaveAttribute('content', 'noindex');
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,41 @@
|
||||
import type { ReactNode } from 'react';
|
||||
import { Container, Flex, Heading, Text } from '@chakra-ui/react';
|
||||
import LinkButton from '../LinkButton';
|
||||
|
||||
type StatusPageProps = {
|
||||
title: string;
|
||||
children: ReactNode;
|
||||
// Standaard één knop terug naar home
|
||||
actions?: ReactNode;
|
||||
};
|
||||
|
||||
// Gedeelde opmaak van de 404- en de foutpagina
|
||||
export default function StatusPage({
|
||||
title,
|
||||
children,
|
||||
actions,
|
||||
}: StatusPageProps) {
|
||||
return (
|
||||
<Container
|
||||
as="section"
|
||||
maxW="2xl"
|
||||
pt="pageTop"
|
||||
pb={{ base: 16, md: 24 }}
|
||||
textAlign="center"
|
||||
>
|
||||
<Heading as="h1" textStyle="pageTitle" mb={4}>
|
||||
{title}
|
||||
</Heading>
|
||||
<Text color="ink.soft" mb={8}>
|
||||
{children}
|
||||
</Text>
|
||||
<Flex gap={4} justifyContent="center" wrap="wrap">
|
||||
{actions ?? (
|
||||
<LinkButton to="/" data-testid="status-page-home-link">
|
||||
Terug naar home
|
||||
</LinkButton>
|
||||
)}
|
||||
</Flex>
|
||||
</Container>
|
||||
);
|
||||
}
|
||||
Reference in New Issue
Block a user