From 45428e4446754476e09ea84ddd47b386dbd15620 Mon Sep 17 00:00:00 2001 From: Sluijsens Date: Mon, 19 Oct 2026 20:45:29 +0200 Subject: [PATCH] Records the hero fix check on test after the pause announcements Also notes that b332f1a carried the owner's shorter alt text for hero-1. Co-Authored-By: Claude Opus 5.5 --- aidlc-docs/bugs/hero-carousel-announce-and-pause/bug-fix.md | 1 + .../bugs/hero-carousel-announce-and-pause/repro-after-test.txt | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/aidlc-docs/bugs/hero-carousel-announce-and-pause/bug-fix.md b/aidlc-docs/bugs/hero-carousel-announce-and-pause/bug-fix.md index d44bd64..765d11a 100644 --- a/aidlc-docs/bugs/hero-carousel-announce-and-pause/bug-fix.md +++ b/aidlc-docs/bugs/hero-carousel-announce-and-pause/bug-fix.md @@ -66,6 +66,7 @@ The pause button's place and look were proposed in the diagnosis and accepted wi - `Hero.tsx`: the same live region now also says "Diavoorstelling gepauzeerd" or "Diavoorstelling speelt weer af" (`announcementText`). - Tests: the pause test checks both messages; the hook test checks them and that the next automatic change clears them. - Placement and look of the button: approved by the owner. +- Commit `b332f1a` also carries an unrelated text change by the owner: the `alt` of `hero-1` in `web/src/content/heroContent.ts` went from "Lifestyle fotografie van Andrea Slop" to "Lifestyle fotografie" (picked up by `git add -A`; not in that commit's message). **Why this and not something else** - *A live region that mirrors the active slide* (or toggling `aria-live` between `off` and `polite` as in the W3C example): it would speak automatic changes too, or depend on exactly when rotation is paused. Separating visitor and automatic changes in the hook states the intent directly. diff --git a/aidlc-docs/bugs/hero-carousel-announce-and-pause/repro-after-test.txt b/aidlc-docs/bugs/hero-carousel-announce-and-pause/repro-after-test.txt index 8942579..f0b8d7e 100644 --- a/aidlc-docs/bugs/hero-carousel-announce-and-pause/repro-after-test.txt +++ b/aidlc-docs/bugs/hero-carousel-announce-and-pause/repro-after-test.txt @@ -2,5 +2,6 @@ 2. na pijlklik | slide: 2 van 8 | live: ["polite: \"Foto 2 van 8: Knusse newbornfoto met de familie\""] 3. na autoplay | slide: 3 van 8 | live: ["polite: \"\""] 4. knoppen | ["Menu openen","Vorige foto","Volgende foto","Diavoorstelling pauzeren"] -5. gepauzeerd | slide blijft: 3 van 8 -> 3 van 8 | knoppen: ["Menu openen","Vorige foto","Volgende foto","Diavoorstelling afspelen"] +5. gepauzeerd | slide blijft: 3 van 8 -> 3 van 8 | live: ["polite: \"Diavoorstelling gepauzeerd\""] | knoppen: ["Menu openen","Vorige foto","Volgende foto","Diavoorstelling afspelen"] +6a. na afspelen | live: ["polite: \"Diavoorstelling speelt weer af\""] 6. hervat | slide nu: 4 van 8 | knoppen: ["Menu openen","Vorige foto","Volgende foto","Diavoorstelling pauzeren"]