Compares the preview server with real nginx in tests
The preview server must behave like the real server, or Lighthouse and the browser tests prove the wrong thing. The tests also cover the new URLs in a real browser: one redirect, one title, a clean hydration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
+355
-29
@@ -1,8 +1,19 @@
|
||||
import { request } from 'node:http';
|
||||
import { connect } from 'node:net';
|
||||
import fc from 'fast-check';
|
||||
import { existsSync, readFileSync, statSync } from 'node:fs';
|
||||
import { request, type IncomingMessage, type Server } from 'node:http';
|
||||
import { connect, type AddressInfo } from 'node:net';
|
||||
import { join } from 'node:path';
|
||||
import { gunzipSync } from 'node:zlib';
|
||||
import { afterAll, beforeAll, describe, expect, it } from 'vitest';
|
||||
import { afterAll, beforeAll, describe, expect, inject, it } from 'vitest';
|
||||
import { pagePaths } from '../config/canonicalUrls.ts';
|
||||
import { NOT_FOUND_FILE, pageFile } from '../config/pageFiles.ts';
|
||||
import { startPreviewServer } from '../config/previewServer.ts';
|
||||
import { securityHeaders } from '../config/securityHeaders.ts';
|
||||
import {
|
||||
pageVariant,
|
||||
queryString,
|
||||
unknownPath,
|
||||
} from '../src/test/urlArbitraries.ts';
|
||||
import { createFixtureSite, type FixtureSite } from './support/fixtureSite.ts';
|
||||
import {
|
||||
findNginx,
|
||||
@@ -10,11 +21,15 @@ import {
|
||||
type MimeVariant,
|
||||
type RunningNginx,
|
||||
} from './support/nginx.ts';
|
||||
import { clientDir } from './support/server.ts';
|
||||
|
||||
// BR-HST-24: de nginx-regels worden bewezen door een echte nginx, niet door de
|
||||
// tekst te lezen. De site is een kleine fixture (geen build nodig); dezelfde
|
||||
// regels voor de previewserver staan in previewServer.test.ts.
|
||||
|
||||
// Seed van deze run, gekozen en gelogd in config/testSeed.ts (PBT-08)
|
||||
fc.configureGlobal({ seed: inject('fcSeed') });
|
||||
|
||||
const nginxBin = findNginx();
|
||||
const inCi = Boolean(process.env.CI);
|
||||
|
||||
@@ -43,34 +58,44 @@ interface Reply {
|
||||
body: Buffer;
|
||||
}
|
||||
|
||||
// node:http en niet fetch: fetch voegt dubbele headers samen en pakt gzip uit
|
||||
// node:http en niet fetch: fetch voegt dubbele headers samen en pakt gzip uit.
|
||||
// Met raw gaat het pad ongewijzigd over de lijn; anders maakt de URL-parser er
|
||||
// zijn eigen vorm van (een backslash wordt een slash).
|
||||
function get(
|
||||
origin: string,
|
||||
path: string,
|
||||
options: { method?: string; headers?: Record<string, string> } = {},
|
||||
options: {
|
||||
method?: string;
|
||||
headers?: Record<string, string>;
|
||||
raw?: boolean;
|
||||
} = {},
|
||||
): Promise<Reply> {
|
||||
return new Promise((resolve, reject) => {
|
||||
const req = request(
|
||||
origin + path,
|
||||
{ method: options.method ?? 'GET', headers: options.headers },
|
||||
(res) => {
|
||||
const chunks: Buffer[] = [];
|
||||
res.on('data', (chunk: Buffer) => chunks.push(chunk));
|
||||
res.on('end', () =>
|
||||
resolve({
|
||||
status: res.statusCode ?? 0,
|
||||
headers: Object.fromEntries(
|
||||
Object.entries(res.headers).map(([k, v]) => [
|
||||
k,
|
||||
String(v),
|
||||
]),
|
||||
),
|
||||
rawHeaders: res.rawHeaders,
|
||||
body: Buffer.concat(chunks),
|
||||
}),
|
||||
);
|
||||
},
|
||||
);
|
||||
const init = {
|
||||
method: options.method ?? 'GET',
|
||||
headers: options.headers,
|
||||
};
|
||||
const onReply = (res: IncomingMessage) => {
|
||||
const chunks: Buffer[] = [];
|
||||
res.on('data', (chunk: Buffer) => chunks.push(chunk));
|
||||
res.on('end', () =>
|
||||
resolve({
|
||||
status: res.statusCode ?? 0,
|
||||
headers: Object.fromEntries(
|
||||
Object.entries(res.headers).map(([k, v]) => [
|
||||
k,
|
||||
String(v),
|
||||
]),
|
||||
),
|
||||
rawHeaders: res.rawHeaders,
|
||||
body: Buffer.concat(chunks),
|
||||
}),
|
||||
);
|
||||
};
|
||||
const { hostname, port } = new URL(origin);
|
||||
const req = options.raw
|
||||
? request({ hostname, port, path, ...init }, onReply)
|
||||
: request(origin + path, init, onReply);
|
||||
req.on('error', reject);
|
||||
req.end();
|
||||
});
|
||||
@@ -123,6 +148,14 @@ function getHttp10(origin: string, path: string, headers: string[]) {
|
||||
});
|
||||
}
|
||||
|
||||
// De versie van nginx één keer in de uitvoer, hoeveel instanties er ook starten
|
||||
let versionAnnounced = false;
|
||||
function announce(nginx: RunningNginx) {
|
||||
if (versionAnnounced) return;
|
||||
versionAnnounced = true;
|
||||
console.log(`[serverRules] nginx -v: ${nginx.version}`);
|
||||
}
|
||||
|
||||
const mimeVariants: MimeVariant[] = ['new', 'old'];
|
||||
|
||||
const rulesSuite = nginxBin ? describe : describe.skip;
|
||||
@@ -139,9 +172,7 @@ rulesSuite.each(mimeVariants)(
|
||||
siteDir: site.dir,
|
||||
mimeVariant: variant,
|
||||
});
|
||||
console.log(
|
||||
`[serverRules] nginx -v: ${nginx.version} (${nginx.origin})`,
|
||||
);
|
||||
announce(nginx);
|
||||
});
|
||||
afterAll(async () => {
|
||||
await nginx?.stop();
|
||||
@@ -374,3 +405,298 @@ rulesSuite.each(mimeVariants)(
|
||||
});
|
||||
},
|
||||
);
|
||||
|
||||
// P-HST-09 (oracle): dezelfde fixturesite achter de echte nginx en achter de
|
||||
// previewserver. Voor elk pad moeten ze gelijk antwoorden op status, Location
|
||||
// (zonder schema en host), het bestand dat geserveerd is en gzip. Bewust
|
||||
// anders, en dus niet vergeleken:
|
||||
// - 405-tekst en de Server-header: nginx heeft eigen teksten;
|
||||
// - het MIME-type van .js: hangt van de nginx-versie af (beide tabellen staan
|
||||
// hierboven in de suite per mime-variant);
|
||||
// - /robots.txt: nginx vervangt hem door Disallow, de previewserver serveert
|
||||
// het bestand (de fixture heeft er een);
|
||||
// - X-Robots-Tag: alleen nginx (testsite), de previewserver stuurt hem nooit;
|
||||
// - Cache-Control op een 301: nginx zet no-cache via add_header op
|
||||
// server-niveau, de previewserver stuurt er geen (BR-HST-12); op bestanden
|
||||
// buiten HTML zet de previewserver er geen;
|
||||
// - paden met een leeg segment (//), zie het blok onderaan de suite;
|
||||
// - /%2e%2e/ en een NUL in het pad: nginx weigert die met 400, de
|
||||
// previewserver geeft 404.
|
||||
const parityRules = nginxBin ? describe : describe.skip;
|
||||
parityRules('pariteit: previewserver tegen echte nginx (P-HST-09)', () => {
|
||||
let site: FixtureSite;
|
||||
let nginx: RunningNginx;
|
||||
let preview: Server;
|
||||
let previewOrigin: string;
|
||||
|
||||
beforeAll(async () => {
|
||||
site = await createFixtureSite();
|
||||
nginx = await startNginx({ siteDir: site.dir });
|
||||
announce(nginx);
|
||||
preview = await startPreviewServer(site.dir, 0);
|
||||
previewOrigin = `http://127.0.0.1:${(preview.address() as AddressInfo).port}`;
|
||||
});
|
||||
afterAll(async () => {
|
||||
preview?.closeAllConnections();
|
||||
await new Promise<void>((resolve) =>
|
||||
preview ? preview.close(() => resolve()) : resolve(),
|
||||
);
|
||||
await nginx?.stop();
|
||||
await site?.remove();
|
||||
});
|
||||
|
||||
const acceptGzip = { 'Accept-Encoding': 'gzip' };
|
||||
const search = (query: string) => (query ? `?${query}` : '');
|
||||
const decoded = (reply: Reply) =>
|
||||
reply.headers['content-encoding'] === 'gzip'
|
||||
? gunzipSync(reply.body)
|
||||
: reply.body;
|
||||
const servedFile = (reply: Reply) =>
|
||||
/fixture:[\w./-]+/.exec(decoded(reply).toString('latin1'))?.[0];
|
||||
const locationOf = (reply: Reply) =>
|
||||
reply.headers.location?.replace(/^https?:\/\/[^/]+/, '');
|
||||
|
||||
// Wat aan de headers van één antwoord niet klopt
|
||||
function headerFindings(
|
||||
server: 'nginx' | 'preview',
|
||||
reply: Reply,
|
||||
checkCache: boolean,
|
||||
) {
|
||||
const found: string[] = [];
|
||||
for (const [name, value] of Object.entries(
|
||||
securityHeaders('production'),
|
||||
)) {
|
||||
const count = countHeader(reply, name);
|
||||
const actual = reply.headers[name.toLowerCase()];
|
||||
if (count !== 1 || actual !== value) {
|
||||
found.push(`${server}: ${name} ${count}x, waarde ${actual}`);
|
||||
}
|
||||
}
|
||||
const robots = countHeader(reply, 'X-Robots-Tag');
|
||||
if (robots !== (server === 'nginx' ? 1 : 0)) {
|
||||
found.push(`${server}: X-Robots-Tag ${robots}x`);
|
||||
}
|
||||
if (checkCache) {
|
||||
const count = countHeader(reply, 'Cache-Control');
|
||||
const expected =
|
||||
server === 'preview' && reply.status === 301 ? 0 : 1;
|
||||
if (count !== expected) {
|
||||
found.push(
|
||||
`${server}: Cache-Control ${count}x, verwacht ${expected}x`,
|
||||
);
|
||||
}
|
||||
}
|
||||
return found;
|
||||
}
|
||||
|
||||
// Alle verschillen voor één pad, leesbaar met het pad erbij
|
||||
async function differences(path: string, checkCache = true) {
|
||||
const [fromNginx, fromPreview] = await Promise.all([
|
||||
get(nginx.origin, path, { headers: acceptGzip, raw: true }),
|
||||
get(previewOrigin, path, { headers: acceptGzip, raw: true }),
|
||||
]);
|
||||
const found: string[] = [];
|
||||
const same = (what: string, a: unknown, b: unknown) => {
|
||||
if (a !== b) found.push(`${what}: nginx ${a}, preview ${b}`);
|
||||
};
|
||||
same('status', fromNginx.status, fromPreview.status);
|
||||
same('Location', locationOf(fromNginx), locationOf(fromPreview));
|
||||
same('bestand', servedFile(fromNginx), servedFile(fromPreview));
|
||||
same(
|
||||
'Content-Encoding',
|
||||
fromNginx.headers['content-encoding'],
|
||||
fromPreview.headers['content-encoding'],
|
||||
);
|
||||
if (
|
||||
fromNginx.status !== 301 &&
|
||||
!decoded(fromNginx).equals(decoded(fromPreview))
|
||||
) {
|
||||
found.push('inhoud: de bytes verschillen');
|
||||
}
|
||||
if (checkCache && fromNginx.status !== 301) {
|
||||
same(
|
||||
'Cache-Control',
|
||||
fromNginx.headers['cache-control'],
|
||||
fromPreview.headers['cache-control'],
|
||||
);
|
||||
}
|
||||
found.push(
|
||||
...headerFindings('nginx', fromNginx, checkCache),
|
||||
...headerFindings('preview', fromPreview, checkCache),
|
||||
);
|
||||
return found.map((finding) => `${path} ${finding}`);
|
||||
}
|
||||
|
||||
// De tabel van het URL-contract, rij voor rij
|
||||
it.each([
|
||||
'/',
|
||||
'/over-mij',
|
||||
'/soorten-fotoshoots',
|
||||
'/soorten-fotoshoots/newborn',
|
||||
'/over-mij?x=1',
|
||||
'/?x=1',
|
||||
'/over-mij/',
|
||||
'/over-mij///',
|
||||
'/soorten-fotoshoots/',
|
||||
'/soorten-fotoshoots/?x=1',
|
||||
'/over-mij.html',
|
||||
'/soorten-fotoshoots/newborn.html',
|
||||
'/index',
|
||||
'/index.html',
|
||||
'/index/',
|
||||
'/Over-Mij',
|
||||
'/OVER-MIJ.HTML',
|
||||
'/Over-Mij/',
|
||||
'/Over-Mij?x=1&y=%20z',
|
||||
'/404',
|
||||
'/404.html',
|
||||
'/onbekend',
|
||||
'/Onbekend',
|
||||
'/x.html',
|
||||
'/onbekend/',
|
||||
'/onbekend/?a=b',
|
||||
'/assets',
|
||||
'/assets/',
|
||||
'/assets/missing.js',
|
||||
'/%5Cevil.example',
|
||||
'/%5Cevil.example/',
|
||||
])('%s: nginx en previewserver antwoorden gelijk', async (path) => {
|
||||
expect(await differences(path)).toEqual([]);
|
||||
});
|
||||
|
||||
// Bestanden: zelfde status, bytes en gzip-keuze (Cache-Control: zie boven)
|
||||
it.each([
|
||||
'/sitemap.xml',
|
||||
'/favicon.png',
|
||||
'/assets/index-AbC123xYz.js',
|
||||
'/assets/style-Qw9.css',
|
||||
'/assets/icon-Zz1.svg',
|
||||
'/assets/data.json',
|
||||
'/assets/readme.txt',
|
||||
'/assets/font-Ab.woff2',
|
||||
])('%s: gelijke status, bytes en gzip', async (path) => {
|
||||
expect(await differences(path, false)).toEqual([]);
|
||||
});
|
||||
|
||||
// Bekende pagina's in elke vorm en onbekende paden met en zonder slash,
|
||||
// met en zonder query
|
||||
const parityPath = fc.oneof(
|
||||
fc
|
||||
.tuple(pageVariant, queryString)
|
||||
.map(([path, query]) => path + search(query)),
|
||||
fc
|
||||
.tuple(unknownPath, fc.boolean(), queryString)
|
||||
.map(
|
||||
([path, slash, query]) =>
|
||||
path + (slash ? '/' : '') + search(query),
|
||||
),
|
||||
);
|
||||
it('nginx en previewserver antwoorden gelijk op gegenereerde paden (oracle)', async () => {
|
||||
await fc.assert(
|
||||
fc.asyncProperty(parityPath, async (path) => {
|
||||
expect(await differences(path)).toEqual([]);
|
||||
}),
|
||||
{ numRuns: 100 },
|
||||
);
|
||||
});
|
||||
|
||||
// Buiten de pariteit: een leeg segment. nginx voegt de slashes samen
|
||||
// (merge_slashes) en bedient of verwijst het samengevoegde pad; de
|
||||
// previewserver kent een leeg segment niet (BR-SRV-07) en geeft 404, op
|
||||
// slashes alleen na (// en /// gaan naar /). Een verschil in uitkomst kan
|
||||
// geen verkeerde eerste render geven, want browser en router maken zulke
|
||||
// paden niet, en geen doorverwijzing begint met // (BR-HST-06).
|
||||
describe('lege segmenten, buiten de pariteit', () => {
|
||||
it.each([
|
||||
['//', 'index.html'],
|
||||
['///', 'index.html'],
|
||||
['//over-mij', 'over-mij.html'],
|
||||
])(
|
||||
'nginx voegt de slashes van %s samen en bedient %s',
|
||||
async (path, file) => {
|
||||
const reply = await get(nginx.origin, path, { raw: true });
|
||||
expect(reply.status).toBe(200);
|
||||
expect(reply.body.toString()).toContain(
|
||||
site.markers.get(file) ?? file,
|
||||
);
|
||||
},
|
||||
);
|
||||
|
||||
it.each([
|
||||
['/a//b/', '/a/b'],
|
||||
['//evil.example/', '/evil.example'],
|
||||
])('nginx verwijst %s naar %s', async (path, target) => {
|
||||
const reply = await get(nginx.origin, path, { raw: true });
|
||||
expect(reply.status).toBe(301);
|
||||
expect(reply.headers.location).toBe(target);
|
||||
});
|
||||
|
||||
it.each(['//', '///', '//over-mij', '/a//b/', '//evil.example/'])(
|
||||
'de previewserver geeft voor %s 404 of een doorverwijzing naar /',
|
||||
async (path) => {
|
||||
const reply = await get(previewOrigin, path, { raw: true });
|
||||
if (reply.status === 301) {
|
||||
expect(reply.headers.location).toBe('/');
|
||||
} else {
|
||||
expect(reply.status).toBe(404);
|
||||
}
|
||||
},
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
// De echte build achter de echte nginx: elke pagina, de 404 en de map naast
|
||||
// het paginabestand. Heeft een actuele dist nodig (pnpm build).
|
||||
const buildSuite = nginxBin ? describe : describe.skip;
|
||||
buildSuite('nginx op de echte build (dist/client)', () => {
|
||||
let nginx: RunningNginx;
|
||||
const bytesOf = (file: string) => readFileSync(join(clientDir, file));
|
||||
|
||||
beforeAll(async () => {
|
||||
nginx = await startNginx({ siteDir: clientDir });
|
||||
announce(nginx);
|
||||
});
|
||||
afterAll(async () => {
|
||||
await nginx?.stop();
|
||||
});
|
||||
|
||||
it.each([...pagePaths])(
|
||||
'%s geeft 200 met de bytes van het paginabestand',
|
||||
async (path) => {
|
||||
const reply = await get(nginx.origin, path, { raw: true });
|
||||
expect(reply.status).toBe(200);
|
||||
expect(reply.body.equals(bytesOf(pageFile(path)))).toBe(true);
|
||||
},
|
||||
);
|
||||
|
||||
it('een onbekende URL geeft 404 met de bytes van 404.html', async () => {
|
||||
const reply = await get(nginx.origin, '/bestaat-niet', { raw: true });
|
||||
expect(reply.status).toBe(404);
|
||||
expect(reply.body.equals(bytesOf(NOT_FOUND_FILE))).toBe(true);
|
||||
});
|
||||
|
||||
it('de map soorten-fotoshoots/ staat naast soorten-fotoshoots.html zonder dat /soorten-fotoshoots omleidt', async () => {
|
||||
expect(
|
||||
statSync(join(clientDir, 'soorten-fotoshoots')).isDirectory(),
|
||||
).toBe(true);
|
||||
expect(existsSync(join(clientDir, 'soorten-fotoshoots.html'))).toBe(
|
||||
true,
|
||||
);
|
||||
const page = await get(nginx.origin, '/soorten-fotoshoots', {
|
||||
raw: true,
|
||||
});
|
||||
expect(page.status).toBe(200);
|
||||
expect(page.body.equals(bytesOf('soorten-fotoshoots.html'))).toBe(true);
|
||||
const dir = await get(nginx.origin, '/soorten-fotoshoots/', {
|
||||
raw: true,
|
||||
});
|
||||
expect(dir.status).toBe(301);
|
||||
expect(dir.headers.location).toBe('/soorten-fotoshoots');
|
||||
});
|
||||
|
||||
it('toont geen maplijst voor /assets', async () => {
|
||||
const reply = await get(nginx.origin, '/assets', { raw: true });
|
||||
expect(reply.status).toBe(404);
|
||||
expect(reply.body.equals(bytesOf(NOT_FOUND_FILE))).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user