Generates the nginx rules for prerendered pages

Pages now map to their html file, other forms get one redirect, unknown URLs
get a real 404 and responses are compressed. A browser-free test suite runs the
rules against a real nginx, in CI only so far.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-01 03:00:07 +01:00
co-authored by Claude Opus 5.5
parent 4f32042410
commit 33334b889d
16 changed files with 1389 additions and 36 deletions
@@ -155,7 +155,7 @@ PBT-06 (stateful): none; the redirect function is stateless. PBT-07 (generators)
## Part A: Setup and baseline (batch B0, Haiku, exclusive)
### Step 1: Confirm a green baseline and create the log [ ]
### Step 1: Confirm a green baseline and create the log [x]
- Executor: Haiku.
- Implements: NFR-PR-Q-01 (baseline), setup.
@@ -174,7 +174,7 @@ PBT-06 (stateful): none; the redirect function is stateless. PBT-07 (generators)
The riskiest mechanism is the nginx block (a `map`, a server-level `if` and `rewrite`, `error_page` with an internal location, `try_files` without `$uri/`, a custom gzip setup behind a proxy). It is built in its real form and proven with a real nginx process before the rest. Reading the config is not a proof.
### Step 2: Shared URL and type modules (BR-HST-04, 06, 11) [ ]
### Step 2: Shared URL and type modules (BR-HST-04, 06, 11) [x]
- Executor: Sonnet.
- Implements: BR-HST-03, 04, 06, 11; P-HST-02, 03, 04 (function level).
@@ -186,8 +186,9 @@ The riskiest mechanism is the nginx block (a `map`, a server-level `if` and `rew
4. `canonicalUrls.test.ts`: example-based table (the redirect rows of infrastructure-design.md § 3.1) and properties: P-HST-02 (every `pageVariant` returns the canonical page, `(invariant)`), P-HST-03 (the result is a fixpoint: `canonicalRedirect(result)` is `undefined`, and `stripTrailingSlashes(result)` is `undefined`, `(idempotent)`; the combined function used by the resolver needs at most 2 hops for any `pageVariant` or `unknownPath` plus slashes), P-HST-04 (a target starts with `/`, never `//` or `/\`, has no control characters, and is one of `pagePaths`, `(invariant)`; run it also over `hostilePath`: a non-`undefined` result is still one of `pagePaths`).
- Done when: `pnpm exec vitest run config/canonicalUrls.test.ts` green; `pnpm exec tsc --noEmit`, `pnpm lint` clean; `pnpm exec prettier --check` on the new files clean.
- Record: one line with the exported names.
- Done. `canonicalUrls.ts`: pagePaths, redirectNames, escapeRegex, variantPattern, canonicalRedirect, stripTrailingSlashes. `compressibleTypes.ts`: FileType, compressibleTypes, plainTypes, compressibleExtensions, gzipMimeTypes. `src/test/urlArbitraries.ts`: knownPage, caseVariant, pageVariant, unknownPath, hostilePath, queryString. stripTrailingSlashes returns undefined when the stripped target would start with // or / or hold control characters (BR-HST-06), so the resolver treats such a path as unknown.
### Step 3: The nginx block (BR-HST-01 to 09, 11 to 13; V14) [ ]
### Step 3: The nginx block (BR-HST-01 to 09, 11 to 13; V14) [x]
- Executor: Sonnet.
- Implements: BR-HST-01 to 09, 11 to 13; FR-PR-14, 16, 23; V1 (documentation part), V14.
@@ -200,8 +201,9 @@ The riskiest mechanism is the nginx block (a `map`, a server-level `if` and `rew
5. Run `pnpm server-config`. Update the three `serverConfig.test.ts` tests that § 6 lists for nginx (they assert the old SPA fallback and the location count) with stricter replacements; the rest of the test file is unchanged and must pass.
- Done when: `pnpm exec vitest run config/serverConfig.test.ts` green (the IIS SPA-fallback test is still the old one and still passes because Step 9 has not run); the committed `deploy/nginx/andreaslop-test.conf` equals `nginxTestConf()`; `pnpm exec tsc --noEmit`, `pnpm lint` clean.
- Record: verification log V1 (documentation), V14.
- Done. V1 documentation part and V14 recorded. The three serverConfig tests of section 6 (noindex/try_files, location count) changed and are stricter. The nginx.org rewrite page does not document escaping of the replacement; BR-HST-06 relies on it and the real nginx test must show it.
### Step 4: Fixture site, nginx harness and the first contract test (BR-HST-24) [ ]
### Step 4: Fixture site, nginx harness and the first contract test (BR-HST-24) [x]
- Executor: Sonnet.
- Implements: BR-HST-24; V1 to V5 (tests); P-HST-09 (first version).
@@ -212,8 +214,9 @@ The riskiest mechanism is the nginx block (a `map`, a server-level `if` and `rew
3. `serverRules.e2e.ts`: `describe.skipIf`-style gate: if `findNginx()` is undefined, then when `process.env.CI` is set the suite **fails** with the message "nginx ontbreekt in CI (BR-HST-24)", otherwise it is skipped and prints one visible line `nginx niet gevonden: serverregeltests overgeslagen (zie BR-HST-24)`. First version tests, against real nginx and the fixture: every row of infrastructure-design.md § 3.1 (status, `Location` path+query, which fixture file was served by the marker text, `404.html` body on 404); the five security headers + `Cache-Control` + `X-Robots-Tag` on 200, 301 and 404 responses (V2, V4); `/soorten-fotoshoots` serves the file and `/soorten-fotoshoots/` redirects (V3); `/` works without an `index` directive; HEAD on a page and on an unknown URL; `/robots.txt` returns `Disallow: /`; `Content-Encoding: gzip` for `.html`, `.js`, `.css`, `.svg`, `.json`, `.xml`, `.txt`, none for `.woff2` and `.png`, in both mime variants (V5); a raw HTTP/1.0 request over `node:net` with `Accept-Encoding: gzip` also gets gzip; `Vary: Accept-Encoding` present; `/assets/*` has exactly **one** `Cache-Control` header, `public, max-age=31536000, immutable` (count the raw header lines through `node:http` `rawHeaders`, not through the merged `fetch` Headers object), all else `no-cache`; the full header set is present on a 301, on the 404 page, on `/404` and `/404.html` (the `error_page` path) and on `/assets/*`; hostile paths (`//evil.example/`, `/\evil.example`) never yield a 3xx whose `Location` starts with `//` or `/\`.
- Done when: `pnpm exec tsc --noEmit`, `pnpm lint` clean; `pnpm exec vitest run --config vitest.e2e.config.ts e2e/serverRules.e2e.ts` either passes against a local nginx (if Step 1 found one) or prints the skip line (no nginx locally) and exits 0 outside CI; with `CI=true` and no nginx it fails with the message above (run it once to prove the gate; then unset `CI`).
- Record: which nginx version ran, or "skipped: no local nginx".
- Skipped: no local nginx. Gate proven: without CI one visible skip line, exit 0; with CI=true the suite fails with "nginx ontbreekt in CI (BR-HST-24)". The harness has never started a real nginx (only type-checked), so a first CI run may still show harness defects.
### Step 5: Install nginx and lftp in the CI job (V12) [ ]
### Step 5: Install nginx and lftp in the CI job (V12) [x]
- Executor: Sonnet.
- Implements: BR-HST-24; V12.
@@ -221,6 +224,7 @@ The riskiest mechanism is the nginx block (a `map`, a server-level `if` and `rew
- Do: in job `lighthouse`, before the `Browsertests` step add a step "Install nginx and lftp (serverregeltests)": `sudo apt-get update && sudo apt-get install -y nginx lftp`, then stop a service the package may have started (`sudo service nginx stop || true`), then `nginx -v`. Give the `Browsertests` step `CI: 'true'` in its `env` (so a missing nginx fails the job; do not rely on the runner setting it). Do not touch the deploy jobs yet (Step 15). Keep the file's Dutch comment style and explain why the packages are installed (the Ubuntu runner image carries nginx 1.24; the Pi runs 1.30.6; accepted gap, BR-HST-24).
- Done when: the YAML parses (`pnpm exec prettier --check ../.gitea/workflows/continuous_integration.yaml` or, if prettier rejects the path, `node -e` with the `yaml` parser is NOT available: use `pnpm exec prettier --parser yaml --check` on the file contents via stdin); the diff shows only the new step and the env line.
- Record: the exact diff.
- Done: one new step "Install nginx and lftp (serverregeltests)" before Browsertests, plus `CI: 'true'` in the env of Browsertests, with Dutch comments. See `git diff .gitea`.
### Step 6: Checkpoint CP1: the nginx proof [ ] STOP-AND-ASK if no local nginx