Production upload: plain FTP (no FTPS), no web.config from this repo, optional port
Continuous Integration / check (pull_request) Successful in 4m12s
Continuous Integration / build-test (pull_request) Skipped
Continuous Integration / deploy-test (pull_request) Skipped
Continuous Integration / lighthouse (pull_request) Successful in 44m28s
Continuous Integration / deploy-production (pull_request) Skipped

The production package only offers plain FTP. The upload goes into the
prerendered-pages folder of the CMS host; the host and its web.config come from
the CMS pipeline.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-11-18 21:17:04 +01:00
co-authored by Claude Sonnet 5.5
parent 2147fcec35
commit 1f087581d4
5 changed files with 85 additions and 33 deletions
+51 -13
View File
@@ -539,7 +539,6 @@ describe.skipIf(toolsMissing || lftpMissing)('upload-production.sh', () => {
'robots.txt',
'soorten-fotoshoots/newborn.html',
'stale.txt',
'web.config',
]);
const third = await upload(dist, target, '3');
@@ -551,7 +550,6 @@ describe.skipIf(toolsMissing || lftpMissing)('upload-production.sh', () => {
'over-mij.html',
'robots.txt',
'soorten-fotoshoots/newborn.html',
'web.config',
]);
});
@@ -567,19 +565,18 @@ describe.skipIf(toolsMissing || lftpMissing)('upload-production.sh', () => {
);
expect(rounds).toEqual(['1', '2', '3']);
const expected = [...validFiles, 'web.config'].sort();
const expected = [...validFiles].sort();
expect(await tree(target)).toEqual(expected);
});
it('laat bij een tweede deploy geen back-upbestanden met ~ achter', async () => {
const { dist, target } = await setup();
expect((await upload(dist, target)).code).toBe(0);
// Nu bestaat web.config al op de host, en alles wordt overschreven
// Nu bestaat alles al op de host en wordt het overschreven
await write(dist, 'robots.txt', 'nieuwe inhoud');
expect((await upload(dist, target)).code).toBe(0);
const files = await tree(target);
expect(files.filter((file) => file.includes('~'))).toEqual([]);
expect(files).toContain('web.config');
});
it('weigert een ongeldige build en uploadt dan niets', async () => {
@@ -590,13 +587,12 @@ describe.skipIf(toolsMissing || lftpMissing)('upload-production.sh', () => {
expect(await tree(target)).toEqual(['stale.txt']);
});
it('neemt de web.config uit deploy/iis over', async () => {
it('zet geen web.config op de server: die hoort bij de CMS-host', async () => {
const { dist, target } = await setup();
const run = await upload(dist, target);
expect(run.code).toBe(0);
expect(await readFile(join(target, 'web.config'), 'utf8')).toBe(
await readFile(join(deployDir, 'iis/web.config'), 'utf8'),
);
expect(existsSync(join(target, 'web.config'))).toBe(false);
expect(existsSync(join(dist, 'web.config'))).toBe(false);
});
});
@@ -666,7 +662,7 @@ touch '${slash(marker)}'
},
);
it('zet in elke lftp-sessie de back-ups uit en de TLS-eisen aan', async () => {
it('zet in elke lftp-sessie de back-ups uit en TLS uit (gewone FTP)', async () => {
const dist = await makeDist();
const bin = await makeTemp('andreaslop-fakebin-');
const log = join(bin, 'opdrachten');
@@ -690,11 +686,53 @@ printf '%s\\n' "$2" >> '${slash(log)}'
const sessions = (await readFile(log, 'utf8'))
.split('\n')
.filter(Boolean);
// Ronde 1, web.config, ronde 2 (HTML) en ronde 3
expect(sessions).toHaveLength(4);
// Ronde 1, ronde 2 (HTML) en ronde 3
expect(sessions).toHaveLength(3);
for (const commands of sessions) {
expect(commands).toContain('set xfer:make-backup no;');
expect(commands).toContain('set ftp:ssl-force true;');
expect(commands).toContain('set ftp:ssl-allow no;');
expect(commands).toContain('set ftp:passive-mode on;');
expect(commands).not.toContain('ssl-force');
}
});
it('geeft FTP_PORT door aan lftp en weigert een ongeldige poort', async () => {
const dist = await makeDist();
const bin = await makeTemp('andreaslop-fakebin-');
const log = join(bin, 'argumenten');
await writeFile(
join(bin, 'lftp'),
`#!/bin/sh
printf '%s\n' "$*" >> '${slash(log)}'
`,
{ mode: 0o755 },
);
const env = {
PATH: `${bin}${delimiter}${process.env.PATH ?? ''}`,
FTP_HOST: 'ftp.example.test',
FTP_USER: 'gebruiker',
LFTP_PASSWORD: 'geheim',
};
const bad = await runScript(
'upload-production.sh',
[basename(dist), 'wwwroot'],
{ ...env, FTP_PORT: '21; rm -rf' },
dirname(dist),
);
expect(bad.code).toBe(2);
expect(existsSync(log)).toBe(false);
const good = await runScript(
'upload-production.sh',
[basename(dist), 'wwwroot'],
{ ...env, FTP_PORT: '2121' },
dirname(dist),
);
expect(good.code).toBe(0);
for (const line of (await readFile(log, 'utf8'))
.split('\n')
.filter(Boolean)) {
expect(line).toContain('-u gebruiker -p 2121 ftp.example.test');
}
});