Fixes the scroll to Contact from the price cards
Removing ?pakket= from the URL replaced the click's navigation before the router scrolled to #contact, and told it not to scroll, so nothing happened. The clean-up now asks the router to scroll there, below the fixed header. The review carousel's placeholder is now the longest review itself, so it matches the carousel's height at every width and no longer shifts the target while the page scrolls past it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -728,3 +728,15 @@ De foto mag nog iets kleiner? 75% van huidige groote maken is denk ik goed. Het
|
||||
**Context**: CONSTRUCTION - Unit 5 Code Generation (complete, awaiting approval)
|
||||
|
||||
---
|
||||
|
||||
## Unit 5 Contact — Bugs Reported on LAN, Fixed
|
||||
|
||||
**Timestamp**: 2026-10-21T01:30:00Z
|
||||
|
||||
**User Input**: "Er gebeurt niks als ik klik op de Boeken-knoppen. Geen effect en hij scrolt niet" / "Ik heb op lan getest" / "Zodra je klaar bent mag je weer comitten, pushen en deployen" / "Als ik op boek zwangerschap klik scrolt hij minder ver dan op de andere 2 knoppen" / "Wederom. Je mag comitten, pushen en deployen zodra je klaar bent"
|
||||
|
||||
**AI Response**: "Reproduced in real Chrome (CDP trace): the click pushed /?pakket=newborn#contact, our clean-up replaced it with hashScrollIntoView:false before the router's onRendered scroll, so no scroll happened (test still had unit 4, where #contact did not exist yet). Fixed: the clean-up navigation requests the hash scroll (smooth / auto under reduced motion); anchored sections get scroll-margin-top = header. Added an app test clicking 'Boek Newborn' asserting scrollIntoView on #contact (verified failing on the old code). Second bug: from the top card the review carousel loaded mid-scroll and its fixed placeholder height differed from the real height except at measured widths (+29px at 360, -44px at 600). Placeholder is now the longest review rendered like a slide plus the control height; no movement at 7 widths. CI run 555: deploy-test succeeded, Lighthouse job died on the Pi runner with exit -1 after pnpm install (infra). pnpm check green (238 tests, mobile 0.83, desktop 1.0). Committing, pushing, dispatching a test deploy as authorised."
|
||||
|
||||
**Context**: CONSTRUCTION - Unit 5 bug fixes (awaiting approval of unit 5)
|
||||
|
||||
---
|
||||
|
||||
Reference in New Issue
Block a user